From 0bead9ebe19b97b1e6d6587be07bc2ac57986011 Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Tue, 22 Aug 2023 10:58:10 +0100 Subject: [PATCH] vmm: cpu: Fix slow vector initialization warning: slow zero-filling initialization --> vmm/src/cpu.rs:1780:9 | 1779 | let mut mat_data: Vec = Vec::new(); | ---------- help: consider replacing this with: `vec![0; std::mem::size_of_val(&lapic)]` 1780 | mat_data.resize(std::mem::size_of_val(&lapic), 0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization = note: `#[warn(clippy::slow_vector_initialization)]` on by default Signed-off-by: Rob Bradford --- vmm/src/cpu.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vmm/src/cpu.rs b/vmm/src/cpu.rs index be7d45e3a..e95318aad 100644 --- a/vmm/src/cpu.rs +++ b/vmm/src/cpu.rs @@ -1776,8 +1776,7 @@ impl Cpu { _reserved: 0, }; - let mut mat_data: Vec = Vec::new(); - mat_data.resize(std::mem::size_of_val(&lapic), 0); + let mut mat_data: Vec = vec![0; std::mem::size_of_val(&lapic)]; // SAFETY: mat_data is large enough to hold lapic unsafe { *(mat_data.as_mut_ptr() as *mut LocalX2Apic) = lapic };