From 0dafd47a7ccc64100ecd73a7d31b8540d253c649 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Thu, 27 Jan 2022 14:29:26 +0100 Subject: [PATCH] vmm: openapi: Remove mention to net fds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While cloud-hypervisor does support receiving the file descriptors of a tuntap device, advertising the fds structure via the openAPI can lead to misinterpretations of what can and what should be done. An unadvertised consumer will think that they could rather just set the file descriptors there directly, or even pass them as a byte array. However, the proper way to go in those cases would be actually sending those via send_msg(), together with the request. As hacking the openAPI auto-generated code to properly do this is not *that* trivial, and as doing so during a `create VM` request is not supported, we better not advertising those. Please, for more details, also check: https://github.com/cloud-hypervisor/cloud-hypervisor/pull/3607#issuecomment-1020935523 Signed-off-by: Fabiano Fidêncio --- vmm/src/api/openapi/cloud-hypervisor.yaml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/vmm/src/api/openapi/cloud-hypervisor.yaml b/vmm/src/api/openapi/cloud-hypervisor.yaml index 476c179fe..77706e80a 100644 --- a/vmm/src/api/openapi/cloud-hypervisor.yaml +++ b/vmm/src/api/openapi/cloud-hypervisor.yaml @@ -771,11 +771,6 @@ components: default: "Client" id: type: string - fds: - type: array - items: - type: integer - format: int32 pci_segment: type: integer format: int16