External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2025-02-22 03:12:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmm: Factorize disk creation

Browse Source 
Since both Block and vhost_user::Blk implement the Migratable trait, we
can factorize the common part to simplify the code related to the disk
creation.

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
This commit is contained in:
Sebastien Boeuf 2022-05-05 10:38:17 +02:00
parent 54f39aa8cb
commit 425902b296
1 changed files with 26 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
vmm/src/device_manager.rs
View File

@ -2045,14 +2045,14 @@ impl DeviceManager {
info!("Creating virtio-block device: {:?}", disk_cfg); info!("Creating virtio-block device: {:?}", disk_cfg);
if disk_cfg.vhost_user { let (virtio_device, migratable_device) = if disk_cfg.vhost_user {
let socket = disk_cfg.vhost_socket.as_ref().unwrap().clone(); let socket = disk_cfg.vhost_socket.as_ref().unwrap().clone();
let vu_cfg = VhostUserConfig { let vu_cfg = VhostUserConfig {
socket, socket,
num_queues: disk_cfg.num_queues, num_queues: disk_cfg.num_queues,
queue_size: disk_cfg.queue_size, queue_size: disk_cfg.queue_size,
}; };
let vhost_user_block_device = Arc::new(Mutex::new( let vhost_user_block = Arc::new(Mutex::new(
match virtio_devices::vhost_user::Blk::new( match virtio_devices::vhost_user::Blk::new(
id.clone(), id.clone(),
vu_cfg, vu_cfg,
@ -2070,22 +2070,10 @@ impl DeviceManager {
}, },
)); ));
// Fill the device tree with a new node. In case of restore, we (
// know there is nothing to do, so we can simply override the Arc::clone(&vhost_user_block) as Arc<Mutex<dyn virtio_devices::VirtioDevice>>,
// existing entry. vhost_user_block as Arc<Mutex<dyn Migratable>>,
self.device_tree )
.lock()
.unwrap()
.insert(id.clone(), device_node!(id, vhost_user_block_device));
Ok(MetaVirtioDevice {
virtio_device: Arc::clone(&vhost_user_block_device)
as Arc<Mutex<dyn virtio_devices::VirtioDevice>>,
iommu: false,
id,
pci_segment: disk_cfg.pci_segment,
dma_handler: None,
})
} else { } else {
let mut options = OpenOptions::new(); let mut options = OpenOptions::new();
options.read(true); options.read(true);
@ -2151,7 +2139,7 @@ impl DeviceManager {
} }
}; };
let dev = Arc::new(Mutex::new( let virtio_block = Arc::new(Mutex::new(
virtio_devices::Block::new( virtio_devices::Block::new(
id.clone(), id.clone(),
image, image,
@ -2173,25 +2161,27 @@ impl DeviceManager {
.map_err(DeviceManagerError::CreateVirtioBlock)?, .map_err(DeviceManagerError::CreateVirtioBlock)?,
)); ));
let virtio_device = Arc::clone(&dev) as Arc<Mutex<dyn virtio_devices::VirtioDevice>>; (
let migratable_device = dev as Arc<Mutex<dyn Migratable>>; Arc::clone(&virtio_block) as Arc<Mutex<dyn virtio_devices::VirtioDevice>>,
virtio_block as Arc<Mutex<dyn Migratable>>,
)
};
// Fill the device tree with a new node. In case of restore, we // Fill the device tree with a new node. In case of restore, we
// know there is nothing to do, so we can simply override the // know there is nothing to do, so we can simply override the
// existing entry. // existing entry.
self.device_tree self.device_tree
.lock() .lock()
.unwrap() .unwrap()
.insert(id.clone(), device_node!(id, migratable_device)); .insert(id.clone(), device_node!(id, migratable_device));
Ok(MetaVirtioDevice { Ok(MetaVirtioDevice {
virtio_device, virtio_device,
iommu: disk_cfg.iommu, iommu: disk_cfg.iommu,
id, id,
pci_segment: disk_cfg.pci_segment, pci_segment: disk_cfg.pci_segment,
dma_handler: None, dma_handler: None,
}) })
}
} }
fn make_virtio_block_devices(&mut self) -> DeviceManagerResult<Vec<MetaVirtioDevice>> { fn make_virtio_block_devices(&mut self) -> DeviceManagerResult<Vec<MetaVirtioDevice>> {