External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2025-01-20 19:45:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

block: vhdx: use C ABI-qualification for packed structures

Browse Source 
This fixes the following issue from beta Clippy:

error: item uses `packed` representation without ABI-qualification
Error:    --> block/src/vhdx/vhdx_header.rs:333:1
    |
331 |   #[repr(packed)]
    |          ------ `packed` representation set here
332 |   #[derive(Clone, Copy, Debug)]
333 | / pub struct RegionTableEntry {
334 | |     pub guid: Uuid,
335 | |     pub file_offset: u64,
336 | |     pub length: u32,
337 | |     pub required: u32,
338 | | }
    | |_^
    |
    = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
    = help: qualify the desired ABI explicity via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi

Signed-off-by: Wei Liu <liuwe@microsoft.com>
This commit is contained in:
Wei Liu 2025-01-09 01:49:16 +00:00 committed by Rob Bradford
parent e6e78e5986
commit 5b29eba636
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
block/src/vhdx/vhdx_header.rs
View File

@ -110,7 +110,7 @@ impl FileTypeIdentifier {
} }
} }
#[repr(packed)] #[repr(C, packed)]
#[derive(Clone, Copy, Debug)] #[derive(Clone, Copy, Debug)]
pub struct Header { pub struct Header {
pub signature: u32, pub signature: u32,
@ -203,7 +203,7 @@ impl Header {
} }
} }
#[repr(packed)] #[repr(C, packed)]
#[derive(Clone, Copy, Debug)] #[derive(Clone, Copy, Debug)]
struct RegionTableHeader { struct RegionTableHeader {
pub signature: u32, pub signature: u32,
@ -328,7 +328,7 @@ impl RegionInfo {
} }
} }
#[repr(packed)] #[repr(C, packed)]
#[derive(Clone, Copy, Debug)] #[derive(Clone, Copy, Debug)]
pub struct RegionTableEntry { pub struct RegionTableEntry {
pub guid: Uuid, pub guid: Uuid,

4
block/src/vhdx/vhdx_metadata.rs
View File

@ -267,7 +267,7 @@ impl DiskSpec {
} }
} }
#[repr(packed)] #[repr(C, packed)]
#[derive(Default, Debug, Clone, Copy)] #[derive(Default, Debug, Clone, Copy)]
struct MetadataTableHeader { struct MetadataTableHeader {
signature: u64, signature: u64,
@ -298,7 +298,7 @@ impl MetadataTableHeader {
} }
} }
#[repr(packed)] #[repr(C, packed)]
#[derive(Default, Debug, Clone, Copy)] #[derive(Default, Debug, Clone, Copy)]
pub struct MetadataTableEntry { pub struct MetadataTableEntry {
item_id: Uuid, item_id: Uuid,