From 64e217cf392509c1ac308ecaef57599e01f774dc Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Fri, 3 Sep 2021 10:28:33 +0100 Subject: [PATCH] pci: configuration: Upgrade log level of PCI BAR reprogramming message This message only occurs sporadically and so it should be included at info!() level. Enhance the output to also include the BAR number. Signed-off-by: Rob Bradford --- pci/src/configuration.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/pci/src/configuration.rs b/pci/src/configuration.rs index 80b374bb3..f1bf0957a 100644 --- a/pci/src/configuration.rs +++ b/pci/src/configuration.rs @@ -794,9 +794,9 @@ impl PciConfiguration { return None; } - debug!( - "DETECT BAR REPROG: current 0x{:x}, new 0x{:x}", - self.registers[reg_idx], value + info!( + "Detected BAR reprogramming: (BAR {}) 0x{:x}->0x{:x}", + reg_idx, self.registers[reg_idx], value ); let old_base = u64::from(self.bars[bar_idx].addr & mask); let new_base = u64::from(value & mask); @@ -820,9 +820,9 @@ impl PciConfiguration { != (self.bars[bar_idx - 1].addr & self.writable_bits[reg_idx - 1]) || (value & mask) != (self.bars[bar_idx].addr & mask)) { - debug!( - "DETECT BAR REPROG: current 0x{:x}, new 0x{:x}", - self.registers[reg_idx], value + info!( + "Detected BAR reprogramming: (BAR {}) 0x{:x}->0x{:x}", + reg_idx, self.registers[reg_idx], value ); let old_base = u64::from(self.bars[bar_idx].addr & mask) << 32 | u64::from(self.bars[bar_idx - 1].addr & self.writable_bits[reg_idx - 1]); @@ -850,9 +850,9 @@ impl PciConfiguration { return None; } - debug!( - "DETECT ROM BAR REPROG: current 0x{:x}, new 0x{:x}", - self.registers[reg_idx], value + info!( + "Detected ROM BAR reprogramming: (BAR {}) 0x{:x}->0x{:x}", + reg_idx, self.registers[reg_idx], value ); let old_base = u64::from(self.rom_bar_addr & mask); let new_base = u64::from(value & mask);