External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2025-01-20 11:35:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

vm-device: bus: Fix clippy issues inside tests

Browse Source 
Found by:  cargo clippy --all-features --all --tests

Signed-off-by: Rob Bradford <robert.bradford@intel.com>
This commit is contained in:
Rob Bradford 2020-11-25 16:22:41 +00:00 committed by Samuel Ortiz
parent 40a2e3b462
commit 74fe032827
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
vm-device/src/bus.rs
View File

@ -282,10 +282,11 @@ mod tests {
assert!(bus.insert(dummy.clone(), 0x0, 0x20).is_err()); assert!(bus.insert(dummy.clone(), 0x0, 0x20).is_err());
assert!(bus.insert(dummy.clone(), 0x20, 0x05).is_ok()); assert!(bus.insert(dummy.clone(), 0x20, 0x05).is_ok());
assert!(bus.insert(dummy.clone(), 0x25, 0x05).is_ok()); assert!(bus.insert(dummy.clone(), 0x25, 0x05).is_ok());
assert!(bus.insert(dummy.clone(), 0x0, 0x10).is_ok()); assert!(bus.insert(dummy, 0x0, 0x10).is_ok());
} }
#[test] #[test]
#[allow(clippy::redundant_clone)]
fn bus_read_write() { fn bus_read_write() {
let bus = Bus::new(); let bus = Bus::new();
let dummy = Arc::new(Mutex::new(DummyDevice)); let dummy = Arc::new(Mutex::new(DummyDevice));
@ -297,12 +298,13 @@ mod tests {
assert!(bus.read(0x16, &mut [0, 0, 0, 0]).is_ok()); assert!(bus.read(0x16, &mut [0, 0, 0, 0]).is_ok());
assert!(bus.write(0x16, &[0, 0, 0, 0]).is_ok()); assert!(bus.write(0x16, &[0, 0, 0, 0]).is_ok());
assert!(bus.read(0x20, &mut [0, 0, 0, 0]).is_err()); assert!(bus.read(0x20, &mut [0, 0, 0, 0]).is_err());
assert!(bus.write(0x20, &mut [0, 0, 0, 0]).is_err()); assert!(bus.write(0x20, &[0, 0, 0, 0]).is_err());
assert!(bus.read(0x06, &mut [0, 0, 0, 0]).is_err()); assert!(bus.read(0x06, &mut [0, 0, 0, 0]).is_err());
assert!(bus.write(0x06, &mut [0, 0, 0, 0]).is_err()); assert!(bus.write(0x06, &[0, 0, 0, 0]).is_err());
} }
#[test] #[test]
#[allow(clippy::redundant_clone)]
fn bus_read_write_values() { fn bus_read_write_values() {
let bus = Bus::new(); let bus = Bus::new();
let dummy = Arc::new(Mutex::new(ConstantDevice)); let dummy = Arc::new(Mutex::new(ConstantDevice));
@ -318,6 +320,7 @@ mod tests {
} }
#[test] #[test]
#[allow(clippy::redundant_clone)]
fn busrange_cmp() { fn busrange_cmp() {
let range = BusRange { base: 0x10, len: 2 }; let range = BusRange { base: 0x10, len: 2 };
assert_eq!(range, BusRange { base: 0x10, len: 3 }); assert_eq!(range, BusRange { base: 0x10, len: 3 });
@ -332,7 +335,7 @@ mod tests {
let mut data = [1, 2, 3, 4]; let mut data = [1, 2, 3, 4];
let device = Arc::new(Mutex::new(DummyDevice)); let device = Arc::new(Mutex::new(DummyDevice));
assert!(bus.insert(device.clone(), 0x10, 0x10).is_ok()); assert!(bus.insert(device.clone(), 0x10, 0x10).is_ok());
assert!(bus.write(0x10, &mut data).is_ok()); assert!(bus.write(0x10, &data).is_ok());
assert!(bus.read(0x10, &mut data).is_ok()); assert!(bus.read(0x10, &mut data).is_ok());
assert_eq!(data, [1, 2, 3, 4]); assert_eq!(data, [1, 2, 3, 4]);
} }