From 7589f1b3bf454432fbe1f42fe12365dc70eccde3 Mon Sep 17 00:00:00 2001
From: Ricardo Koller <ricarkol@gmail.com>
Date: Tue, 4 Aug 2020 11:29:00 -0400
Subject: [PATCH] vhost_user_fs: increase RLIMIT_NOFILE

Increase the number of open files limit for the sandboxed process to the
maximum allowed in the system. The maximum is obtained by reading the
/proc/sys/fs/nr_open sysctl file, and the setting is done using the setrlimit
syscall. Failure to read or parse the nr_open file, or to set the rlimit
results in a panic.

Signed-off-by: Ricardo Koller <ricarkol@gmail.com>
---
 vhost_user_fs/src/sandbox.rs | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/vhost_user_fs/src/sandbox.rs b/vhost_user_fs/src/sandbox.rs
index 0ef09156e..4ddd4d84d 100644
--- a/vhost_user_fs/src/sandbox.rs
+++ b/vhost_user_fs/src/sandbox.rs
@@ -4,7 +4,7 @@
 
 use std::ffi::CString;
 use std::os::unix::io::RawFd;
-use std::{fmt, io};
+use std::{fmt, fs, io};
 
 use tempdir::TempDir;
 
@@ -50,6 +50,12 @@ pub enum Error {
     UmountTempDir(io::Error),
     /// Call to libc::unshare returned an error.
     Unshare(io::Error),
+    /// Failed to read procfs.
+    ReadProc(io::Error),
+    /// Failed to parse `/proc/sys/fs/nr_open`.
+    InvalidNrOpen(std::num::ParseIntError),
+    /// Failed to set rlimit.
+    SetRlimit(io::Error),
 }
 
 impl fmt::Display for Error {
@@ -249,6 +255,29 @@ impl Sandbox {
         Ok(())
     }
 
+    /// Sets the limit of open files to the max possible.
+    fn setup_nofile_rlimit(&self) -> Result<(), Error> {
+        // /proc/sys/fs/nr_open is a sysctl file that shows the maximum number
+        // of file-handles a process can allocate.
+        let path = "/proc/sys/fs/nr_open";
+        let max_str = fs::read_to_string(path).map_err(|e| Error::ReadProc(e))?;
+        let max = max_str
+            .trim()
+            .parse()
+            .map_err(|e| Error::InvalidNrOpen(e))?;
+
+        let limit = libc::rlimit {
+            rlim_cur: max,
+            rlim_max: max,
+        };
+        let ret = unsafe { libc::setrlimit(libc::RLIMIT_NOFILE, &limit) };
+        if ret < 0 {
+            Err(Error::SetRlimit(std::io::Error::last_os_error()))
+        } else {
+            Ok(())
+        }
+    }
+
     /// Set up sandbox, fork and jump into it.
     ///
     /// On success, the returned value will be the PID of the child for the parent and `None` for
@@ -275,6 +304,7 @@ impl Sandbox {
             0 => {
                 // This is the child. Request to receive SIGTERM on parent's death.
                 unsafe { libc::prctl(libc::PR_SET_PDEATHSIG, libc::SIGTERM) };
+                self.setup_nofile_rlimit()?;
                 self.setup_mounts()?;
                 Ok(None)
             }