From 7dc9259c6cf1961eed165e287dd7911ff1f7ff4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Fri, 25 Feb 2022 12:40:44 +0100 Subject: [PATCH] scripts: dev_cli: Don't quote $features_build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 2805e7b1dc203ff4468e3743afe2fe77f444a0a8 quoted enclose variables to prevent globbing or incorrect splitting. However, by doing with with $features_build it broke the capability to call the script as: ``` $ ./scripts/dev_cli.sh build --release --libc musl -- --features tdx ``` Before 2805e7b1dc203ff4468e3743afe2fe77f444a0a8 it simply worked, after, the result is: ``` docker run --user 1000:1000 --workdir /cloud-hypervisor --rm --volume /dev/kvm --volume /home/ffidenci/go/src/github.com/cloud-hypervisor/cloud-hypervisor:/cloud-hypervisor --env RUSTFLAGS= cloudhypervisor/dev:20220223-0 cargo build --all '' --target-dir /cloud-hypervisor/build/cargo_target --features tdx --release --target x86_64-unknown-linux-musl error: Found argument '' which wasn't expected, or isn't valid in this context USAGE: cargo build --all For more information try --help ``` Signed-off-by: Fabiano Fidêncio --- scripts/dev_cli.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/dev_cli.sh b/scripts/dev_cli.sh index 6c69c7400..275298088 100755 --- a/scripts/dev_cli.sh +++ b/scripts/dev_cli.sh @@ -283,7 +283,7 @@ cmd_build() { --volume "$CLH_ROOT_DIR:$CTR_CLH_ROOT_DIR" $exported_volumes \ --env RUSTFLAGS="$rustflags" \ "$CTR_IMAGE" \ - cargo build --all "$features_build" \ + cargo build --all $features_build \ --target-dir "$CTR_CLH_CARGO_TARGET" \ "${cargo_args[@]}" && say "Binaries placed under $CLH_CARGO_TARGET/$target/$build" }