External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2024-12-22 13:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

pci: Fix add_capability unit test

Browse Source 
The structure provided to the add_capability() function should only
contain what comes after the capability ID and the next capability
pointer, which are located on the first WORD.

Because the structure TestCap included _vndr and _next fields, they
were directly set after the first WORD, while the assertion was
expecting to find the values of len and foo fields.

Fixes #105

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
This commit is contained in:
Sebastien Boeuf 2019-08-02 10:58:43 -07:00 committed by Rob Bradford
parent 9caad7394d
commit 846505d360
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pci/src/configuration.rs
View File

@ -710,8 +710,6 @@ mod tests {
#[derive(Clone, Copy, Default)] #[derive(Clone, Copy, Default)]
#[allow(dead_code)] #[allow(dead_code)]
struct TestCap { struct TestCap {
_vndr: u8,
_next: u8,
len: u8, len: u8,
foo: u8, foo: u8,
} }
@ -730,7 +728,6 @@ mod tests {
} }
#[test] #[test]
#[ignore]
fn add_capability() { fn add_capability() {
let mut cfg = PciConfiguration::new( let mut cfg = PciConfiguration::new(
0x1234, 0x1234,
@ -745,18 +742,11 @@ mod tests {
); );
// Add two capabilities with different contents. // Add two capabilities with different contents.
let cap1 = TestCap { let cap1 = TestCap { len: 4, foo: 0xAA };
_vndr: 0,
_next: 0,
len: 4,
foo: 0xAA,
};
let cap1_offset = cfg.add_capability(&cap1).unwrap(); let cap1_offset = cfg.add_capability(&cap1).unwrap();
assert_eq!(cap1_offset % 4, 0); assert_eq!(cap1_offset % 4, 0);
let cap2 = TestCap { let cap2 = TestCap {
_vndr: 0,
_next: 0,
len: 0x04, len: 0x04,
foo: 0x55, foo: 0x55,
}; };