External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2024-06-30 23:12:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmm: cpu: Avoid useless cloning of Arc<Mutex<Vcpu>>

Browse Source 
Since the object returned from CpuManager.create_vcpu() is never used,
we can avoid the cloning of this object.

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
This commit is contained in:
Sebastien Boeuf 2022-02-18 09:06:19 +01:00
parent 9aab70ec1a
commit a3dfe726f8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vmm/src/cpu.rs
View File

@ -648,7 +648,7 @@ impl CpuManager {
cpu_id: u8,
entry_point: Option<EntryPoint>,
snapshot: Option<Snapshot>,
) -> Result<Arc<Mutex<Vcpu>>> {
) -> Result<()> {
info!("Creating vCPU: cpu_id = {}", cpu_id);
let mut vcpu = Vcpu::new(cpu_id, &self.vm, Some(self.vmmops.clone()))?;
@ -676,9 +676,9 @@ impl CpuManager {
// Adding vCPU to the CpuManager's vCPU list.
let vcpu = Arc::new(Mutex::new(vcpu));
self.vcpus.push(Arc::clone(&vcpu));
self.vcpus.push(vcpu);
Ok(vcpu)
Ok(())
}
/// Only create new vCPUs if there aren't any inactive ones to reuse