From ab12e7c294788d75a0deab706b264b9a8686340c Mon Sep 17 00:00:00 2001 From: Songqian Li Date: Mon, 30 Sep 2024 11:37:30 +0800 Subject: [PATCH] vmm: fix cargo clippy error for rust 1.77 Since cloning Option> will clone for Arc, this patch fixes the follow warning: warning: this call to `as_ref.map(...)` does nothing --> vmm/src/lib.rs:872:13 | 872 | self.console_resize_pipe.as_ref().map(Arc::clone), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.console_resize_pipe.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref = note: `#[warn(clippy::useless_asref)]` on by default Signed-off-by: Songqian Li --- vmm/src/lib.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vmm/src/lib.rs b/vmm/src/lib.rs index c654ae11a..bad13fc65 100644 --- a/vmm/src/lib.rs +++ b/vmm/src/lib.rs @@ -869,7 +869,7 @@ impl Vmm { activate_evt, timestamp, self.console_info.clone(), - self.console_resize_pipe.as_ref().map(Arc::clone), + self.console_resize_pipe.clone(), Arc::clone(&self.original_termios_opt), Some(snapshot), ) @@ -1307,7 +1307,7 @@ impl RequestHandler for Vmm { self.hypervisor.clone(), activate_evt, self.console_info.clone(), - self.console_resize_pipe.as_ref().map(Arc::clone), + self.console_resize_pipe.clone(), Arc::clone(&self.original_termios_opt), None, None, @@ -1434,7 +1434,7 @@ impl RequestHandler for Vmm { self.hypervisor.clone(), activate_evt, self.console_info.clone(), - self.console_resize_pipe.as_ref().map(Arc::clone), + self.console_resize_pipe.clone(), Arc::clone(&self.original_termios_opt), Some(snapshot), Some(source_url), @@ -1536,7 +1536,7 @@ impl RequestHandler for Vmm { self.hypervisor.clone(), activate_evt, self.console_info.clone(), - self.console_resize_pipe.as_ref().map(Arc::clone), + self.console_resize_pipe.clone(), Arc::clone(&self.original_termios_opt), None, None,