External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2025-01-18 10:35:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmm: Fix clippy warnings

Browse Source 
This patch fixes following warnings:

error: boolean to int conversion using if
   --> vmm/src/vm.rs:866:42
|
|                       .create_vm_with_type(if sev_snp_enabled.into() {
    |  __________________________________________^
| |                         1 // SEV_SNP_ENABLED
| |                     } else {
| |                         0 // SEV_SNP_DISABLED
| |                     })
| |_____________________^ help: replace with from: `u64::from(sev_snp_enabled.into())`
|
  = note: `-D clippy::bool-to-int-with-if` implied by `-D warnings`
  = note: `sev_snp_enabled.into() as u64` or `sev_snp_enabled.into().into()` can also be valid options
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if

error: useless conversion to the same type: `bool`
   --> vmm/src/vm.rs:866:45
|
|                     .create_vm_with_type(if sev_snp_enabled.into() {
|                                             ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `sev_snp_enabled`
|
  = note: `-D clippy::useless-conversion` implied by `-D warnings`
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: could not compile `vmm` due to 2 previous errors

Signed-off-by: Muminul Islam <muislam@microsoft.com>
This commit is contained in:
Muminul Islam 2023-10-20 15:21:30 -07:00 committed by Bo Chen
parent 53b8e1d01e
commit afe798fc19
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
vmm/src/vm.rs
View File

@ -854,20 +854,18 @@ impl Vm {
cfg_if::cfg_if! { cfg_if::cfg_if! {
if #[cfg(feature = "tdx")] { if #[cfg(feature = "tdx")] {
// Passing KVM_X86_TDX_VM: 1 if tdx_enabled is true
// Otherwise KVM_X86_LEGACY_VM: 0
// value of tdx_enabled is mapped to KVM_X86_TDX_VM or KVM_X86_LEGACY_VM
let vm = hypervisor let vm = hypervisor
.create_vm_with_type(if tdx_enabled { .create_vm_with_type(u64::from(tdx_enabled))
1 // KVM_X86_TDX_VM
} else {
0 // KVM_X86_LEGACY_VM
})
.unwrap(); .unwrap();
} else if #[cfg(feature = "sev_snp")] { } else if #[cfg(feature = "sev_snp")] {
// Passing SEV_SNP_ENABLED: 1 if sev_snp_enabled is true
// Otherwise SEV_SNP_DISABLED: 0
// value of sev_snp_enabled is mapped to SEV_SNP_ENABLED for true or SEV_SNP_DISABLED for false
let vm = hypervisor let vm = hypervisor
.create_vm_with_type(if sev_snp_enabled { .create_vm_with_type(u64::from(sev_snp_enabled))
1 // SEV_SNP_ENABLED
} else {
0 // SEV_SNP_DISABLED
})
.unwrap(); .unwrap();
} else { } else {
let vm = hypervisor.create_vm().unwrap(); let vm = hypervisor.create_vm().unwrap();