External/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2024-11-05 03:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

vhost_rs: Fix unit test race condition

Browse Source 
The unit tests are run from cargo test through multiple threads of the
same process. For this reason, all these threads share their file
descriptors (because that's how this works on Linux), which means that
any of them can close a file descriptor opened from another thread.

In the context of create_listener() and accept_connection() tests, they
can run concurrently and this generates some failure when the file
descriptor create_listener() is binding to is being closed from the
accept_connection() test.

In order to avoid such race condition, this patch simply removes the
part of the unit test performing an explicit and unsafe file descriptor
closure.

Fixes #759

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
This commit is contained in:
Sebastien Boeuf 2020-02-18 15:35:04 +01:00
parent f7378bc092
commit be78c6da49
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
vhost_rs/src/vhost_user/connection.rs
View File

@ -489,7 +489,6 @@ mod tests {
use self::tempfile::tempfile; use self::tempfile::tempfile;
use super::*; use super::*;
use libc;
use std::fs::File; use std::fs::File;
use std::io::{Read, Seek, SeekFrom, Write}; use std::io::{Read, Seek, SeekFrom, Write};
use std::os::unix::io::FromRawFd; use std::os::unix::io::FromRawFd;
@ -513,15 +512,6 @@ mod tests {
// accept on a fd without incoming connection // accept on a fd without incoming connection
let conn = listener.accept().unwrap(); let conn = listener.accept().unwrap();
assert!(conn.is_none()); assert!(conn.is_none());
listener.set_nonblocking(true).unwrap();
// accept on a closed fd
unsafe {
libc::close(listener.as_raw_fd());
}
let conn2 = listener.accept();
assert!(conn2.is_err());
} }
#[test] #[test]