mirror of
https://github.com/cloud-hypervisor/cloud-hypervisor.git
synced 2024-07-16 14:17:16 +00:00
virtio-devices: block_io_uring: Port to VirtioCommon for feature handling
Signed-off-by: Rob Bradford <robert.bradford@intel.com>
This commit is contained in:
parent
e3abcdbff8
commit
dc9f1e4cdf
@ -11,7 +11,7 @@
|
|||||||
use super::Error as DeviceError;
|
use super::Error as DeviceError;
|
||||||
use super::{
|
use super::{
|
||||||
ActivateError, ActivateResult, EpollHelper, EpollHelperError, EpollHelperHandler, Queue,
|
ActivateError, ActivateResult, EpollHelper, EpollHelperError, EpollHelperHandler, Queue,
|
||||||
VirtioDevice, VirtioDeviceType, VirtioInterruptType, EPOLL_HELPER_EVENT_LAST,
|
VirtioCommon, VirtioDevice, VirtioDeviceType, VirtioInterruptType, EPOLL_HELPER_EVENT_LAST,
|
||||||
};
|
};
|
||||||
use crate::VirtioInterrupt;
|
use crate::VirtioInterrupt;
|
||||||
use anyhow::anyhow;
|
use anyhow::anyhow;
|
||||||
@ -300,13 +300,12 @@ impl EpollHelperHandler for BlockIoUringEpollHandler {
|
|||||||
|
|
||||||
/// Virtio device for exposing block level read/write operations on a host file.
|
/// Virtio device for exposing block level read/write operations on a host file.
|
||||||
pub struct BlockIoUring {
|
pub struct BlockIoUring {
|
||||||
|
common: VirtioCommon,
|
||||||
id: String,
|
id: String,
|
||||||
kill_evt: Option<EventFd>,
|
kill_evt: Option<EventFd>,
|
||||||
disk_image: File,
|
disk_image: File,
|
||||||
disk_path: PathBuf,
|
disk_path: PathBuf,
|
||||||
disk_nsectors: u64,
|
disk_nsectors: u64,
|
||||||
avail_features: u64,
|
|
||||||
acked_features: u64,
|
|
||||||
config: VirtioBlockConfig,
|
config: VirtioBlockConfig,
|
||||||
queue_evts: Option<Vec<EventFd>>,
|
queue_evts: Option<Vec<EventFd>>,
|
||||||
interrupt_cb: Option<Arc<dyn VirtioInterrupt>>,
|
interrupt_cb: Option<Arc<dyn VirtioInterrupt>>,
|
||||||
@ -373,13 +372,15 @@ impl BlockIoUring {
|
|||||||
}
|
}
|
||||||
|
|
||||||
Ok(BlockIoUring {
|
Ok(BlockIoUring {
|
||||||
|
common: VirtioCommon {
|
||||||
|
avail_features,
|
||||||
|
acked_features: 0u64,
|
||||||
|
},
|
||||||
id,
|
id,
|
||||||
kill_evt: None,
|
kill_evt: None,
|
||||||
disk_image,
|
disk_image,
|
||||||
disk_path,
|
disk_path,
|
||||||
disk_nsectors,
|
disk_nsectors,
|
||||||
avail_features,
|
|
||||||
acked_features: 0u64,
|
|
||||||
config,
|
config,
|
||||||
queue_evts: None,
|
queue_evts: None,
|
||||||
interrupt_cb: None,
|
interrupt_cb: None,
|
||||||
@ -397,8 +398,8 @@ impl BlockIoUring {
|
|||||||
BlockState {
|
BlockState {
|
||||||
disk_path: self.disk_path.clone(),
|
disk_path: self.disk_path.clone(),
|
||||||
disk_nsectors: self.disk_nsectors,
|
disk_nsectors: self.disk_nsectors,
|
||||||
avail_features: self.avail_features,
|
avail_features: self.common.avail_features,
|
||||||
acked_features: self.acked_features,
|
acked_features: self.common.acked_features,
|
||||||
config: self.config,
|
config: self.config,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@ -406,8 +407,8 @@ impl BlockIoUring {
|
|||||||
fn set_state(&mut self, state: &BlockState) -> io::Result<()> {
|
fn set_state(&mut self, state: &BlockState) -> io::Result<()> {
|
||||||
self.disk_path = state.disk_path.clone();
|
self.disk_path = state.disk_path.clone();
|
||||||
self.disk_nsectors = state.disk_nsectors;
|
self.disk_nsectors = state.disk_nsectors;
|
||||||
self.avail_features = state.avail_features;
|
self.common.avail_features = state.avail_features;
|
||||||
self.acked_features = state.acked_features;
|
self.common.acked_features = state.acked_features;
|
||||||
self.config = state.config;
|
self.config = state.config;
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
@ -415,13 +416,12 @@ impl BlockIoUring {
|
|||||||
|
|
||||||
fn update_writeback(&mut self) {
|
fn update_writeback(&mut self) {
|
||||||
// Use writeback from config if VIRTIO_BLK_F_CONFIG_WCE
|
// Use writeback from config if VIRTIO_BLK_F_CONFIG_WCE
|
||||||
let writeback =
|
let writeback = if self.common.feature_acked(VIRTIO_BLK_F_CONFIG_WCE.into()) {
|
||||||
if self.acked_features & 1 << VIRTIO_BLK_F_CONFIG_WCE == 1 << VIRTIO_BLK_F_CONFIG_WCE {
|
self.config.writeback == 1
|
||||||
self.config.writeback == 1
|
} else {
|
||||||
} else {
|
// Else check if VIRTIO_BLK_F_FLUSH negotiated
|
||||||
// Else check if VIRTIO_BLK_F_FLUSH negotiated
|
self.common.feature_acked(VIRTIO_BLK_F_FLUSH.into())
|
||||||
self.acked_features & 1 << VIRTIO_BLK_F_FLUSH == 1 << VIRTIO_BLK_F_FLUSH
|
};
|
||||||
};
|
|
||||||
|
|
||||||
info!(
|
info!(
|
||||||
"Changing cache mode to {}",
|
"Changing cache mode to {}",
|
||||||
@ -454,20 +454,11 @@ impl VirtioDevice for BlockIoUring {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn features(&self) -> u64 {
|
fn features(&self) -> u64 {
|
||||||
self.avail_features
|
self.common.avail_features
|
||||||
}
|
}
|
||||||
|
|
||||||
fn ack_features(&mut self, value: u64) {
|
fn ack_features(&mut self, value: u64) {
|
||||||
let mut v = value;
|
self.common.ack_features(value)
|
||||||
// Check if the guest is ACK'ing a feature that we didn't claim to have.
|
|
||||||
let unrequested_features = v & !self.avail_features;
|
|
||||||
if unrequested_features != 0 {
|
|
||||||
warn!("Received acknowledge request for unknown feature.");
|
|
||||||
|
|
||||||
// Don't count these features as acked.
|
|
||||||
v &= !unrequested_features;
|
|
||||||
}
|
|
||||||
self.acked_features |= v;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn read_config(&self, offset: u64, data: &mut [u8]) {
|
fn read_config(&self, offset: u64, data: &mut [u8]) {
|
||||||
|
Loading…
Reference in New Issue
Block a user