From e3dc6201462a0a373b8d8fc99f6fec2f03250bac Mon Sep 17 00:00:00 2001
From: Rob Bradford <robert.bradford@intel.com>
Date: Thu, 16 Jul 2020 09:49:35 +0100
Subject: [PATCH] virtio-devices: Remove write_config implementations

Remove the write_config() implementations that only generate a warning
as that is now done at the VirtioDevice level.

Signed-off-by: Rob Bradford <robert.bradford@intel.com>
---
 virtio-devices/src/balloon.rs | 4 ----
 virtio-devices/src/console.rs | 4 ----
 virtio-devices/src/iommu.rs   | 5 -----
 virtio-devices/src/mem.rs     | 4 ----
 virtio-devices/src/pmem.rs    | 4 ----
 virtio-devices/src/rng.rs     | 4 ----
 6 files changed, 25 deletions(-)

diff --git a/virtio-devices/src/balloon.rs b/virtio-devices/src/balloon.rs
index 0a7b7d1be..1264df6a7 100644
--- a/virtio-devices/src/balloon.rs
+++ b/virtio-devices/src/balloon.rs
@@ -486,10 +486,6 @@ impl VirtioDevice for Balloon {
         }
     }
 
-    fn write_config(&mut self, _offset: u64, _data: &[u8]) {
-        warn!("virtio-balloon device configuration is read-only");
-    }
-
     fn activate(
         &mut self,
         mem: GuestMemoryAtomic<GuestMemoryMmap>,
diff --git a/virtio-devices/src/console.rs b/virtio-devices/src/console.rs
index 1ec8d8048..c86f5f5a5 100644
--- a/virtio-devices/src/console.rs
+++ b/virtio-devices/src/console.rs
@@ -521,10 +521,6 @@ impl VirtioDevice for Console {
         }
     }
 
-    fn write_config(&mut self, _offset: u64, _data: &[u8]) {
-        warn!("No device specific configration requires write");
-    }
-
     fn activate(
         &mut self,
         mem: GuestMemoryAtomic<GuestMemoryMmap>,
diff --git a/virtio-devices/src/iommu.rs b/virtio-devices/src/iommu.rs
index ba0dd30e1..6df39fbd3 100644
--- a/virtio-devices/src/iommu.rs
+++ b/virtio-devices/src/iommu.rs
@@ -988,11 +988,6 @@ impl VirtioDevice for Iommu {
                 .unwrap();
         }
     }
-
-    fn write_config(&mut self, _offset: u64, _data: &[u8]) {
-        warn!("virtio-iommu device configuration is read-only");
-    }
-
     fn activate(
         &mut self,
         mem: GuestMemoryAtomic<GuestMemoryMmap>,
diff --git a/virtio-devices/src/mem.rs b/virtio-devices/src/mem.rs
index c05241d4a..5468b0db2 100644
--- a/virtio-devices/src/mem.rs
+++ b/virtio-devices/src/mem.rs
@@ -885,10 +885,6 @@ impl VirtioDevice for Mem {
         }
     }
 
-    fn write_config(&mut self, _offset: u64, _data: &[u8]) {
-        warn!("virtio-mem device configuration is read-only");
-    }
-
     fn activate(
         &mut self,
         mem: GuestMemoryAtomic<GuestMemoryMmap>,
diff --git a/virtio-devices/src/pmem.rs b/virtio-devices/src/pmem.rs
index e833c08e5..55a8cc7eb 100644
--- a/virtio-devices/src/pmem.rs
+++ b/virtio-devices/src/pmem.rs
@@ -478,10 +478,6 @@ impl VirtioDevice for Pmem {
         }
     }
 
-    fn write_config(&mut self, _offset: u64, _data: &[u8]) {
-        warn!("virtio-pmem device configuration is read-only");
-    }
-
     fn activate(
         &mut self,
         mem: GuestMemoryAtomic<GuestMemoryMmap>,
diff --git a/virtio-devices/src/rng.rs b/virtio-devices/src/rng.rs
index 6bb156165..a33db67f0 100644
--- a/virtio-devices/src/rng.rs
+++ b/virtio-devices/src/rng.rs
@@ -292,10 +292,6 @@ impl VirtioDevice for Rng {
         warn!("No currently device specific configration defined");
     }
 
-    fn write_config(&mut self, _offset: u64, _data: &[u8]) {
-        warn!("No currently device specific configration defined");
-    }
-
     fn activate(
         &mut self,
         mem: GuestMemoryAtomic<GuestMemoryMmap>,