From ea2685e9289c546b0df2a6bf0be03cce5cb8acb2 Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Tue, 18 Jan 2022 14:48:56 +0000 Subject: [PATCH] block_util: rewrite code and drop allow(clippy::ptr_arg) The code can be written in a better form and the clippy warning suppression can be dropped. No functional change. Signed-off-by: Wei Liu --- block_util/src/lib.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block_util/src/lib.rs b/block_util/src/lib.rs index 0611137e2..bb67a2a9b 100644 --- a/block_util/src/lib.rs +++ b/block_util/src/lib.rs @@ -252,13 +252,12 @@ impl Request { Ok(req) } - #[allow(clippy::ptr_arg)] pub fn execute( &self, disk: &mut T, disk_nsectors: u64, mem: &GuestMemoryMmap, - disk_id: &Vec, + disk_id: &[u8], ) -> result::Result { disk.seek(SeekFrom::Start(self.sector << SECTOR_SHIFT)) .map_err(ExecuteError::Seek)?; @@ -293,7 +292,7 @@ impl Request { if (*data_len as usize) < disk_id.len() { return Err(ExecuteError::BadRequest(Error::InvalidOffset)); } - mem.write_slice(disk_id.as_slice(), *data_addr) + mem.write_slice(disk_id, *data_addr) .map_err(ExecuteError::Write)?; } RequestType::Unsupported(t) => return Err(ExecuteError::Unsupported(t)),