mirror of
https://github.com/cloud-hypervisor/cloud-hypervisor.git
synced 2024-11-05 03:21:13 +00:00
e1bb5e71bf
Assigning KVM_IRQFD (when unmasking a guest IRQ) after KVM_SET_GSI_ROUTING can avoid kernel panic on the guest that is not patched with commit a80ced6ea514 (KVM: SVM: fix panic on out-of-bounds guest IRQ) on AMD systems. Meanwhile, it is required to deassign KVM_IRQFD (when masking a guest IRQ) before KVM_SET_GSI_ROUTING (see #3827). Fixes: #6353 Signed-off-by: Yi Wang <foxywang@tencent.com> Signed-off-by: Bo Chen <chen.bo@intel.com>
330 lines
9.2 KiB
Rust
330 lines
9.2 KiB
Rust
// Copyright © 2019 Intel Corporation
|
|
//
|
|
// SPDX-License-Identifier: Apache-2.0 AND BSD-3-Clause
|
|
//
|
|
|
|
use devices::interrupt_controller::InterruptController;
|
|
use hypervisor::IrqRoutingEntry;
|
|
use std::collections::HashMap;
|
|
use std::io;
|
|
use std::sync::atomic::{AtomicBool, Ordering};
|
|
use std::sync::{Arc, Mutex};
|
|
use vm_allocator::SystemAllocator;
|
|
use vm_device::interrupt::{
|
|
InterruptIndex, InterruptManager, InterruptSourceConfig, InterruptSourceGroup,
|
|
LegacyIrqGroupConfig, MsiIrqGroupConfig,
|
|
};
|
|
use vmm_sys_util::eventfd::EventFd;
|
|
|
|
/// Reuse std::io::Result to simplify interoperability among crates.
|
|
pub type Result<T> = std::io::Result<T>;
|
|
|
|
struct InterruptRoute {
|
|
gsi: u32,
|
|
irq_fd: EventFd,
|
|
registered: AtomicBool,
|
|
}
|
|
|
|
impl InterruptRoute {
|
|
pub fn new(allocator: &mut SystemAllocator) -> Result<Self> {
|
|
let irq_fd = EventFd::new(libc::EFD_NONBLOCK)?;
|
|
let gsi = allocator
|
|
.allocate_gsi()
|
|
.ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Failed allocating new GSI"))?;
|
|
|
|
Ok(InterruptRoute {
|
|
gsi,
|
|
irq_fd,
|
|
registered: AtomicBool::new(false),
|
|
})
|
|
}
|
|
|
|
pub fn enable(&self, vm: &Arc<dyn hypervisor::Vm>) -> Result<()> {
|
|
if !self.registered.load(Ordering::Acquire) {
|
|
vm.register_irqfd(&self.irq_fd, self.gsi).map_err(|e| {
|
|
io::Error::new(
|
|
io::ErrorKind::Other,
|
|
format!("Failed registering irq_fd: {e}"),
|
|
)
|
|
})?;
|
|
|
|
// Update internals to track the irq_fd as "registered".
|
|
self.registered.store(true, Ordering::Release);
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
pub fn disable(&self, vm: &Arc<dyn hypervisor::Vm>) -> Result<()> {
|
|
if self.registered.load(Ordering::Acquire) {
|
|
vm.unregister_irqfd(&self.irq_fd, self.gsi).map_err(|e| {
|
|
io::Error::new(
|
|
io::ErrorKind::Other,
|
|
format!("Failed unregistering irq_fd: {e}"),
|
|
)
|
|
})?;
|
|
|
|
// Update internals to track the irq_fd as "unregistered".
|
|
self.registered.store(false, Ordering::Release);
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
pub fn trigger(&self) -> Result<()> {
|
|
self.irq_fd.write(1)
|
|
}
|
|
|
|
pub fn notifier(&self) -> Option<EventFd> {
|
|
Some(
|
|
self.irq_fd
|
|
.try_clone()
|
|
.expect("Failed cloning interrupt's EventFd"),
|
|
)
|
|
}
|
|
}
|
|
|
|
pub struct RoutingEntry {
|
|
route: IrqRoutingEntry,
|
|
masked: bool,
|
|
}
|
|
|
|
pub struct MsiInterruptGroup {
|
|
vm: Arc<dyn hypervisor::Vm>,
|
|
gsi_msi_routes: Arc<Mutex<HashMap<u32, RoutingEntry>>>,
|
|
irq_routes: HashMap<InterruptIndex, InterruptRoute>,
|
|
}
|
|
|
|
impl MsiInterruptGroup {
|
|
fn set_gsi_routes(&self, routes: &HashMap<u32, RoutingEntry>) -> Result<()> {
|
|
let mut entry_vec: Vec<IrqRoutingEntry> = Vec::new();
|
|
for (_, entry) in routes.iter() {
|
|
if entry.masked {
|
|
continue;
|
|
}
|
|
|
|
entry_vec.push(entry.route);
|
|
}
|
|
|
|
self.vm.set_gsi_routing(&entry_vec).map_err(|e| {
|
|
io::Error::new(
|
|
io::ErrorKind::Other,
|
|
format!("Failed setting GSI routing: {e}"),
|
|
)
|
|
})
|
|
}
|
|
}
|
|
|
|
impl MsiInterruptGroup {
|
|
fn new(
|
|
vm: Arc<dyn hypervisor::Vm>,
|
|
gsi_msi_routes: Arc<Mutex<HashMap<u32, RoutingEntry>>>,
|
|
irq_routes: HashMap<InterruptIndex, InterruptRoute>,
|
|
) -> Self {
|
|
MsiInterruptGroup {
|
|
vm,
|
|
gsi_msi_routes,
|
|
irq_routes,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl InterruptSourceGroup for MsiInterruptGroup {
|
|
fn enable(&self) -> Result<()> {
|
|
for (_, route) in self.irq_routes.iter() {
|
|
route.enable(&self.vm)?;
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn disable(&self) -> Result<()> {
|
|
for (_, route) in self.irq_routes.iter() {
|
|
route.disable(&self.vm)?;
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn trigger(&self, index: InterruptIndex) -> Result<()> {
|
|
if let Some(route) = self.irq_routes.get(&index) {
|
|
return route.trigger();
|
|
}
|
|
|
|
Err(io::Error::new(
|
|
io::ErrorKind::Other,
|
|
format!("trigger: Invalid interrupt index {index}"),
|
|
))
|
|
}
|
|
|
|
fn notifier(&self, index: InterruptIndex) -> Option<EventFd> {
|
|
if let Some(route) = self.irq_routes.get(&index) {
|
|
return route.notifier();
|
|
}
|
|
|
|
None
|
|
}
|
|
|
|
fn update(
|
|
&self,
|
|
index: InterruptIndex,
|
|
config: InterruptSourceConfig,
|
|
masked: bool,
|
|
set_gsi: bool,
|
|
) -> Result<()> {
|
|
if let Some(route) = self.irq_routes.get(&index) {
|
|
let entry = RoutingEntry {
|
|
route: self.vm.make_routing_entry(route.gsi, &config),
|
|
masked,
|
|
};
|
|
|
|
// When mask a msi irq, entry.masked is set to be true,
|
|
// and the gsi will not be passed to KVM through KVM_SET_GSI_ROUTING.
|
|
// So it's required to call disable() (which deassign KVM_IRQFD) before
|
|
// set_gsi_routes() to avoid kernel panic (see #3827)
|
|
if masked {
|
|
route.disable(&self.vm)?;
|
|
}
|
|
|
|
let mut routes = self.gsi_msi_routes.lock().unwrap();
|
|
routes.insert(route.gsi, entry);
|
|
if set_gsi {
|
|
self.set_gsi_routes(&routes)?;
|
|
}
|
|
|
|
// Assign KVM_IRQFD after KVM_SET_GSI_ROUTING to avoid
|
|
// panic on kernel which not have commit a80ced6ea514
|
|
// (KVM: SVM: fix panic on out-of-bounds guest IRQ).
|
|
if !masked {
|
|
route.enable(&self.vm)?;
|
|
}
|
|
|
|
return Ok(());
|
|
}
|
|
|
|
Err(io::Error::new(
|
|
io::ErrorKind::Other,
|
|
format!("update: Invalid interrupt index {index}"),
|
|
))
|
|
}
|
|
|
|
fn set_gsi(&self) -> Result<()> {
|
|
let routes = self.gsi_msi_routes.lock().unwrap();
|
|
self.set_gsi_routes(&routes)
|
|
}
|
|
}
|
|
|
|
pub struct LegacyUserspaceInterruptGroup {
|
|
ioapic: Arc<Mutex<dyn InterruptController>>,
|
|
irq: u32,
|
|
}
|
|
|
|
impl LegacyUserspaceInterruptGroup {
|
|
fn new(ioapic: Arc<Mutex<dyn InterruptController>>, irq: u32) -> Self {
|
|
LegacyUserspaceInterruptGroup { ioapic, irq }
|
|
}
|
|
}
|
|
|
|
impl InterruptSourceGroup for LegacyUserspaceInterruptGroup {
|
|
fn trigger(&self, _index: InterruptIndex) -> Result<()> {
|
|
self.ioapic
|
|
.lock()
|
|
.unwrap()
|
|
.service_irq(self.irq as usize)
|
|
.map_err(|e| {
|
|
io::Error::new(
|
|
io::ErrorKind::Other,
|
|
format!("failed to inject IRQ #{}: {:?}", self.irq, e),
|
|
)
|
|
})
|
|
}
|
|
|
|
fn update(
|
|
&self,
|
|
_index: InterruptIndex,
|
|
_config: InterruptSourceConfig,
|
|
_masked: bool,
|
|
_set_gsi: bool,
|
|
) -> Result<()> {
|
|
Ok(())
|
|
}
|
|
|
|
fn set_gsi(&self) -> Result<()> {
|
|
Ok(())
|
|
}
|
|
|
|
fn notifier(&self, _index: InterruptIndex) -> Option<EventFd> {
|
|
self.ioapic.lock().unwrap().notifier(self.irq as usize)
|
|
}
|
|
}
|
|
|
|
pub struct LegacyUserspaceInterruptManager {
|
|
ioapic: Arc<Mutex<dyn InterruptController>>,
|
|
}
|
|
|
|
pub struct MsiInterruptManager {
|
|
allocator: Arc<Mutex<SystemAllocator>>,
|
|
vm: Arc<dyn hypervisor::Vm>,
|
|
gsi_msi_routes: Arc<Mutex<HashMap<u32, RoutingEntry>>>,
|
|
}
|
|
|
|
impl LegacyUserspaceInterruptManager {
|
|
pub fn new(ioapic: Arc<Mutex<dyn InterruptController>>) -> Self {
|
|
LegacyUserspaceInterruptManager { ioapic }
|
|
}
|
|
}
|
|
|
|
impl MsiInterruptManager {
|
|
pub fn new(allocator: Arc<Mutex<SystemAllocator>>, vm: Arc<dyn hypervisor::Vm>) -> Self {
|
|
// Create a shared list of GSI that can be shared through all PCI
|
|
// devices. This way, we can maintain the full list of used GSI,
|
|
// preventing one device from overriding interrupts setting from
|
|
// another one.
|
|
let gsi_msi_routes = Arc::new(Mutex::new(HashMap::new()));
|
|
|
|
MsiInterruptManager {
|
|
allocator,
|
|
vm,
|
|
gsi_msi_routes,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl InterruptManager for LegacyUserspaceInterruptManager {
|
|
type GroupConfig = LegacyIrqGroupConfig;
|
|
|
|
fn create_group(&self, config: Self::GroupConfig) -> Result<Arc<dyn InterruptSourceGroup>> {
|
|
Ok(Arc::new(LegacyUserspaceInterruptGroup::new(
|
|
self.ioapic.clone(),
|
|
config.irq,
|
|
)))
|
|
}
|
|
|
|
fn destroy_group(&self, _group: Arc<dyn InterruptSourceGroup>) -> Result<()> {
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
impl InterruptManager for MsiInterruptManager {
|
|
type GroupConfig = MsiIrqGroupConfig;
|
|
|
|
fn create_group(&self, config: Self::GroupConfig) -> Result<Arc<dyn InterruptSourceGroup>> {
|
|
let mut allocator = self.allocator.lock().unwrap();
|
|
let mut irq_routes: HashMap<InterruptIndex, InterruptRoute> =
|
|
HashMap::with_capacity(config.count as usize);
|
|
for i in config.base..config.base + config.count {
|
|
irq_routes.insert(i, InterruptRoute::new(&mut allocator)?);
|
|
}
|
|
|
|
Ok(Arc::new(MsiInterruptGroup::new(
|
|
self.vm.clone(),
|
|
self.gsi_msi_routes.clone(),
|
|
irq_routes,
|
|
)))
|
|
}
|
|
|
|
fn destroy_group(&self, _group: Arc<dyn InterruptSourceGroup>) -> Result<()> {
|
|
Ok(())
|
|
}
|
|
}
|