From 49306cb6eada8777eafc2fa7f93f16008c2e93a5 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Fri, 6 Oct 2023 12:56:53 +0200 Subject: [PATCH] container-toolbox: Include weak dependencies The Container/Dockerfile equivalent of the fedora-toolbox OCI images didn't exclude weak dependencies [1] so the Kickstart shouldn't either. The fedora-toolbox OCI image is meant for interactive command line environments, not for deploying server applications. Therefore, they need a fully featured CLI user experience at par with what's offered on Fedora Silverblue and Workstation. Among the Kickstart files defined here, other than fedora-container-toolbox.ks, only these ones exclude weak dependencies: * fedora-container-base-minimal.ks * fedora-container-base.ks * fedora-container-common.ks * fedora-eln-container-base.ks * fedora-modular-disk-minimal.ks None of the other Kickstarts, and definitely not those for Fedora Workstation, exclude weak dependencies. As a concrete example, the default-editor meta RPM relies on Recommends for its functionality [2]. [1] https://src.fedoraproject.org/container/fedora-toolbox https://github.com/containers/toolbox/tree/main/images/fedora [2] fedora nano commit e53ee57baa33a1d8 https://src.fedoraproject.org/rpms/nano/c/e53ee57baa33a1d8 https://src.fedoraproject.org/rpms/nano/pull-request/7 https://bugzilla.redhat.com/show_bug.cgi?id=1955884 https://pagure.io/fedora-kickstarts/pull-request/995 --- fedora-container-toolbox.ks | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fedora-container-toolbox.ks b/fedora-container-toolbox.ks index 9b0d624..6b5a4af 100644 --- a/fedora-container-toolbox.ks +++ b/fedora-container-toolbox.ks @@ -6,7 +6,7 @@ %include fedora-container-common.ks # Install packages -%packages --inst-langs=en --nocore --exclude-weakdeps +%packages --inst-langs=en --nocore acl bash bash-completion