From 69555b7b91a7b23d31bc90b0ab099279b1f1e228 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Mon, 9 Oct 2023 17:11:40 +0200 Subject: [PATCH] container-toolbox: Install all languages The Container/Dockerfile equivalent of the fedora-toolbox OCI images installed all languages by removing %_install_langs (set to en_US by the fedora base image) from /etc/rpm/macros.image-language-conf [1]. The Kickstart does the same in the %pre section. Therefore, it's self-contradictory to have '%packages --inst-langs=en'. The fedora-toolbox OCI image is meant for interactive command line environments, not for deploying server applications. Therefore, they need a fully featured CLI user experience at par with what's offered on Fedora Silverblue and Workstation. Among the Kickstart files defined here, other than fedora-container-toolbox.ks, only these ones don't install all languages: * fedora-cloud-base.ks * fedora-container-base-minimal.ks * fedora-container-base.ks * fedora-container-common.ks * fedora-eln-container-base.ks * fedora-server-vm-full.ks All the other Kickstarts, and definitely those for Fedora Workstation, install all languages. [1] https://src.fedoraproject.org/container/fedora-toolbox https://github.com/containers/toolbox/tree/main/images/fedora https://bugzilla.redhat.com/show_bug.cgi?id=2244503 https://pagure.io/fedora-kickstarts/pull-request/997 --- fedora-container-toolbox.ks | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fedora-container-toolbox.ks b/fedora-container-toolbox.ks index 6b5a4af..f343fdb 100644 --- a/fedora-container-toolbox.ks +++ b/fedora-container-toolbox.ks @@ -6,7 +6,7 @@ %include fedora-container-common.ks # Install packages -%packages --inst-langs=en --nocore +%packages --nocore acl bash bash-completion