External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-03 20:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
112f3a8d0f
libvirt/tests/qemuargv2xmltest.c

323 lines
8.5 KiB
C
Raw Normal View History

Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
#include <config.h>
#include <unistd.h>
#include <sys/types.h>
#include <fcntl.h>
cleanup: Only include testutils.h once No reason to include it in both "if" and "else" branches.
2013-04-16 13:41:44 +00:00
#include "testutils.h"
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
#ifdef WITH_QEMU
build: consistently indent preprocessor directives * global: patch created by running: for f in $(git ls-files '*.[ch]') ; do cppi $f > $f.t && mv $f.t $f done
2010-03-09 18:22:22 +00:00
# include "internal.h"
qemu: Split the command parsing routines into own module Extract out the qemuParseCommandLine{String|Pid} into their own separate module - taking with it all the various static functions. Causes a ripple effect with a few other modules to include the new qemu_parse_command.h. Narrowed down the list of #include's in the split out module to those that are necessary for build.
2016-02-10 12:33:47 +00:00
# include "qemu/qemu_parse_command.h"
build: consistently indent preprocessor directives * global: patch created by running: for f in $(git ls-files '*.[ch]') ; do cppi $f > $f.t && mv $f.t $f done
2010-03-09 18:22:22 +00:00
# include "testutilsqemu.h"
virutil: Move string related functions to virstring.c The source code base needs to be adapted as well. Some files include virutil.h just for the string related functions (here, the include is substituted to match the new file), some include virutil.h without any need (here, the include is removed), and some require both.
2013-04-03 10:36:23 +00:00
# include "virstring.h"
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
Introduce OOM reporting to virAsprintf Actually, I'm turning this function into a macro as filename, function name and line number needs to be passed. The new function virAsprintfInternal is introduced with the extended set of arguments.
2013-06-07 15:10:28 +00:00
# define VIR_FROM_THIS VIR_FROM_NONE
Replace 'struct qemud_driver *' with virQEMUDriverPtr Remove the obsolete 'qemud' naming prefix and underscore based type name. Introduce virQEMUDriverPtr as the replacement, in common with LXC driver naming style
2012-11-28 16:43:10 +00:00
static virQEMUDriver driver;
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
tests: qemuargv2xml: Remove UUID randomness Overwrite any randomly generated UUID to use a hardcoded value, so we don't need to blank it when comparing XML.
2016-02-16 16:13:21 +00:00
static int testSanitizeDef(virDomainDefPtr vmdef)
{
tests: qemuargv2xml: hardcode disk auth usage If a qemuargv has iscsi or ceph secrets on the command line, we will convert that to XML like: <auth username='myname'> <secret type='iscsi'/> </auth> This is not valid XML, as either a UUID or usage must be specified in the secret block. It's not clear though how the argv2xml code can do anything correct here, since XML like this requires a libvirt secret object to have already been defined. The current test suite handles this by blanking out any <secret> block in the XML. This avoids domainschematest failures. Instead of blanking, let's hardcode a usage= name. This lets us test the other bits of generated <secret> XML, and is a step towards wiring up VIR_TEST_REGENERATE_OUTPUT
2016-02-16 16:49:07 +00:00
size_t i = 0;
tests: qemuargv2xml: Remove UUID randomness Overwrite any randomly generated UUID to use a hardcoded value, so we don't need to blank it when comparing XML.
2016-02-16 16:13:21 +00:00
int ret = -1;
/* Remove UUID randomness */
if (virUUIDParse("c7a5fdbd-edaf-9455-926a-d65c16db1809", vmdef->uuid) < 0)
goto fail;
tests: qemuargv2xml: hardcode disk auth usage If a qemuargv has iscsi or ceph secrets on the command line, we will convert that to XML like: <auth username='myname'> <secret type='iscsi'/> </auth> This is not valid XML, as either a UUID or usage must be specified in the secret block. It's not clear though how the argv2xml code can do anything correct here, since XML like this requires a libvirt secret object to have already been defined. The current test suite handles this by blanking out any <secret> block in the XML. This avoids domainschematest failures. Instead of blanking, let's hardcode a usage= name. This lets us test the other bits of generated <secret> XML, and is a step towards wiring up VIR_TEST_REGENERATE_OUTPUT
2016-02-16 16:49:07 +00:00
/* qemuargv2xml doesn't know what to set for a secret usage/uuid,
* so hardcode usage='qemuargv2xml_usage' to appead the schema checker */
for (i = 0; i < vmdef->ndisks; i++) {
virDomainDiskDefPtr disk = vmdef->disks[i];
if (disk->src->auth) {
secret: Move virStorageSecretType and rename Move the enum into a new src/util/virsecret.h, rename it to be virSecretLookupType. Add a src/util/virsecret.h in order to perform a couple of simple operations on the secret XML and virSecretLookupTypeDef for clearing and copying. This includes quite a bit of collateral damage, but the goal is to remove the "virStorage*" and replace with the virSecretLookupType so that it's easier to to add new lookups that aren't necessarily storage pool related. Signed-off-by: John Ferlan <jferlan@redhat.com>
2016-05-28 12:43:23 +00:00
disk->src->auth->seclookupdef.type = VIR_SECRET_LOOKUP_TYPE_USAGE;
if (VIR_STRDUP(disk->src->auth->seclookupdef.u.usage,
tests: qemuargv2xml: hardcode disk auth usage If a qemuargv has iscsi or ceph secrets on the command line, we will convert that to XML like: <auth username='myname'> <secret type='iscsi'/> </auth> This is not valid XML, as either a UUID or usage must be specified in the secret block. It's not clear though how the argv2xml code can do anything correct here, since XML like this requires a libvirt secret object to have already been defined. The current test suite handles this by blanking out any <secret> block in the XML. This avoids domainschematest failures. Instead of blanking, let's hardcode a usage= name. This lets us test the other bits of generated <secret> XML, and is a step towards wiring up VIR_TEST_REGENERATE_OUTPUT
2016-02-16 16:49:07 +00:00
"qemuargv2xml_usage") < 0)
goto fail;
}
}
tests: qemuargv2xml: Remove UUID randomness Overwrite any randomly generated UUID to use a hardcoded value, so we don't need to blank it when comparing XML.
2016-02-16 16:13:21 +00:00
ret = 0;
fail:
return ret;
}
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
typedef enum {
FLAG_EXPECT_WARNING = 1 << 0,
} virQemuXML2ArgvTestFlags;
tests: qemuargv2xml: Drop memory XML blanking The memory XML blanking is only there to avoid the unit= churn that was added by default a long time ago. Drop the blanking, switch over to using the standard comparison helpers, and regenerate the output with VIR_TEST_REGENERATE_OUTPUT.
2016-02-16 16:59:08 +00:00
static int testCompareXMLToArgvFiles(const char *xmlfile,
tests: silence qemuargv2xmltest noise Before this patch, the testsuite was noisy: TEST: qemuargv2xmltest ........................................ 40 ................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace 20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace . 57 OK PASS: qemuargv2xmltest It's not a real failure (which is why the test was completing successfully), so much as an intentional warning to the user that use of the qemu namespace has the potential for undefined effects that leaked through the default logging behavior. After this patch series, all tests can access any logged data, and this particular test can explicitly check for the presence or absence of the warning, such that the test output becomes: TEST: qemuargv2xmltest ........................................ 40 ................. 57 OK PASS: qemuargv2xmltest * tests/testutils.h (virtTestLogContentAndReset): New prototype. * tests/testutils.c (struct virtTestLogData): New struct. (virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset): New functions. (virtTestMain): Always capture log data emitted during tests. * tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain): Use flag to mark which tests expect noisy stderr. (testCompareXMLToArgvFiles): Add parameter to test whether stderr was appropriately silent.
2010-09-10 16:25:49 +00:00
const char *cmdfile,
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
virQemuXML2ArgvTestFlags flags)
Use K&R style for curly braces in tests/ Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-03-18 08:13:43 +00:00
{
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
char *actualxml = NULL;
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
char *cmd = NULL;
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
char *log = NULL;
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
int ret = -1;
virDomainDefPtr vmdef = NULL;
Rename virtTestLoadFile to virTestLoadFile. This function doesn't follow our convention of naming functions.
2016-05-26 15:01:52 +00:00
if (virTestLoadFile(cmdfile, &cmd) < 0)
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
goto fail;
qemu: fix default machine for argv -> xml convertor Historically the argv -> xml convertor wanted the same default machine as we'd set when parsing xml. The latter has now changed, however, to use a default defined by libvirt. The former needs fixing to again honour the default QEMU machine. This exposed a bug in handling for the aarch64 target, as QEMU does not define any default machine. Thus we should not having been accepting argv without a -machine provided. Reviewed-by: John Ferlan <jferlan@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2018-08-13 11:42:01 +00:00
if (!(vmdef = qemuParseCommandLineString(driver.qemuCapsCache,
driver.caps, driver.xmlopt,
virCaps: conf: start splitting out irrelevat data The virCaps structure gathered a ton of irrelevant data over time that. The original reason is that it was propagated to the XML parser functions. This patch aims to create a new data structure virDomainXMLConf that will contain immutable data that are used by the XML parser. This will allow two things we need: 1) Get rid of the stuff from virCaps 2) Allow us to add callbacks to check and add driver specific stuff after domain XML is parsed. This first attempt removes pointers to private data allocation functions to this new structure and update all callers and function that require them.
2013-03-05 15:17:24 +00:00
cmd, NULL, NULL, NULL)))
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
goto fail;
tests: Rename virtTest00MActive to virTest00MActive. This function doesn't follow our convention of naming functions.
2016-05-26 15:01:56 +00:00
if (!virTestOOMActive()) {
tests: Rename virtTestLogContentAndReset to virTestLogContentAndReset. This function doesn't follow our convention of naming functions.
2016-05-26 15:01:58 +00:00
if ((log = virTestLogContentAndReset()) == NULL)
Introduce new OOM testing support The previous OOM testing support would re-run the entire "main" method each iteration, failing a different malloc each time. When a test suite has 'n' allocations, the number of repeats requires is (n * (n + 1) ) / 2. This gets very large, very quickly. This new OOM testing support instead integrates at the virtTestRun level, so each individual test case gets repeated, instead of the entire test suite. This means the values of 'n' are orders of magnitude smaller. The simple usage is $ VIR_TEST_OOM=1 ./qemuxml2argvtest ... 29) QEMU XML-2-ARGV clock-utc ... OK Test OOM for nalloc=36 .................................... OK 30) QEMU XML-2-ARGV clock-localtime ... OK Test OOM for nalloc=36 .................................... OK 31) QEMU XML-2-ARGV clock-france ... OK Test OOM for nalloc=38 ...................................... OK ... the second lines reports how many mallocs have to be failed, and thus how many repeats of the test will be run. If it crashes, then running under valgrind will often show the problem $ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest When debugging problems it is also helpful to select an individual test case $ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest When things get really tricky, it is possible to request that just specific allocs are failed. eg to fail allocs 5 -> 12, use $ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest In the worse case, you might want to know the stack trace of the alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it is set to 1 then it will only print if it thinks a mistake happened. This is often not reliable, so setting it to 2 will make it print the stack trace for every alloc that is failed. $ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest 30) QEMU XML-2-ARGV clock-localtime ... OK Test OOM for nalloc=36 !virAllocN /home/berrange/src/virt/libvirt/src/util/viralloc.c:180 virHashCreateFull /home/berrange/src/virt/libvirt/src/util/virhash.c:144 virDomainDefParseXML /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745 virDomainDefParseNode /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646 virDomainDefParse /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590 testCompareXMLToArgvFiles /home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106 virtTestRun /home/berrange/src/virt/libvirt/tests/testutils.c:250 mymain /home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2) virtTestMain /home/berrange/src/virt/libvirt/tests/testutils.c:750 ?? ??:0 _start ??:? FAILED Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 13:21:52 +00:00
goto fail;
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
if (flags & FLAG_EXPECT_WARNING) {
if (*log) {
tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE To remove a bunch of TestGetDebug()/TestGetVerbose() checks
2015-04-23 17:38:00 +00:00
VIR_TEST_DEBUG("Got expected warning from "
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
"qemuParseCommandLineString:\n%s",
log);
} else {
tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE To remove a bunch of TestGetDebug()/TestGetVerbose() checks
2015-04-23 17:38:00 +00:00
VIR_TEST_DEBUG("qemuParseCommandLineString "
"should have logged a warning\n");
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
goto fail;
}
} else { /* didn't expect a warning */
if (*log) {
tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE To remove a bunch of TestGetDebug()/TestGetVerbose() checks
2015-04-23 17:38:00 +00:00
VIR_TEST_DEBUG("Got unexpected warning from "
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
"qemuParseCommandLineString:\n%s",
log);
goto fail;
}
Introduce new OOM testing support The previous OOM testing support would re-run the entire "main" method each iteration, failing a different malloc each time. When a test suite has 'n' allocations, the number of repeats requires is (n * (n + 1) ) / 2. This gets very large, very quickly. This new OOM testing support instead integrates at the virtTestRun level, so each individual test case gets repeated, instead of the entire test suite. This means the values of 'n' are orders of magnitude smaller. The simple usage is $ VIR_TEST_OOM=1 ./qemuxml2argvtest ... 29) QEMU XML-2-ARGV clock-utc ... OK Test OOM for nalloc=36 .................................... OK 30) QEMU XML-2-ARGV clock-localtime ... OK Test OOM for nalloc=36 .................................... OK 31) QEMU XML-2-ARGV clock-france ... OK Test OOM for nalloc=38 ...................................... OK ... the second lines reports how many mallocs have to be failed, and thus how many repeats of the test will be run. If it crashes, then running under valgrind will often show the problem $ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest When debugging problems it is also helpful to select an individual test case $ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest When things get really tricky, it is possible to request that just specific allocs are failed. eg to fail allocs 5 -> 12, use $ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest In the worse case, you might want to know the stack trace of the alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it is set to 1 then it will only print if it thinks a mistake happened. This is often not reliable, so setting it to 2 will make it print the stack trace for every alloc that is failed. $ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest 30) QEMU XML-2-ARGV clock-localtime ... OK Test OOM for nalloc=36 !virAllocN /home/berrange/src/virt/libvirt/src/util/viralloc.c:180 virHashCreateFull /home/berrange/src/virt/libvirt/src/util/virhash.c:144 virDomainDefParseXML /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745 virDomainDefParseNode /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646 virDomainDefParse /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590 testCompareXMLToArgvFiles /home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106 virtTestRun /home/berrange/src/virt/libvirt/tests/testutils.c:250 mymain /home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2) virtTestMain /home/berrange/src/virt/libvirt/tests/testutils.c:750 ?? ??:0 _start ??:? FAILED Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 13:21:52 +00:00
}
tests: silence qemuargv2xmltest noise Before this patch, the testsuite was noisy: TEST: qemuargv2xmltest ........................................ 40 ................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace 20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace . 57 OK PASS: qemuargv2xmltest It's not a real failure (which is why the test was completing successfully), so much as an intentional warning to the user that use of the qemu namespace has the potential for undefined effects that leaked through the default logging behavior. After this patch series, all tests can access any logged data, and this particular test can explicitly check for the presence or absence of the warning, such that the test output becomes: TEST: qemuargv2xmltest ........................................ 40 ................. 57 OK PASS: qemuargv2xmltest * tests/testutils.h (virtTestLogContentAndReset): New prototype. * tests/testutils.c (struct virtTestLogData): New struct. (virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset): New functions. (virtTestMain): Always capture log data emitted during tests. * tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain): Use flag to mark which tests expect noisy stderr. (testCompareXMLToArgvFiles): Add parameter to test whether stderr was appropriately silent.
2010-09-10 16:25:49 +00:00
}
tests: qemuargv2xml: Remove UUID randomness Overwrite any randomly generated UUID to use a hardcoded value, so we don't need to blank it when comparing XML.
2016-02-16 16:13:21 +00:00
if (testSanitizeDef(vmdef) < 0)
goto fail;
virDomainXMLOption: Introduce virDomainABIStabilityDomain While checking for ABI stability, drivers might pose additional checks that are not valid for general case. For instance, qemu driver might check some memory backing attributes because of how qemu works. But those attributes may work well in other drivers. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2017-05-19 13:07:15 +00:00
if (!virDomainDefCheckABIStability(vmdef, vmdef, driver.xmlopt)) {
tests: qemuargv2xml: Drop memory XML blanking The memory XML blanking is only there to avoid the unit= churn that was added by default a long time ago. Drop the blanking, switch over to using the standard comparison helpers, and regenerate the output with VIR_TEST_REGENERATE_OUTPUT.
2016-02-16 16:59:08 +00:00
VIR_TEST_DEBUG("ABI stability check failed on %s", xmlfile);
Exercise the ABI stability check code in test suite Any test suite which involves a virDomainDefPtr should call virDomainDefCheckABIStability with itself just as a basic sanity check that the identity-comparison always succeeds. This would have caught the recent NULL pointer access crash. Make sure we cope with def->name being NULL since the VMWare config parser produces NULL names. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2014-01-10 17:18:03 +00:00
goto fail;
}
conf: add caps to virDomainDefFormat* And use the newly added caps->host.netprefix (if it exists) for interface names that match the autogenerated target names. Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
2016-02-03 21:40:35 +00:00
if (!(actualxml = virDomainDefFormat(vmdef, driver.caps, 0)))
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
goto fail;
tests: Rename virtTestCompareToFile to virTestCompareToFile. This function doesn't follow our convention of naming functions.
2016-05-26 15:01:53 +00:00
if (virTestCompareToFile(actualxml, xmlfile) < 0)
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
goto fail;
ret = 0;
fail:
build: expand rule to cover testsuite The bulk of this patch was done with: sed -i 's/\(\bfree *(/VIR_FREE(/g' tests/*.c followed by fixing the few compile errors that resulted. * cfg.mk (exclude_file_name_regexp--sc_prohibit_raw_allocation): Remove tests from exemption. * tests/testutils.h: Add common header. * tests/commandhelper.c: Fix offenders. * tests/cputest.c: Likewise. * tests/domainsnapshotxml2xmltest.c: Likewise. * tests/interfacexml2xmltest.c: Likewise. * tests/networkxml2argvtest.c: Likewise. * tests/networkxml2xmltest.c: Likewise. * tests/nodedevxml2xmltest.c: Likewise. * tests/nodeinfotest.c: Likewise. * tests/nwfilterxml2xmltest.c: Likewise. * tests/qemuargv2xmltest.c: Likewise. * tests/qemuxml2argvtest.c: Likewise. * tests/qemuxml2xmltest.c: Likewise. * tests/qemuxmlnstest.c: Likewise. * tests/qparamtest.c: Likewise. * tests/sexpr2xmltest.c: Likewise. * tests/storagepoolxml2xmltest.c: Likewise. * tests/storagevolxml2xmltest.c: Likewise. * tests/testutils.c: Likewise. * tests/virshtest.c: Likewise. * tests/xencapstest.c: Likewise. * tests/xmconfigtest.c: Likewise. * tests/xml2sexprtest.c: Likewise.
2012-02-02 23:16:43 +00:00
VIR_FREE(actualxml);
VIR_FREE(cmd);
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
VIR_FREE(log);
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
virDomainDefFree(vmdef);
return ret;
}
struct testInfo {
const char *name;
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
unsigned int flags;
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
};
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
static int
testCompareXMLToArgvHelper(const void *data)
{
int result = -1;
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
const struct testInfo *info = data;
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
char *xml = NULL;
char *args = NULL;
test: Drop useless prefix for qemuargv2xml test data There's no reason for the files to have qemuargv2xml- prefix since they all live under qemuargv2xmldata directory. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2017-12-05 06:50:12 +00:00
if (virAsprintf(&xml, "%s/qemuargv2xmldata/%s.xml",
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
abs_srcdir, info->name) < 0 ||
test: Drop useless prefix for qemuargv2xml test data There's no reason for the files to have qemuargv2xml- prefix since they all live under qemuargv2xmldata directory. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2017-12-05 06:50:12 +00:00
virAsprintf(&args, "%s/qemuargv2xmldata/%s.args",
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
abs_srcdir, info->name) < 0)
goto cleanup;
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
result = testCompareXMLToArgvFiles(xml, args, info->flags);
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
Indent top-level labels by one space in tests/
2014-03-25 06:53:44 +00:00
cleanup:
build: expand rule to cover testsuite The bulk of this patch was done with: sed -i 's/\(\bfree *(/VIR_FREE(/g' tests/*.c followed by fixing the few compile errors that resulted. * cfg.mk (exclude_file_name_regexp--sc_prohibit_raw_allocation): Remove tests from exemption. * tests/testutils.h: Add common header. * tests/commandhelper.c: Fix offenders. * tests/cputest.c: Likewise. * tests/domainsnapshotxml2xmltest.c: Likewise. * tests/interfacexml2xmltest.c: Likewise. * tests/networkxml2argvtest.c: Likewise. * tests/networkxml2xmltest.c: Likewise. * tests/nodedevxml2xmltest.c: Likewise. * tests/nodeinfotest.c: Likewise. * tests/nwfilterxml2xmltest.c: Likewise. * tests/qemuargv2xmltest.c: Likewise. * tests/qemuxml2argvtest.c: Likewise. * tests/qemuxml2xmltest.c: Likewise. * tests/qemuxmlnstest.c: Likewise. * tests/qparamtest.c: Likewise. * tests/sexpr2xmltest.c: Likewise. * tests/storagepoolxml2xmltest.c: Likewise. * tests/storagevolxml2xmltest.c: Likewise. * tests/testutils.c: Likewise. * tests/virshtest.c: Likewise. * tests/xencapstest.c: Likewise. * tests/xmconfigtest.c: Likewise. * tests/xml2sexprtest.c: Likewise.
2012-02-02 23:16:43 +00:00
VIR_FREE(xml);
VIR_FREE(args);
tests: Lower stack usage below 4096 bytes Make virtTestLoadFile allocate the buffer to read the file into. Fix logic error in virtTestLoadFile, stop reading on the first empty line. Use virFileReadLimFD in virtTestCaptureProgramOutput to avoid manual buffer handling.
2011-04-24 22:25:10 +00:00
return result;
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
}
static int
tests: simplify common setup A few of the tests were missing basic sanity checks, while most of them were doing copy-and-paste initialization (in fact, some of them pasted the argc > 1 check more than once!). It's much nicer to do things in one common place, and minimizes the size of the next patch that fixes getcwd usage. * tests/testutils.h (EXIT_AM_HARDFAIL): New define. (progname, abs_srcdir): Define for all tests. (VIRT_TEST_MAIN): Change callback signature. * tests/testutils.c (virtTestMain): Do more common init. * tests/commandtest.c (mymain): Simplify. * tests/cputest.c (mymain): Likewise. * tests/esxutilstest.c (mymain): Likewise. * tests/eventtest.c (mymain): Likewise. * tests/hashtest.c (mymain): Likewise. * tests/networkxml2xmltest.c (mymain): Likewise. * tests/nodedevxml2xmltest.c (myname): Likewise. * tests/nodeinfotest.c (mymain): Likewise. * tests/nwfilterxml2xmltest.c (mymain): Likewise. * tests/qemuargv2xmltest.c (mymain): Likewise. * tests/qemuhelptest.c (mymain): Likewise. * tests/qemuxml2argvtest.c (mymain): Likewise. * tests/qemuxml2xmltest.c (mymain): Likewise. * tests/qparamtest.c (mymain): Likewise. * tests/sexpr2xmltest.c (mymain): Likewise. * tests/sockettest.c (mymain): Likewise. * tests/statstest.c (mymain): Likewise. * tests/storagepoolxml2xmltest.c (mymain): Likewise. * tests/storagevolxml2xmltest.c (mymain): Likewise. * tests/virbuftest.c (mymain): Likewise. * tests/virshtest.c (mymain): Likewise. * tests/vmx2xmltest.c (mymain): Likewise. * tests/xencapstest.c (mymain): Likewise. * tests/xmconfigtest.c (mymain): Likewise. * tests/xml2sexprtest.c (mymain): Likewise. * tests/xml2vmxtest.c (mymain): Likewise.
2011-04-29 16:21:20 +00:00
mymain(void)
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
{
int ret = 0;
tests: split out common qemu driver initialization Two utility functions are introduced for proper initialization and cleanup of the driver. Signed-off-by: Pavel Fedin <p.fedin@samsung.com> Signed-off-by: Ján Tomko <jtomko@redhat.com>
2015-09-15 06:16:02 +00:00
if (qemuTestDriverInit(&driver) < 0)
tests: Don't crash when creating the config object fails As observed when building in a chroot and QEMU_USER doesn't exist
2014-04-07 06:53:26 +00:00
return EXIT_FAILURE;
qemu: fix default machine for argv -> xml convertor Historically the argv -> xml convertor wanted the same default machine as we'd set when parsing xml. The latter has now changed, however, to use a default defined by libvirt. The former needs fixing to again honour the default QEMU machine. This exposed a bug in handling for the aarch64 target, as QEMU does not define any default machine. Thus we should not having been accepting argv without a -machine provided. Reviewed-by: John Ferlan <jferlan@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2018-08-13 11:42:01 +00:00
# define LOAD_CAPS(arch) \
do { \
virQEMUCapsPtr qemuCaps; \
qemuCaps = qemuTestParseCapabilitiesArch(VIR_ARCH_X86_64, \
qemuargv2xmltest: Fix caps loading in VPATH build Broken by v4.7.0-rc1-9-g6700062fb0. Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
2018-08-28 12:24:10 +00:00
abs_srcdir "/qemucapabilitiesdata/caps_2.12.0." arch ".xml"); \
qemu: fix default machine for argv -> xml convertor Historically the argv -> xml convertor wanted the same default machine as we'd set when parsing xml. The latter has now changed, however, to use a default defined by libvirt. The former needs fixing to again honour the default QEMU machine. This exposed a bug in handling for the aarch64 target, as QEMU does not define any default machine. Thus we should not having been accepting argv without a -machine provided. Reviewed-by: John Ferlan <jferlan@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2018-08-13 11:42:01 +00:00
if (virFileCacheInsertData(driver.qemuCapsCache, \
"/usr/bin/qemu-system-" arch, \
qemuCaps) < 0) \
return EXIT_FAILURE; \
} while (0)
LOAD_CAPS("x86_64");
LOAD_CAPS("aarch64");
LOAD_CAPS("ppc64");
virCaps: conf: start splitting out irrelevat data The virCaps structure gathered a ton of irrelevant data over time that. The original reason is that it was propagated to the XML parser functions. This patch aims to create a new data structure virDomainXMLConf that will contain immutable data that are used by the XML parser. This will allow two things we need: 1) Get rid of the stuff from virCaps 2) Allow us to add callbacks to check and add driver specific stuff after domain XML is parsed. This first attempt removes pointers to private data allocation functions to this new structure and update all callers and function that require them.
2013-03-05 15:17:24 +00:00
Remove backslash alignment attempts Right-aligning backslashes when defining macros or using complex commands in Makefiles looks cute, but as soon as any changes is required to the code you end up with either distractingly broken alignment or unnecessarily big diffs where most of the changes are just pushing all backslashes a few characters to one side. Generated using $ git grep -El '[[:blank:]][[:blank:]]\\$' | \ grep -E '*\.([chx]|am|mk)$$' | \ while read f; do \ sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \ done Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2017-11-03 12:09:47 +00:00
# define DO_TEST_FULL(name, flags) \
do { \
const struct testInfo info = { name, (flags) }; \
if (virTestRun("QEMU ARGV-2-XML " name, \
testCompareXMLToArgvHelper, &info) < 0) \
ret = -1; \
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
} while (0)
Remove backslash alignment attempts Right-aligning backslashes when defining macros or using complex commands in Makefiles looks cute, but as soon as any changes is required to the code you end up with either distractingly broken alignment or unnecessarily big diffs where most of the changes are just pushing all backslashes a few characters to one side. Generated using $ git grep -El '[[:blank:]][[:blank:]]\\$' | \ grep -E '*\.([chx]|am|mk)$$' | \ while read f; do \ sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \ done Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2017-11-03 12:09:47 +00:00
# define DO_TEST(name) \
tests: drop dead code from argv2xml and xml2xml Noticed while tweaking the RelaxNG grammar for <disk> elements. * tests/qemuxml2xmloutdata/qemuxml2xmlout-numad-static-vcpu-no-numatune.xml: * tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml: Drop unused files. * tests/qemuargv2xmltest.c (testInfo, DO_TEST_FULL): Drop unused field. Signed-off-by: Eric Blake <eblake@redhat.com>
2014-04-11 18:51:00 +00:00
DO_TEST_FULL(name, 0)
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
setenv("PATH", "/bin", 1);
setenv("USER", "test", 1);
setenv("LOGNAME", "test", 1);
setenv("HOME", "/home/test", 1);
unsetenv("TMPDIR");
unsetenv("LD_PRELOAD");
unsetenv("LD_LIBRARY_PATH");
/* Can't roundtrip vcpu cpuset attribute */
qemu: Rename QEMUD_CMD_FLAG_* to QEMU_CAPS_* The new names comply more with the fact that they are all members of enum qemuCapsFlags.
2011-02-07 14:54:08 +00:00
/*DO_TEST("minimal", QEMU_CAPS_NAME);*/
tests: Add tests for dump-core option
2012-08-15 08:16:36 +00:00
DO_TEST("machine-core-on");
DO_TEST("machine-core-off");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("boot-cdrom");
DO_TEST("boot-network");
DO_TEST("boot-floppy");
qemu: parse and create -cpu ...,-kvmclock QEMU supports a bunch of CPUID features that are tied to the kvm CPUID nodes rather than the processor's. They are "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvm_asyncpf". These are not known to libvirt and their CPUID leaf might move if (for example) the Hyper-V extensions are enabled. Hence their handling would anyway require some special-casing. However, among these the most useful is kvmclock; an additional "property" of this feature is that a <timer> element is a better model than a CPUID feature. Although, creating part of the -cpu command-line from something other than the <cpu> XML element introduces some ugliness. Reviewed-by: Jiri Denemark <jdenemar@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2012-01-27 13:49:52 +00:00
DO_TEST("kvmclock");
/* This needs <emulator>./qemu.sh</emulator> which doesn't work here. */
/*DO_TEST("cpu-kvmclock");*/
QEMU Tests for reboot-timeout
2012-09-18 10:32:07 +00:00
DO_TEST("reboot-timeout-enabled");
DO_TEST("reboot-timeout-disabled");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("clock-utc");
DO_TEST("clock-localtime");
DO_TEST("disk-cdrom");
DO_TEST("disk-cdrom-empty");
DO_TEST("disk-floppy");
DO_TEST("disk-many");
DO_TEST("disk-virtio");
DO_TEST("disk-drive-boot-disk");
DO_TEST("disk-drive-boot-cdrom");
DO_TEST("disk-drive-fmt-qcow");
DO_TEST("disk-drive-error-policy-stop");
DO_TEST("disk-drive-error-policy-enospace");
qemu: add separate rerror_policy for disk errors Previously libvirt's disk device XML only had a single attribute, error_policy, to control both read and write error policy, but qemu has separate options for controlling read and write. In one case (enospc) a policy is allowed for write errors but not read errors. This patch adds a separate attribute that sets only the read error policy. If just error_policy is set, it will apply to both read and write error policy (previous behavior), but if the new rerror_policy attribute is set, it will override error_policy for read errors only. Possible values for rerror_policy are "stop", "report", and "ignore" ("report" is the qemu-controlled default for rerror_policy when error_policy isn't specified). For consistency, the value "report" has been added to the possible values for error_policy as well.
2011-10-04 18:17:06 +00:00
DO_TEST("disk-drive-error-policy-wreport-rignore");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("disk-drive-cache-v2-wt");
DO_TEST("disk-drive-cache-v2-wb");
DO_TEST("disk-drive-cache-v2-none");
Add directsync cache mode support for disk driver Newer QEMU introduced cache=directsync for -drive, this patchset is to expose it in libvirt layer. * Introduced a new QEMU capability flag ($prefix_CACHE_DIRECTSYNC), As even $prefix_CACHE_V2 is set, we can't known if directsync is supported.
2011-09-02 13:36:58 +00:00
DO_TEST("disk-drive-cache-directsync");
Add unsafe cache mode support for disk driver QEMU 0.13 introduced cache=unsafe for -drive, this patch exposes it in the libvirt layer. * Introduced a new QEMU capability flag ($prefix_CACHE_UNSAFE), as even if $prefix_CACHE_V2 is set, we can't know if unsafe is supported. * Improved the reliability of qemu cache type detection.
2011-09-22 19:33:47 +00:00
DO_TEST("disk-drive-cache-unsafe");
tests: Add tests for network disks Signed-off-by: Josh Durgin <joshd@hq.newdream.net>
2010-12-07 19:57:33 +00:00
DO_TEST("disk-drive-network-nbd");
qemu: support named nbd exports These are supported by nbd-server and by the NBD server that QEMU embeds for live image access. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com>
2013-02-25 17:44:23 +00:00
DO_TEST("disk-drive-network-nbd-export");
qemu: support URI syntax for NBD QEMU 1.3 and newer support an alternative URI-based syntax to specify the location of an NBD server. Libvirt can keep on using the old syntax in general, but only the URI syntax supports IPv6 addresses. The URI syntax also supports relative paths to Unix sockets. These should never be used but aren't explicitly blocked either by the parser, so support it just in case. The URI syntax is intentionally compatible with Gluster's, and the code can be reused. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com>
2013-02-25 17:44:25 +00:00
DO_TEST("disk-drive-network-nbd-ipv6");
DO_TEST("disk-drive-network-nbd-ipv6-export");
qemu: support NBD with Unix sockets This reuses the XML format that was introduced for Gluster. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com>
2013-02-25 17:44:24 +00:00
DO_TEST("disk-drive-network-nbd-unix");
qemu: add support for libiscsi libiscsi provides a userspace iSCSI initiator. The main advantage over the kernel initiator is that it is very easy to provide different initiator names for VMs on the same host. Thus libiscsi supports usage of persistent reservations in the VM, which otherwise would only be possible with NPIV. libiscsi uses "iscsi" as the scheme, not "iscsi+tcp". We can change this in the tests (while remaining backwards-compatible manner, because QEMU uses TCP as the default transport for both Gluster and NBD). Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2013-03-21 11:53:49 +00:00
DO_TEST("disk-drive-network-iscsi");
qemuargv2xmltest: Resurrect RBD and iSCSI auth Ressurect the disk-drive-network-iscsi-auth and disk-drive-network-rbd-auth tests. Make adjustments to the args and xml file to be compatible with other changes made to the non "-auth" so that the only difference is the authentication information. Adjust the qemuargv2xmltest.c to filter out "<secret" and "</auth>" since the args -> xml has no concept of usage it doesn't get printed. This results in the </auth> being printed on the same line as "<secret" and the secret XML is not closed - a bit of an issue, but soon to be fixed.
2014-06-25 16:16:56 +00:00
DO_TEST("disk-drive-network-iscsi-auth");
tests: Add tests for gluster protocol based network disks support Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
2012-11-22 18:10:41 +00:00
DO_TEST("disk-drive-network-gluster");
tests: Add tests for network disks Signed-off-by: Josh Durgin <joshd@hq.newdream.net>
2010-12-07 19:57:33 +00:00
DO_TEST("disk-drive-network-rbd");
qemuargv2xmltest: Resurrect RBD and iSCSI auth Ressurect the disk-drive-network-iscsi-auth and disk-drive-network-rbd-auth tests. Make adjustments to the args and xml file to be compatible with other changes made to the non "-auth" so that the only difference is the authentication information. Adjust the qemuargv2xmltest.c to filter out "<secret" and "</auth>" since the args -> xml has no concept of usage it doesn't get printed. This results in the </auth> being printed on the same line as "<secret" and the secret XML is not closed - a bit of an issue, but soon to be fixed.
2014-06-25 16:16:56 +00:00
DO_TEST("disk-drive-network-rbd-auth");
qemu: escape ipv6 for rbd network disk hosts Hosts for rbd are ceph monitor daemons. These have fixed IP addresses, so they are often referenced by IP rather than hostname for convenience, or to avoid relying on DNS. Using IPv4 addresses as the host name works already, but IPv6 addresses require rbd-specific escaping because the colon is used as an option separator in the string passed to qemu. Escape these colons, and enclose the IPv6 address in square brackets so it is distinguished from the port, which is currently mandatory. Acked-by: Osier Yang <jyang@redhat.com> Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
2013-01-25 02:45:31 +00:00
DO_TEST("disk-drive-network-rbd-ipv6");
qemu/rbd: improve rbd device specification This improves the support for qemu rbd devices by adding support for a few key features (e.g., authentication) and cleaning up the way in which rbd configuration options are passed to qemu. An <auth> member of the disk source xml specifies how librbd should authenticate. The username attribute is the Ceph/RBD user to authenticate as. The usage or uuid attributes specify which secret to use. Usage is an arbitrary identifier local to libvirt. The old RBD support relied on setting an environment variable to communicate information to qemu/librbd. Instead, pass those options explicitly to qemu. Update the qemu argument parsing and tests accordingly. Signed-off-by: Sage Weil <sage@newdream.net> Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
2011-11-01 01:29:07 +00:00
/* older format using CEPH_ARGS env var */
DO_TEST("disk-drive-network-rbd-ceph-env");
tests: Add tests for network disks Signed-off-by: Josh Durgin <joshd@hq.newdream.net>
2010-12-07 19:57:33 +00:00
DO_TEST("disk-drive-network-sheepdog");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("disk-usb");
DO_TEST("graphics-vnc");
qemu: Allow serving VNC over a unix domain socket QEMU supports serving VNC over a unix domain socket rather than traditional TCP host/port. This is specified with: <graphics type='vnc' socket='/foo/bar/baz'/> This provides better security access control than VNC listening on 127.0.0.1, but will cause issues with tools that rely on the lax security (virt-manager in fedora runs as regular user by default, and wouldn't be able to access a socket owned by 'qemu' or 'root'). Also not currently supported by any clients, though I have patches for virt-manager, and virt-viewer should be simple to update. v2: schema: Make listen vs. socket a <choice>
2011-01-07 21:03:07 +00:00
DO_TEST("graphics-vnc-socket");
qemu: Add VNC WebSocket support Adding a VNC WebSocket support for QEMU driver. This functionality is in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the capability is being recognized based on QEMU version for now.
2013-04-30 14:26:43 +00:00
DO_TEST("graphics-vnc-websocket");
qemu: add ', share=<policy>' to qemu commandline example: qemu ${otherargs} \ -vnc 127.0.0.1:0,share=allow-exclusive
2013-05-21 14:31:49 +00:00
DO_TEST("graphics-vnc-policy");
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("graphics-vnc-sasl");
DO_TEST("graphics-vnc-tls");
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("graphics-sdl");
DO_TEST("graphics-sdl-fullscreen");
DO_TEST("nographics-vga");
qemu: generate -display none This is preferrable to -nographic which (in addition to disabling graphics output) redirects the serial port to stdio and on OpenBIOS enables the firmware's serial console. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-07-05 12:35:28 +00:00
DO_TEST("nographics-vga-display");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("input-usbmouse");
DO_TEST("input-usbtablet");
DO_TEST("misc-acpi");
tests: Add tests for qemu S3/S4 state configuration Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other.
2012-08-02 10:18:16 +00:00
DO_TEST("misc-disable-s3");
DO_TEST("misc-disable-suspends");
DO_TEST("misc-enable-s4");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
DO_TEST("misc-no-reboot");
DO_TEST("misc-uuid");
DO_TEST("net-user");
DO_TEST("net-virtio");
DO_TEST("net-eth");
DO_TEST("net-eth-ifname");
DO_TEST("serial-vc");
DO_TEST("serial-pty");
DO_TEST("serial-dev");
DO_TEST("serial-file");
DO_TEST("serial-unix");
DO_TEST("serial-tcp");
DO_TEST("serial-udp");
DO_TEST("serial-tcp-telnet");
DO_TEST("serial-many");
DO_TEST("parallel-tcp");
DO_TEST("console-compat");
DO_TEST("sound");
DO_TEST("watchdog");
DO_TEST("hostdev-usb-address");
DO_TEST("hostdev-pci-address");
qemu: parse: Handle suffixes for -m memory According to QEMU docs, the '-m' option for specifying RAM is by default in MiB, and a suffix of "M" or "G" may be passed for values in MiB and GiB respectively. This commit adds support and a test for the same. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=812295 Signed-off-by: Nishith Shah <nishithshah.2211@gmail.com>
2016-05-20 07:09:03 +00:00
DO_TEST("mem-scale");
qemu: argv: parse qemu commandline memory arguments Existing qemuParseCommandLineMem() will parse "-m 4G" format string. This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k" format along with existing format. And adds a testcase to validate the changes. Signed-off-by: Kothapally Madhu Pavan <kmp@linux.vnet.ibm.com>
2017-10-09 17:16:29 +00:00
DO_TEST("mem-scale-maxmemory");
vcpu: improve vcpu support in qemu command line * src/qemu/qemu_conf.c (qemuParseCommandLineSmp): Distinguish between vcpus and maxvcpus, for new enough qemu. * tests/qemuargv2xmltest.c (mymain): Add new test. * tests/qemuxml2argvtest.c (mymain): Likewise. * tests/qemuxml2xmltest.c (mymain): Likewise. * tests/qemuxml2argvdata/qemuxml2argv-smp.args: New file.
2010-09-29 21:58:47 +00:00
DO_TEST("smp");
qemu: Add support for HyperV Enlightenment feature "relaxed" This patch adds QEMU support for the "relaxed" feature implemented by previous patch.
2012-10-17 12:55:18 +00:00
DO_TEST("hyperv");
qemu: add support for hv_crash feature as a panic device Panic device type used depends on 'model' attribute. If no model is specified then device type depends on hypervisor and guest arch. 'pseries' model is used for pSeries guest and 'isa' model is used in other cases. XML: <devices> <panic model='hyperv'/> </devices> QEMU command line: qemu -cpu <cpu_model>,hv_crash
2015-11-24 12:26:33 +00:00
DO_TEST("hyperv-panic");
qemu: Add support for HyperV Enlightenment feature "relaxed" This patch adds QEMU support for the "relaxed" feature implemented by previous patch.
2012-10-17 12:55:18 +00:00
Add new 'kvm' domain feature and ability to hide KVM signature QEMU 2.1 added support for the kvm=off option to the -cpu command, allowing the KVM hypervisor signature to be hidden from the guest. This enables disabling of some paravirualization features in the guest as well as allowing certain drivers which test for the hypervisor to load. Domain XML syntax is as follows: <domain type='kvm> ... <features> ... <kvm> <hidden state='on'/> </kvm> </features> ... Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
2014-08-21 17:04:45 +00:00
DO_TEST("kvm-features");
qemu: Add command line builder and parser for NVRAM. This patch is to add command line builder and parser for NVRAM device, and add test cases. Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
2013-04-25 08:46:04 +00:00
DO_TEST("pseries-nvram");
virsh domxml-from-native to treat SCSI as the bus type for pseries by default The bus type IDE being enum Zero, the bus type on pseries system appears as IDE for all the -hda/-cdrom and for disk drives with if="none" type. Pseries platform needs this to appear as SCSI instead of IDE. The ide being not supported, the explicit requests for ide devices will return an error. Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
2013-11-22 17:27:25 +00:00
DO_TEST("pseries-disk");
qemu: Add command line builder and parser for NVRAM. This patch is to add command line builder and parser for NVRAM device, and add test cases. Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
2013-04-25 08:46:04 +00:00
qemu: New XML to disable memory merge at guest startup QEMU introduced command line "-mem-merge=on|off" (defaults to on) to enable/disable the memory merge (KSM) at guest startup. This exposes it by new XML: <memoryBacking> <nosharepages/> </memoryBacking> The XML tag is same with what we used internally for old RHEL.
2013-05-14 05:25:50 +00:00
DO_TEST("nosharepages");
tests: drop dead code from argv2xml and xml2xml Noticed while tweaking the RelaxNG grammar for <disk> elements. * tests/qemuxml2xmloutdata/qemuxml2xmlout-numad-static-vcpu-no-numatune.xml: * tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml: Drop unused files. * tests/qemuargv2xmltest.c (testInfo, DO_TEST_FULL): Drop unused field. Signed-off-by: Eric Blake <eblake@redhat.com>
2014-04-11 18:51:00 +00:00
DO_TEST("restore-v2");
DO_TEST("migrate");
tests: clean up qemuargv2xmltest Since commit 107a7bd06bc, the extraFlags argument was unused. * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument. Adjust all callers.
2010-09-10 02:32:50 +00:00
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0 qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on. In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future.
2014-06-06 12:40:31 +00:00
DO_TEST_FULL("qemu-ns-no-env", FLAG_EXPECT_WARNING);
Add tests for the new Qemu namespace XML. Thanks to DV for knocking together the Relax-NG changes quickly for me. Changes since v1: - Change the domain.rng to correspond to the new schema - Don't allocate caps->ns in testQemuCapsInit since it is a static table Changes since v2: - Change domain.rng to add restrictions on allowed environment names Changes since v3: - Remove a bogus comment in the tests Signed-off-by: Chris Lalancette <clalance@redhat.com>
2010-04-20 21:22:49 +00:00
libvirt: tests: test protected key mgmt ops support Test the support for enabling/disabling CPACF protected key management operations for a guest. Signed-off-by: Tony Krowiak <akrowiak@linux.vnet.ibm.com> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2015-04-27 21:57:30 +00:00
DO_TEST("machine-aeskeywrap-on-argv");
DO_TEST("machine-aeskeywrap-off-argv");
DO_TEST("machine-deakeywrap-on-argv");
DO_TEST("machine-deakeywrap-off-argv");
DO_TEST("machine-keywrap-none-argv");
qemu: Don't crash when parsing command line lacking -M Parse the -M (or -machine) command line option before starting processing in earnest and have a fallback ready in case it's not present, so that while parsing other options we can rely on def->os.machine being initialized. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1379218 Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
2017-10-10 13:53:53 +00:00
DO_TEST("nomachine-x86_64");
DO_TEST("nomachine-ppc64");
tests: split out common qemu driver initialization Two utility functions are introduced for proper initialization and cleanup of the driver. Signed-off-by: Pavel Fedin <p.fedin@samsung.com> Signed-off-by: Ján Tomko <jtomko@redhat.com>
2015-09-15 06:16:02 +00:00
qemuTestDriverFree(&driver);
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
Require spaces around equality comparisons Commit a1cbe4b5 added a check for spaces around assignments and this patch extends it to checks for spaces around '=='. One exception is virAssertCmpInt where comma after '==' is acceptable (since it is a macro and '==' is its argument). Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-03-17 09:38:38 +00:00
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
}
tests: Rename VIRT_TEST_* macros to VIR_TEST_* We use the "vir" prefix pretty consistently in our APIs, both external and internal, which made these macros stood out.
2017-03-29 14:45:42 +00:00
VIR_TEST_MAIN(mymain)
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
#else
tests: Unify style of test skipping code Prefer 'return EXIT_AM_SKIP' over 'exit(EXIT_AM_SKIP)'. Prefer 'int main(void)' over 'int main(int argc, char **argv)'. Fix mymain signature in commandtest and nodeinfotest.
2011-07-28 15:48:12 +00:00
int
main(void)
{
return EXIT_AM_SKIP;
}
Test case for QEMU driver ARGV -> XML conversion
2009-05-21 14:22:51 +00:00
#endif /* WITH_QEMU */
Reference in New Issue Copy Permalink