2009-09-25 13:20:13 +00:00
|
|
|
/*
|
|
|
|
* storage_file.c: file utility functions for FS storage backend
|
|
|
|
*
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
* Copyright (C) 2007-2012 Red Hat, Inc.
|
2009-09-25 13:20:13 +00:00
|
|
|
* Copyright (C) 2007-2008 Daniel P. Berrange
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
2012-09-20 22:30:55 +00:00
|
|
|
* License along with this library. If not, see
|
2012-07-21 10:06:23 +00:00
|
|
|
* <http://www.gnu.org/licenses/>.
|
2009-09-25 13:20:13 +00:00
|
|
|
*
|
|
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
#include "storage_file.h"
|
|
|
|
|
2011-07-20 09:40:53 +00:00
|
|
|
#include <command.h>
|
2011-05-26 18:05:32 +00:00
|
|
|
#include <sys/stat.h>
|
2009-09-29 08:34:48 +00:00
|
|
|
#include <unistd.h>
|
2009-09-29 08:41:23 +00:00
|
|
|
#include <fcntl.h>
|
2012-10-09 23:47:42 +00:00
|
|
|
#include <stdlib.h>
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
#ifdef __linux__
|
2010-05-17 14:17:08 +00:00
|
|
|
# if HAVE_LINUX_MAGIC_H
|
|
|
|
# include <linux/magic.h>
|
|
|
|
# endif
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
# include <sys/statfs.h>
|
|
|
|
#endif
|
2010-02-04 15:55:57 +00:00
|
|
|
#include "dirname.h"
|
2009-09-29 08:34:48 +00:00
|
|
|
#include "memory.h"
|
|
|
|
#include "virterror_internal.h"
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
#include "logging.h"
|
2011-07-19 18:32:58 +00:00
|
|
|
#include "virfile.h"
|
2011-07-20 09:40:53 +00:00
|
|
|
#include "c-ctype.h"
|
2012-10-13 16:47:15 +00:00
|
|
|
#include "virhash.h"
|
2009-09-29 08:34:48 +00:00
|
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_STORAGE
|
|
|
|
|
2009-09-25 13:20:13 +00:00
|
|
|
VIR_ENUM_IMPL(virStorageFileFormat,
|
|
|
|
VIR_STORAGE_FILE_LAST,
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
"none",
|
2010-11-22 20:08:17 +00:00
|
|
|
"raw", "dir", "bochs",
|
2009-09-25 13:20:13 +00:00
|
|
|
"cloop", "cow", "dmg", "iso",
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
"qcow", "qcow2", "qed", "vmdk", "vpc",
|
|
|
|
"fat", "vhd")
|
2009-09-29 08:34:48 +00:00
|
|
|
|
|
|
|
enum lv_endian {
|
|
|
|
LV_LITTLE_ENDIAN = 1, /* 1234 */
|
|
|
|
LV_BIG_ENDIAN /* 4321 */
|
|
|
|
};
|
|
|
|
|
|
|
|
enum {
|
|
|
|
BACKING_STORE_OK,
|
|
|
|
BACKING_STORE_INVALID,
|
|
|
|
BACKING_STORE_ERROR,
|
|
|
|
};
|
|
|
|
|
|
|
|
/* Either 'magic' or 'extension' *must* be provided */
|
|
|
|
struct FileTypeInfo {
|
|
|
|
const char *magic; /* Optional string of file magic
|
|
|
|
* to check at head of file */
|
|
|
|
const char *extension; /* Optional file extension to check */
|
|
|
|
enum lv_endian endian; /* Endianness of file format */
|
|
|
|
int versionOffset; /* Byte offset from start of file
|
|
|
|
* where we find version number,
|
|
|
|
* -1 to skip version test */
|
|
|
|
int versionNumber; /* Version number to validate */
|
|
|
|
int sizeOffset; /* Byte offset from start of file
|
|
|
|
* where we find capacity info,
|
|
|
|
* -1 to use st_size as capacity */
|
|
|
|
int sizeBytes; /* Number of bytes for size field */
|
|
|
|
int sizeMultiplier; /* A scaling factor if size is not in bytes */
|
|
|
|
/* Store a COW base image path (possibly relative),
|
|
|
|
* or NULL if there is no COW base image, to RES;
|
|
|
|
* return BACKING_STORE_* */
|
|
|
|
int qcowCryptOffset; /* Byte offset from start of file
|
|
|
|
* where to find encryption mode,
|
|
|
|
* -1 if encryption is not used */
|
2010-06-14 14:53:59 +00:00
|
|
|
int (*getBackingStore)(char **res, int *format,
|
|
|
|
const unsigned char *buf, size_t buf_size);
|
2009-09-29 08:34:48 +00:00
|
|
|
};
|
|
|
|
|
2010-06-14 14:53:59 +00:00
|
|
|
static int cowGetBackingStore(char **, int *,
|
|
|
|
const unsigned char *, size_t);
|
|
|
|
static int qcow1GetBackingStore(char **, int *,
|
|
|
|
const unsigned char *, size_t);
|
|
|
|
static int qcow2GetBackingStore(char **, int *,
|
|
|
|
const unsigned char *, size_t);
|
|
|
|
static int vmdk4GetBackingStore(char **, int *,
|
|
|
|
const unsigned char *, size_t);
|
2010-11-19 23:19:24 +00:00
|
|
|
static int
|
|
|
|
qedGetBackingStore(char **, int *, const unsigned char *, size_t);
|
2010-06-14 14:53:59 +00:00
|
|
|
|
|
|
|
#define QCOWX_HDR_VERSION (4)
|
|
|
|
#define QCOWX_HDR_BACKING_FILE_OFFSET (QCOWX_HDR_VERSION+4)
|
|
|
|
#define QCOWX_HDR_BACKING_FILE_SIZE (QCOWX_HDR_BACKING_FILE_OFFSET+8)
|
|
|
|
#define QCOWX_HDR_IMAGE_SIZE (QCOWX_HDR_BACKING_FILE_SIZE+4+4)
|
|
|
|
|
|
|
|
#define QCOW1_HDR_CRYPT (QCOWX_HDR_IMAGE_SIZE+8+1+1)
|
|
|
|
#define QCOW2_HDR_CRYPT (QCOWX_HDR_IMAGE_SIZE+8)
|
|
|
|
|
|
|
|
#define QCOW1_HDR_TOTAL_SIZE (QCOW1_HDR_CRYPT+4+8)
|
|
|
|
#define QCOW2_HDR_TOTAL_SIZE (QCOW2_HDR_CRYPT+4+4+8+8+4+4+8)
|
|
|
|
|
|
|
|
#define QCOW2_HDR_EXTENSION_END 0
|
|
|
|
#define QCOW2_HDR_EXTENSION_BACKING_FORMAT 0xE2792ACA
|
|
|
|
|
2010-11-19 23:19:24 +00:00
|
|
|
#define QED_HDR_FEATURES_OFFSET (4+4+4+4)
|
2010-11-22 20:08:17 +00:00
|
|
|
#define QED_HDR_IMAGE_SIZE (QED_HDR_FEATURES_OFFSET+8+8+8+8)
|
|
|
|
#define QED_HDR_BACKING_FILE_OFFSET (QED_HDR_IMAGE_SIZE+8)
|
2010-11-19 23:19:24 +00:00
|
|
|
#define QED_HDR_BACKING_FILE_SIZE (QED_HDR_BACKING_FILE_OFFSET+4)
|
|
|
|
#define QED_F_BACKING_FILE 0x01
|
|
|
|
#define QED_F_BACKING_FORMAT_NO_PROBE 0x04
|
2010-11-19 16:18:16 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
/* VMDK needs at least this to find backing store,
|
|
|
|
* other formats need less */
|
|
|
|
#define STORAGE_MAX_HEAD (20*512)
|
2009-09-29 08:34:48 +00:00
|
|
|
|
|
|
|
|
|
|
|
static struct FileTypeInfo const fileTypeInfo[] = {
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
[VIR_STORAGE_FILE_NONE] = { NULL, NULL, LV_LITTLE_ENDIAN,
|
|
|
|
-1, 0, 0, 0, 0, 0, NULL },
|
|
|
|
[VIR_STORAGE_FILE_RAW] = { NULL, NULL, LV_LITTLE_ENDIAN,
|
|
|
|
-1, 0, 0, 0, 0, 0, NULL },
|
|
|
|
[VIR_STORAGE_FILE_DIR] = { NULL, NULL, LV_LITTLE_ENDIAN,
|
|
|
|
-1, 0, 0, 0, 0, 0, NULL },
|
2010-06-14 15:39:32 +00:00
|
|
|
[VIR_STORAGE_FILE_BOCHS] = {
|
|
|
|
/*"Bochs Virtual HD Image", */ /* Untested */ NULL,
|
|
|
|
NULL,
|
|
|
|
LV_LITTLE_ENDIAN, 64, 0x20000,
|
|
|
|
32+16+16+4+4+4+4+4, 8, 1, -1, NULL
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_CLOOP] = {
|
|
|
|
/*"#!/bin/sh\n#V2.0 Format\nmodprobe cloop file=$0 && mount -r -t iso9660 /dev/cloop $1\n", */ /* Untested */ NULL,
|
|
|
|
NULL,
|
|
|
|
LV_LITTLE_ENDIAN, -1, 0,
|
|
|
|
-1, 0, 0, -1, NULL
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_COW] = {
|
|
|
|
"OOOM", NULL,
|
|
|
|
LV_BIG_ENDIAN, 4, 2,
|
|
|
|
4+4+1024+4, 8, 1, -1, cowGetBackingStore
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_DMG] = {
|
|
|
|
NULL, /* XXX QEMU says there's no magic for dmg, but we should check... */
|
|
|
|
".dmg",
|
|
|
|
0, -1, 0,
|
|
|
|
-1, 0, 0, -1, NULL
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_ISO] = {
|
|
|
|
NULL, /* XXX there's probably some magic for iso we can validate too... */
|
|
|
|
".iso",
|
|
|
|
0, -1, 0,
|
|
|
|
-1, 0, 0, -1, NULL
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_QCOW] = {
|
|
|
|
"QFI", NULL,
|
|
|
|
LV_BIG_ENDIAN, 4, 1,
|
|
|
|
QCOWX_HDR_IMAGE_SIZE, 8, 1, QCOW1_HDR_CRYPT, qcow1GetBackingStore,
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_QCOW2] = {
|
|
|
|
"QFI", NULL,
|
|
|
|
LV_BIG_ENDIAN, 4, 2,
|
|
|
|
QCOWX_HDR_IMAGE_SIZE, 8, 1, QCOW2_HDR_CRYPT, qcow2GetBackingStore,
|
|
|
|
},
|
2010-11-19 16:18:16 +00:00
|
|
|
[VIR_STORAGE_FILE_QED] = {
|
|
|
|
/* http://wiki.qemu.org/Features/QED */
|
|
|
|
"QED\0", NULL,
|
|
|
|
LV_LITTLE_ENDIAN, -1, -1,
|
2010-11-19 23:19:24 +00:00
|
|
|
QED_HDR_IMAGE_SIZE, 8, 1, -1, qedGetBackingStore,
|
2010-11-19 16:18:16 +00:00
|
|
|
},
|
2010-06-14 15:39:32 +00:00
|
|
|
[VIR_STORAGE_FILE_VMDK] = {
|
|
|
|
"KDMV", NULL,
|
|
|
|
LV_LITTLE_ENDIAN, 4, 1,
|
|
|
|
4+4+4, 8, 512, -1, vmdk4GetBackingStore
|
|
|
|
},
|
|
|
|
[VIR_STORAGE_FILE_VPC] = {
|
|
|
|
"conectix", NULL,
|
|
|
|
LV_BIG_ENDIAN, 12, 0x10000,
|
|
|
|
8 + 4 + 4 + 8 + 4 + 4 + 2 + 2 + 4, 8, 1, -1, NULL
|
|
|
|
},
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
/* Not direct file formats, but used for various drivers */
|
|
|
|
[VIR_STORAGE_FILE_FAT] = { NULL, NULL, LV_LITTLE_ENDIAN,
|
|
|
|
-1, 0, 0, 0, 0, 0, NULL },
|
|
|
|
[VIR_STORAGE_FILE_VHD] = { NULL, NULL, LV_LITTLE_ENDIAN,
|
|
|
|
-1, 0, 0, 0, 0, 0, NULL },
|
2009-09-29 08:34:48 +00:00
|
|
|
};
|
2010-06-14 15:39:32 +00:00
|
|
|
verify(ARRAY_CARDINALITY(fileTypeInfo) == VIR_STORAGE_FILE_LAST);
|
2009-09-29 08:34:48 +00:00
|
|
|
|
|
|
|
static int
|
2010-02-04 22:46:55 +00:00
|
|
|
cowGetBackingStore(char **res,
|
2010-06-14 14:53:59 +00:00
|
|
|
int *format,
|
2009-09-29 08:34:48 +00:00
|
|
|
const unsigned char *buf,
|
|
|
|
size_t buf_size)
|
|
|
|
{
|
|
|
|
#define COW_FILENAME_MAXLEN 1024
|
|
|
|
*res = NULL;
|
2010-06-14 14:53:59 +00:00
|
|
|
*format = VIR_STORAGE_FILE_AUTO;
|
|
|
|
|
2009-09-29 08:34:48 +00:00
|
|
|
if (buf_size < 4+4+ COW_FILENAME_MAXLEN)
|
|
|
|
return BACKING_STORE_INVALID;
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (buf[4+4] == '\0') { /* cow_header_v2.backing_file[0] */
|
|
|
|
*format = VIR_STORAGE_FILE_NONE;
|
2009-09-29 08:34:48 +00:00
|
|
|
return BACKING_STORE_OK;
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2012-10-17 09:23:12 +00:00
|
|
|
*res = strndup((const char*)buf + 4+4, COW_FILENAME_MAXLEN);
|
2009-09-29 08:34:48 +00:00
|
|
|
if (*res == NULL) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2009-09-29 08:34:48 +00:00
|
|
|
return BACKING_STORE_ERROR;
|
|
|
|
}
|
|
|
|
return BACKING_STORE_OK;
|
|
|
|
}
|
|
|
|
|
2010-06-14 14:53:59 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
qcow2GetBackingStoreFormat(int *format,
|
|
|
|
const unsigned char *buf,
|
|
|
|
size_t buf_size,
|
|
|
|
size_t extension_start,
|
|
|
|
size_t extension_end)
|
|
|
|
{
|
|
|
|
size_t offset = extension_start;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The extensions take format of
|
|
|
|
*
|
|
|
|
* int32: magic
|
|
|
|
* int32: length
|
|
|
|
* byte[length]: payload
|
|
|
|
*
|
|
|
|
* Unknown extensions can be ignored by skipping
|
|
|
|
* over "length" bytes in the data stream.
|
|
|
|
*/
|
|
|
|
while (offset < (buf_size-8) &&
|
|
|
|
offset < (extension_end-8)) {
|
|
|
|
unsigned int magic =
|
|
|
|
(buf[offset] << 24) +
|
|
|
|
(buf[offset+1] << 16) +
|
|
|
|
(buf[offset+2] << 8) +
|
|
|
|
(buf[offset+3]);
|
|
|
|
unsigned int len =
|
|
|
|
(buf[offset+4] << 24) +
|
|
|
|
(buf[offset+5] << 16) +
|
|
|
|
(buf[offset+6] << 8) +
|
|
|
|
(buf[offset+7]);
|
|
|
|
|
|
|
|
offset += 8;
|
|
|
|
|
|
|
|
if ((offset + len) < offset)
|
|
|
|
break;
|
|
|
|
|
|
|
|
if ((offset + len) > buf_size)
|
|
|
|
break;
|
|
|
|
|
|
|
|
switch (magic) {
|
|
|
|
case QCOW2_HDR_EXTENSION_END:
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
case QCOW2_HDR_EXTENSION_BACKING_FORMAT:
|
|
|
|
if (buf[offset+len] != '\0')
|
|
|
|
break;
|
|
|
|
*format = virStorageFileFormatTypeFromString(
|
|
|
|
((const char *)buf)+offset);
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (*format <= VIR_STORAGE_FILE_NONE)
|
|
|
|
return -1;
|
2010-06-14 14:53:59 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
offset += len;
|
|
|
|
}
|
|
|
|
|
|
|
|
done:
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-09-29 08:34:48 +00:00
|
|
|
static int
|
2010-02-04 22:46:55 +00:00
|
|
|
qcowXGetBackingStore(char **res,
|
2010-06-14 14:53:59 +00:00
|
|
|
int *format,
|
2009-09-29 08:34:48 +00:00
|
|
|
const unsigned char *buf,
|
2010-06-14 14:53:59 +00:00
|
|
|
size_t buf_size,
|
|
|
|
bool isQCow2)
|
2009-09-29 08:34:48 +00:00
|
|
|
{
|
|
|
|
unsigned long long offset;
|
2011-06-02 23:52:16 +00:00
|
|
|
unsigned int size;
|
2009-09-29 08:34:48 +00:00
|
|
|
|
|
|
|
*res = NULL;
|
2010-06-14 14:53:59 +00:00
|
|
|
if (format)
|
|
|
|
*format = VIR_STORAGE_FILE_AUTO;
|
|
|
|
|
|
|
|
if (buf_size < QCOWX_HDR_BACKING_FILE_OFFSET+8+4)
|
2009-09-29 08:34:48 +00:00
|
|
|
return BACKING_STORE_INVALID;
|
2010-06-14 14:53:59 +00:00
|
|
|
offset = (((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET] << 56)
|
|
|
|
| ((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET+1] << 48)
|
|
|
|
| ((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET+2] << 40)
|
|
|
|
| ((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET+3] << 32)
|
|
|
|
| ((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET+4] << 24)
|
|
|
|
| ((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET+5] << 16)
|
|
|
|
| ((unsigned long long)buf[QCOWX_HDR_BACKING_FILE_OFFSET+6] << 8)
|
|
|
|
| buf[QCOWX_HDR_BACKING_FILE_OFFSET+7]); /* QCowHeader.backing_file_offset */
|
2009-09-29 08:34:48 +00:00
|
|
|
if (offset > buf_size)
|
|
|
|
return BACKING_STORE_INVALID;
|
2010-06-14 14:53:59 +00:00
|
|
|
size = ((buf[QCOWX_HDR_BACKING_FILE_SIZE] << 24)
|
|
|
|
| (buf[QCOWX_HDR_BACKING_FILE_SIZE+1] << 16)
|
|
|
|
| (buf[QCOWX_HDR_BACKING_FILE_SIZE+2] << 8)
|
|
|
|
| buf[QCOWX_HDR_BACKING_FILE_SIZE+3]); /* QCowHeader.backing_file_size */
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (size == 0) {
|
|
|
|
if (format)
|
|
|
|
*format = VIR_STORAGE_FILE_NONE;
|
2009-09-29 08:34:48 +00:00
|
|
|
return BACKING_STORE_OK;
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
if (offset + size > buf_size || offset + size < offset)
|
|
|
|
return BACKING_STORE_INVALID;
|
|
|
|
if (size + 1 == 0)
|
|
|
|
return BACKING_STORE_INVALID;
|
|
|
|
if (VIR_ALLOC_N(*res, size + 1) < 0) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2009-09-29 08:34:48 +00:00
|
|
|
return BACKING_STORE_ERROR;
|
|
|
|
}
|
|
|
|
memcpy(*res, buf + offset, size);
|
|
|
|
(*res)[size] = '\0';
|
2010-06-14 14:53:59 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Traditionally QCow2 files had a layout of
|
|
|
|
*
|
|
|
|
* [header]
|
|
|
|
* [backingStoreName]
|
|
|
|
*
|
|
|
|
* Although the backingStoreName typically followed
|
|
|
|
* the header immediately, this was not required by
|
|
|
|
* the format. By specifying a higher byte offset for
|
|
|
|
* the backing file offset in the header, it was
|
|
|
|
* possible to leave space between the header and
|
|
|
|
* start of backingStore.
|
|
|
|
*
|
|
|
|
* This hack is now used to store extensions to the
|
|
|
|
* qcow2 format:
|
|
|
|
*
|
|
|
|
* [header]
|
|
|
|
* [extensions]
|
|
|
|
* [backingStoreName]
|
|
|
|
*
|
|
|
|
* Thus the file region to search for extensions is
|
|
|
|
* between the end of the header (QCOW2_HDR_TOTAL_SIZE)
|
|
|
|
* and the start of the backingStoreName (offset)
|
|
|
|
*/
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (isQCow2 && format &&
|
|
|
|
qcow2GetBackingStoreFormat(format, buf, buf_size, QCOW2_HDR_TOTAL_SIZE,
|
|
|
|
offset) < 0)
|
|
|
|
return BACKING_STORE_INVALID;
|
2010-06-14 14:53:59 +00:00
|
|
|
|
2009-09-29 08:34:48 +00:00
|
|
|
return BACKING_STORE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2010-06-14 14:53:59 +00:00
|
|
|
static int
|
|
|
|
qcow1GetBackingStore(char **res,
|
|
|
|
int *format,
|
|
|
|
const unsigned char *buf,
|
|
|
|
size_t buf_size)
|
|
|
|
{
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
int ret;
|
|
|
|
|
2010-06-14 14:53:59 +00:00
|
|
|
/* QCow1 doesn't have the extensions capability
|
|
|
|
* used to store backing format */
|
|
|
|
*format = VIR_STORAGE_FILE_AUTO;
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
ret = qcowXGetBackingStore(res, NULL, buf, buf_size, false);
|
|
|
|
if (ret == 0 && *buf == '\0')
|
|
|
|
*format = VIR_STORAGE_FILE_NONE;
|
|
|
|
return ret;
|
2010-06-14 14:53:59 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
qcow2GetBackingStore(char **res,
|
|
|
|
int *format,
|
|
|
|
const unsigned char *buf,
|
|
|
|
size_t buf_size)
|
|
|
|
{
|
|
|
|
return qcowXGetBackingStore(res, format, buf, buf_size, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-09-29 08:34:48 +00:00
|
|
|
static int
|
2010-02-04 22:46:55 +00:00
|
|
|
vmdk4GetBackingStore(char **res,
|
2010-06-14 14:53:59 +00:00
|
|
|
int *format,
|
2009-09-29 08:34:48 +00:00
|
|
|
const unsigned char *buf,
|
|
|
|
size_t buf_size)
|
|
|
|
{
|
|
|
|
static const char prefix[] = "parentFileNameHint=\"";
|
2010-06-15 13:58:10 +00:00
|
|
|
char *desc, *start, *end;
|
2009-09-29 08:34:48 +00:00
|
|
|
size_t len;
|
2010-06-15 13:58:10 +00:00
|
|
|
int ret = BACKING_STORE_ERROR;
|
|
|
|
|
|
|
|
if (VIR_ALLOC_N(desc, STORAGE_MAX_HEAD + 1) < 0) {
|
|
|
|
virReportOOMError();
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
|
|
|
*res = NULL;
|
2010-06-14 14:53:59 +00:00
|
|
|
/*
|
|
|
|
* Technically this should have been VMDK, since
|
|
|
|
* VMDK spec / VMWare impl only support VMDK backed
|
|
|
|
* by VMDK. QEMU isn't following this though and
|
|
|
|
* does probing on VMDK backing files, hence we set
|
|
|
|
* AUTO
|
|
|
|
*/
|
|
|
|
*format = VIR_STORAGE_FILE_AUTO;
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (buf_size <= 0x200) {
|
|
|
|
ret = BACKING_STORE_INVALID;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
len = buf_size - 0x200;
|
2010-06-15 13:58:10 +00:00
|
|
|
if (len > STORAGE_MAX_HEAD)
|
|
|
|
len = STORAGE_MAX_HEAD;
|
2009-09-29 08:34:48 +00:00
|
|
|
memcpy(desc, buf + 0x200, len);
|
|
|
|
desc[len] = '\0';
|
|
|
|
start = strstr(desc, prefix);
|
2010-06-15 13:58:10 +00:00
|
|
|
if (start == NULL) {
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
*format = VIR_STORAGE_FILE_NONE;
|
2010-06-15 13:58:10 +00:00
|
|
|
ret = BACKING_STORE_OK;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
start += strlen(prefix);
|
|
|
|
end = strchr(start, '"');
|
2010-06-15 13:58:10 +00:00
|
|
|
if (end == NULL) {
|
|
|
|
ret = BACKING_STORE_INVALID;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (end == start) {
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
*format = VIR_STORAGE_FILE_NONE;
|
2010-06-15 13:58:10 +00:00
|
|
|
ret = BACKING_STORE_OK;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
*end = '\0';
|
|
|
|
*res = strdup(start);
|
|
|
|
if (*res == NULL) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2010-06-15 13:58:10 +00:00
|
|
|
goto cleanup;
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
ret = BACKING_STORE_OK;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
VIR_FREE(desc);
|
|
|
|
return ret;
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
|
|
|
|
2010-11-19 23:19:24 +00:00
|
|
|
static unsigned long
|
|
|
|
qedGetHeaderUL(const unsigned char *loc)
|
|
|
|
{
|
2012-10-17 09:23:12 +00:00
|
|
|
return (((unsigned long)loc[3] << 24) |
|
|
|
|
((unsigned long)loc[2] << 16) |
|
|
|
|
((unsigned long)loc[1] << 8) |
|
|
|
|
((unsigned long)loc[0] << 0));
|
2010-11-19 23:19:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long long
|
|
|
|
qedGetHeaderULL(const unsigned char *loc)
|
|
|
|
{
|
2012-10-17 09:23:12 +00:00
|
|
|
return (((unsigned long long)loc[7] << 56) |
|
|
|
|
((unsigned long long)loc[6] << 48) |
|
|
|
|
((unsigned long long)loc[5] << 40) |
|
|
|
|
((unsigned long long)loc[4] << 32) |
|
|
|
|
((unsigned long long)loc[3] << 24) |
|
|
|
|
((unsigned long long)loc[2] << 16) |
|
|
|
|
((unsigned long long)loc[1] << 8) |
|
|
|
|
((unsigned long long)loc[0] << 0));
|
2010-11-19 23:19:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
qedGetBackingStore(char **res,
|
|
|
|
int *format,
|
|
|
|
const unsigned char *buf,
|
|
|
|
size_t buf_size)
|
|
|
|
{
|
|
|
|
unsigned long long flags;
|
|
|
|
unsigned long offset, size;
|
|
|
|
|
|
|
|
*res = NULL;
|
|
|
|
/* Check if this image has a backing file */
|
|
|
|
if (buf_size < QED_HDR_FEATURES_OFFSET+8)
|
|
|
|
return BACKING_STORE_INVALID;
|
|
|
|
flags = qedGetHeaderULL(buf + QED_HDR_FEATURES_OFFSET);
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (!(flags & QED_F_BACKING_FILE)) {
|
|
|
|
*format = VIR_STORAGE_FILE_NONE;
|
2010-11-19 23:19:24 +00:00
|
|
|
return BACKING_STORE_OK;
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
}
|
2010-11-19 23:19:24 +00:00
|
|
|
|
|
|
|
/* Parse the backing file */
|
|
|
|
if (buf_size < QED_HDR_BACKING_FILE_OFFSET+8)
|
|
|
|
return BACKING_STORE_INVALID;
|
|
|
|
offset = qedGetHeaderUL(buf + QED_HDR_BACKING_FILE_OFFSET);
|
|
|
|
if (offset > buf_size)
|
|
|
|
return BACKING_STORE_INVALID;
|
|
|
|
size = qedGetHeaderUL(buf + QED_HDR_BACKING_FILE_SIZE);
|
|
|
|
if (size == 0)
|
|
|
|
return BACKING_STORE_OK;
|
|
|
|
if (offset + size > buf_size || offset + size < offset)
|
|
|
|
return BACKING_STORE_INVALID;
|
|
|
|
if (VIR_ALLOC_N(*res, size + 1) < 0) {
|
|
|
|
virReportOOMError();
|
|
|
|
return BACKING_STORE_ERROR;
|
|
|
|
}
|
|
|
|
memcpy(*res, buf + offset, size);
|
|
|
|
(*res)[size] = '\0';
|
|
|
|
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (flags & QED_F_BACKING_FORMAT_NO_PROBE)
|
|
|
|
*format = VIR_STORAGE_FILE_RAW;
|
|
|
|
else
|
|
|
|
*format = VIR_STORAGE_FILE_AUTO_SAFE;
|
2010-11-19 23:19:24 +00:00
|
|
|
|
|
|
|
return BACKING_STORE_OK;
|
|
|
|
}
|
|
|
|
|
2009-09-29 08:34:48 +00:00
|
|
|
/**
|
|
|
|
* Return an absolute path corresponding to PATH, which is absolute or relative
|
|
|
|
* to the directory containing BASE_FILE, or NULL on error
|
|
|
|
*/
|
|
|
|
static char *
|
|
|
|
absolutePathFromBaseFile(const char *base_file, const char *path)
|
|
|
|
{
|
2012-10-31 10:17:41 +00:00
|
|
|
char *res = NULL;
|
|
|
|
char *tmp = NULL;
|
|
|
|
size_t d_len = dir_len(base_file);
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-02-04 15:55:57 +00:00
|
|
|
/* If path is already absolute, or if dirname(base_file) is ".",
|
|
|
|
just return a copy of path. */
|
2012-10-31 10:17:41 +00:00
|
|
|
if (*path == '/' || d_len == 0) {
|
|
|
|
if (!(res = canonicalize_file_name(path)))
|
|
|
|
virReportSystemError(errno,
|
|
|
|
_("Can't canonicalize path '%s'"), path);
|
|
|
|
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-02-05 13:57:35 +00:00
|
|
|
/* Ensure that the following cast-to-int is valid. */
|
2012-10-31 10:17:41 +00:00
|
|
|
if (d_len > INT_MAX) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Directory name too long: '%s'"), base_file);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2010-02-05 13:57:35 +00:00
|
|
|
|
2012-10-31 10:17:41 +00:00
|
|
|
if (virAsprintf(&tmp, "%.*s/%s", (int) d_len, base_file, path) < 0) {
|
|
|
|
virReportOOMError();
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(res = canonicalize_file_name(tmp)))
|
|
|
|
virReportSystemError(errno, _("Can't canonicalize path '%s'"), path);
|
|
|
|
|
|
|
|
cleanup:
|
2012-10-09 23:47:42 +00:00
|
|
|
VIR_FREE(tmp);
|
2009-09-29 08:34:48 +00:00
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
static bool
|
|
|
|
virStorageFileMatchesMagic(int format,
|
|
|
|
unsigned char *buf,
|
|
|
|
size_t buflen)
|
2009-09-29 08:34:48 +00:00
|
|
|
{
|
2010-06-15 13:58:10 +00:00
|
|
|
int mlen;
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (fileTypeInfo[format].magic == NULL)
|
|
|
|
return false;
|
2010-05-18 05:53:31 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
/* Validate magic data */
|
|
|
|
mlen = strlen(fileTypeInfo[format].magic);
|
|
|
|
if (mlen > buflen)
|
|
|
|
return false;
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (memcmp(buf, fileTypeInfo[format].magic, mlen) != 0)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
virStorageFileMatchesExtension(int format,
|
|
|
|
const char *path)
|
|
|
|
{
|
|
|
|
if (fileTypeInfo[format].extension == NULL)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (virFileHasSuffix(path, fileTypeInfo[format].extension))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
virStorageFileMatchesVersion(int format,
|
|
|
|
unsigned char *buf,
|
|
|
|
size_t buflen)
|
|
|
|
{
|
|
|
|
int version;
|
|
|
|
|
|
|
|
/* Validate version number info */
|
|
|
|
if (fileTypeInfo[format].versionOffset == -1)
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
return false;
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
if ((fileTypeInfo[format].versionOffset + 4) > buflen)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (fileTypeInfo[format].endian == LV_LITTLE_ENDIAN) {
|
|
|
|
version =
|
|
|
|
(buf[fileTypeInfo[format].versionOffset+3] << 24) |
|
|
|
|
(buf[fileTypeInfo[format].versionOffset+2] << 16) |
|
|
|
|
(buf[fileTypeInfo[format].versionOffset+1] << 8) |
|
|
|
|
(buf[fileTypeInfo[format].versionOffset]);
|
|
|
|
} else {
|
|
|
|
version =
|
|
|
|
(buf[fileTypeInfo[format].versionOffset] << 24) |
|
|
|
|
(buf[fileTypeInfo[format].versionOffset+1] << 16) |
|
|
|
|
(buf[fileTypeInfo[format].versionOffset+2] << 8) |
|
|
|
|
(buf[fileTypeInfo[format].versionOffset+3]);
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
if (version != fileTypeInfo[format].versionNumber)
|
|
|
|
return false;
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
return true;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-11-03 15:50:11 +00:00
|
|
|
static bool
|
|
|
|
virBackingStoreIsFile(const char *backing)
|
|
|
|
{
|
2012-08-08 21:02:24 +00:00
|
|
|
/* Backing store is a network block device or Rados block device */
|
|
|
|
if (STRPREFIX(backing, "nbd:") || STRPREFIX(backing, "rbd:"))
|
2010-11-03 15:50:11 +00:00
|
|
|
return false;
|
|
|
|
return true;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
static int
|
|
|
|
virStorageFileGetMetadataFromBuf(int format,
|
|
|
|
const char *path,
|
|
|
|
unsigned char *buf,
|
|
|
|
size_t buflen,
|
|
|
|
virStorageFileMetadata *meta)
|
|
|
|
{
|
|
|
|
/* XXX we should consider moving virStorageBackendUpdateVolInfo
|
|
|
|
* code into this method, for non-magic files
|
|
|
|
*/
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (format <= VIR_STORAGE_FILE_NONE ||
|
|
|
|
format >= VIR_STORAGE_FILE_LAST ||
|
|
|
|
!fileTypeInfo[format].magic) {
|
2010-06-15 13:58:10 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
/* Optionally extract capacity from file */
|
|
|
|
if (fileTypeInfo[format].sizeOffset != -1) {
|
|
|
|
if ((fileTypeInfo[format].sizeOffset + 8) > buflen)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (fileTypeInfo[format].endian == LV_LITTLE_ENDIAN) {
|
|
|
|
meta->capacity =
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+7] << 56) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+6] << 48) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+5] << 40) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+4] << 32) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+3] << 24) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+2] << 16) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+1] << 8) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset]);
|
|
|
|
} else {
|
|
|
|
meta->capacity =
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset] << 56) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+1] << 48) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+2] << 40) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+3] << 32) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+4] << 24) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+5] << 16) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+6] << 8) |
|
|
|
|
((unsigned long long)buf[fileTypeInfo[format].sizeOffset+7]);
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
/* Avoid unlikely, but theoretically possible overflow */
|
|
|
|
if (meta->capacity > (ULLONG_MAX / fileTypeInfo[format].sizeMultiplier))
|
|
|
|
return 1;
|
|
|
|
meta->capacity *= fileTypeInfo[format].sizeMultiplier;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (fileTypeInfo[format].qcowCryptOffset != -1) {
|
|
|
|
int crypt_format;
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
crypt_format =
|
|
|
|
(buf[fileTypeInfo[format].qcowCryptOffset] << 24) |
|
|
|
|
(buf[fileTypeInfo[format].qcowCryptOffset+1] << 16) |
|
|
|
|
(buf[fileTypeInfo[format].qcowCryptOffset+2] << 8) |
|
|
|
|
(buf[fileTypeInfo[format].qcowCryptOffset+3]);
|
|
|
|
meta->encrypted = crypt_format != 0;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (fileTypeInfo[format].getBackingStore != NULL) {
|
|
|
|
char *backing;
|
|
|
|
int backingFormat;
|
|
|
|
int ret = fileTypeInfo[format].getBackingStore(&backing,
|
|
|
|
&backingFormat,
|
|
|
|
buf, buflen);
|
|
|
|
if (ret == BACKING_STORE_INVALID)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (ret == BACKING_STORE_ERROR)
|
|
|
|
return -1;
|
|
|
|
|
2010-11-03 15:50:11 +00:00
|
|
|
meta->backingStoreIsFile = false;
|
2010-06-15 13:58:10 +00:00
|
|
|
if (backing != NULL) {
|
2012-10-09 23:47:42 +00:00
|
|
|
meta->backingStore = strdup(backing);
|
|
|
|
if (meta->backingStore == NULL) {
|
|
|
|
virReportOOMError();
|
|
|
|
VIR_FREE(backing);
|
|
|
|
return -1;
|
|
|
|
}
|
2010-11-03 15:50:11 +00:00
|
|
|
if (virBackingStoreIsFile(backing)) {
|
|
|
|
meta->backingStoreIsFile = true;
|
2012-10-09 23:47:42 +00:00
|
|
|
meta->backingStoreRaw = meta->backingStore;
|
2010-11-03 15:50:11 +00:00
|
|
|
meta->backingStore = absolutePathFromBaseFile(path, backing);
|
2012-10-09 23:47:42 +00:00
|
|
|
if (meta->backingStore == NULL) {
|
|
|
|
VIR_FREE(backing);
|
|
|
|
return -1;
|
|
|
|
}
|
2010-11-03 15:50:11 +00:00
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
VIR_FREE(backing);
|
|
|
|
meta->backingStoreFormat = backingFormat;
|
|
|
|
} else {
|
|
|
|
meta->backingStore = NULL;
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
meta->backingStoreFormat = VIR_STORAGE_FILE_NONE;
|
2010-06-15 13:58:10 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
virStorageFileProbeFormatFromBuf(const char *path,
|
|
|
|
unsigned char *buf,
|
|
|
|
size_t buflen)
|
|
|
|
{
|
|
|
|
int format = VIR_STORAGE_FILE_RAW;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* First check file magic */
|
|
|
|
for (i = 0 ; i < VIR_STORAGE_FILE_LAST ; i++) {
|
|
|
|
if (virStorageFileMatchesMagic(i, buf, buflen) &&
|
|
|
|
virStorageFileMatchesVersion(i, buf, buflen)) {
|
|
|
|
format = i;
|
|
|
|
goto cleanup;
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* No magic, so check file extension */
|
2010-06-15 13:58:10 +00:00
|
|
|
for (i = 0 ; i < VIR_STORAGE_FILE_LAST ; i++) {
|
|
|
|
if (virStorageFileMatchesExtension(i, path)) {
|
|
|
|
format = i;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
cleanup:
|
|
|
|
return format;
|
|
|
|
}
|
2009-09-29 08:34:48 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* virStorageFileProbeFormatFromFD:
|
|
|
|
*
|
|
|
|
* Probe for the format of 'fd' (which is an open file descriptor
|
|
|
|
* pointing to 'path'), returning the detected disk format.
|
|
|
|
*
|
|
|
|
* Callers are advised never to trust the returned 'format'
|
|
|
|
* unless it is listed as VIR_STORAGE_FILE_RAW, since a
|
|
|
|
* malicious guest can turn a file into any other non-raw
|
|
|
|
* format at will.
|
|
|
|
*
|
|
|
|
* Best option: Don't use this function
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
virStorageFileProbeFormatFromFD(const char *path, int fd)
|
|
|
|
{
|
|
|
|
unsigned char *head;
|
|
|
|
ssize_t len = STORAGE_MAX_HEAD;
|
|
|
|
int ret = -1;
|
2011-05-26 18:05:32 +00:00
|
|
|
struct stat sb;
|
|
|
|
|
|
|
|
if (fstat(fd, &sb) < 0) {
|
|
|
|
virReportSystemError(errno,
|
|
|
|
_("cannot stat file '%s'"),
|
|
|
|
path);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* No header to probe for directories */
|
|
|
|
if (S_ISDIR(sb.st_mode)) {
|
|
|
|
return VIR_STORAGE_FILE_DIR;
|
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
if (VIR_ALLOC_N(head, len) < 0) {
|
|
|
|
virReportOOMError();
|
|
|
|
return -1;
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (lseek(fd, 0, SEEK_SET) == (off_t)-1) {
|
|
|
|
virReportSystemError(errno, _("cannot set to start of '%s'"), path);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((len = read(fd, head, len)) < 0) {
|
|
|
|
virReportSystemError(errno, _("cannot read header '%s'"), path);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = virStorageFileProbeFormatFromBuf(path, head, len);
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
VIR_FREE(head);
|
|
|
|
return ret;
|
2009-09-29 08:34:48 +00:00
|
|
|
}
|
2009-09-29 08:41:23 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* virStorageFileProbeFormat:
|
|
|
|
*
|
|
|
|
* Probe for the format of 'path', returning the detected
|
|
|
|
* disk format.
|
|
|
|
*
|
|
|
|
* Callers are advised never to trust the returned 'format'
|
|
|
|
* unless it is listed as VIR_STORAGE_FILE_RAW, since a
|
|
|
|
* malicious guest can turn a raw file into any other non-raw
|
|
|
|
* format at will.
|
|
|
|
*
|
|
|
|
* Best option: Don't use this function
|
|
|
|
*/
|
|
|
|
int
|
2012-10-20 19:56:35 +00:00
|
|
|
virStorageFileProbeFormat(const char *path, uid_t uid, gid_t gid)
|
2010-06-15 13:58:10 +00:00
|
|
|
{
|
|
|
|
int fd, ret;
|
|
|
|
|
2012-10-20 19:56:35 +00:00
|
|
|
if ((fd = virFileOpenAs(path, O_RDONLY, 0, uid, gid, 0)) < 0) {
|
2010-06-15 13:58:10 +00:00
|
|
|
virReportSystemError(errno, _("cannot open file '%s'"), path);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = virStorageFileProbeFormatFromFD(path, fd);
|
|
|
|
|
2010-11-09 20:48:48 +00:00
|
|
|
VIR_FORCE_CLOSE(fd);
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* virStorageFileGetMetadataFromFD:
|
|
|
|
*
|
2010-06-15 15:15:51 +00:00
|
|
|
* Extract metadata about the storage volume with the specified
|
|
|
|
* image format. If image format is VIR_STORAGE_FILE_AUTO, it
|
2012-10-13 16:47:15 +00:00
|
|
|
* will probe to automatically identify the format. Does not recurse.
|
2010-06-15 13:58:10 +00:00
|
|
|
*
|
2010-06-15 15:15:51 +00:00
|
|
|
* Callers are advised never to use VIR_STORAGE_FILE_AUTO as a
|
|
|
|
* format, since a malicious guest can turn a raw file into any
|
|
|
|
* other non-raw format at will.
|
|
|
|
*
|
|
|
|
* If the returned meta.backingStoreFormat is VIR_STORAGE_FILE_AUTO
|
|
|
|
* it indicates the image didn't specify an explicit format for its
|
|
|
|
* backing store. Callers are advised against probing for the
|
|
|
|
* backing store format in this case.
|
2011-07-14 10:53:45 +00:00
|
|
|
*
|
2012-10-13 17:01:27 +00:00
|
|
|
* Caller MUST free the result after use via virStorageFileFreeMetadata.
|
2010-06-15 13:58:10 +00:00
|
|
|
*/
|
2012-10-13 17:01:27 +00:00
|
|
|
virStorageFileMetadataPtr
|
2010-06-15 13:58:10 +00:00
|
|
|
virStorageFileGetMetadataFromFD(const char *path,
|
|
|
|
int fd,
|
2012-10-13 17:01:27 +00:00
|
|
|
int format)
|
2010-06-15 13:58:10 +00:00
|
|
|
{
|
2012-10-13 17:01:27 +00:00
|
|
|
virStorageFileMetadata *meta = NULL;
|
2011-05-26 18:05:32 +00:00
|
|
|
unsigned char *head = NULL;
|
2010-06-15 13:58:10 +00:00
|
|
|
ssize_t len = STORAGE_MAX_HEAD;
|
2012-10-13 17:01:27 +00:00
|
|
|
virStorageFileMetadata *ret = NULL;
|
2011-05-26 18:05:32 +00:00
|
|
|
struct stat sb;
|
2010-06-15 13:58:10 +00:00
|
|
|
|
2012-10-13 17:01:27 +00:00
|
|
|
if (VIR_ALLOC(meta) < 0) {
|
|
|
|
virReportOOMError();
|
|
|
|
return NULL;
|
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
|
2011-05-26 18:05:32 +00:00
|
|
|
if (fstat(fd, &sb) < 0) {
|
|
|
|
virReportSystemError(errno,
|
|
|
|
_("cannot stat file '%s'"),
|
|
|
|
path);
|
2012-10-13 17:01:27 +00:00
|
|
|
goto cleanup;
|
2011-05-26 18:05:32 +00:00
|
|
|
}
|
|
|
|
|
2012-10-13 17:01:27 +00:00
|
|
|
/* No header to probe for directories, but also no backing file */
|
|
|
|
if (S_ISDIR(sb.st_mode))
|
|
|
|
return meta;
|
2011-05-26 18:05:32 +00:00
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
if (lseek(fd, 0, SEEK_SET) == (off_t)-1) {
|
2011-02-24 07:06:03 +00:00
|
|
|
virReportSystemError(errno, _("cannot seek to start of '%s'"), path);
|
2012-10-13 17:01:27 +00:00
|
|
|
goto cleanup;
|
2011-06-02 22:27:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (VIR_ALLOC_N(head, len) < 0) {
|
|
|
|
virReportOOMError();
|
2012-10-13 17:01:27 +00:00
|
|
|
goto cleanup;
|
2010-06-15 13:58:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if ((len = read(fd, head, len)) < 0) {
|
|
|
|
virReportSystemError(errno, _("cannot read header '%s'"), path);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2010-06-15 15:15:51 +00:00
|
|
|
if (format == VIR_STORAGE_FILE_AUTO)
|
|
|
|
format = virStorageFileProbeFormatFromBuf(path, head, len);
|
|
|
|
|
storage: list more file types
When an image has no backing file, using VIR_STORAGE_FILE_AUTO
for its type is a bit confusing. Additionally, a future patch
would like to reserve a default value for the case of no file
type specified in the XML, but different from the current use
of -1 to imply probing, since probing is not always safe.
Also, a couple of file types were missing compared to supported
code: libxl supports 'vhd', and qemu supports 'fat' for directories
passed through as a file system.
* src/util/storage_file.h (virStorageFileFormat): Add
VIR_STORAGE_FILE_NONE, VIR_STORAGE_FILE_FAT, VIR_STORAGE_FILE_VHD.
* src/util/storage_file.c (virStorageFileMatchesVersion): Match
documentation when version probing not supported.
(cowGetBackingStore, qcowXGetBackingStore, qcow1GetBackingStore)
(qcow2GetBackingStoreFormat, qedGetBackingStore)
(virStorageFileGetMetadataFromBuf)
(virStorageFileGetMetadataFromFD): Take NONE into account.
* src/conf/domain_conf.c (virDomainDiskDefForeachPath): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Likewise.
* src/conf/storage_conf.c (virStorageVolumeFormatFromString): New
function.
(poolTypeInfo): Use it.
2012-09-28 17:11:07 +00:00
|
|
|
if (format <= VIR_STORAGE_FILE_NONE ||
|
2010-06-15 15:15:51 +00:00
|
|
|
format >= VIR_STORAGE_FILE_LAST) {
|
2011-03-04 16:52:12 +00:00
|
|
|
virReportSystemError(EINVAL, _("unknown storage file format %d"),
|
|
|
|
format);
|
|
|
|
goto cleanup;
|
2010-06-15 15:15:51 +00:00
|
|
|
}
|
2010-06-15 13:58:10 +00:00
|
|
|
|
2012-10-13 17:01:27 +00:00
|
|
|
if (virStorageFileGetMetadataFromBuf(format, path, head, len, meta) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
ret = meta;
|
|
|
|
meta = NULL;
|
2010-06-15 13:58:10 +00:00
|
|
|
|
|
|
|
cleanup:
|
2012-10-13 17:01:27 +00:00
|
|
|
virStorageFileFreeMetadata(meta);
|
2010-06-15 13:58:10 +00:00
|
|
|
VIR_FREE(head);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2012-10-13 16:47:15 +00:00
|
|
|
/* Recursive workhorse for virStorageFileGetMetadata. */
|
|
|
|
static virStorageFileMetadataPtr
|
|
|
|
virStorageFileGetMetadataRecurse(const char *path, int format,
|
|
|
|
uid_t uid, gid_t gid,
|
|
|
|
bool allow_probe, virHashTablePtr cycle)
|
|
|
|
{
|
|
|
|
int fd;
|
|
|
|
virStorageFileMetadataPtr ret = NULL;
|
|
|
|
|
|
|
|
if (virHashLookup(cycle, path)) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("backing store for %s is self-referential"),
|
|
|
|
path);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
if (virHashAddEntry(cycle, path, (void *)1) < 0)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if ((fd = virFileOpenAs(path, O_RDONLY, 0, uid, gid, 0)) < 0) {
|
|
|
|
virReportSystemError(-fd, _("cannot open file '%s'"), path);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2012-10-13 17:01:27 +00:00
|
|
|
ret = virStorageFileGetMetadataFromFD(path, fd, format);
|
2012-10-13 16:47:15 +00:00
|
|
|
|
|
|
|
if (VIR_CLOSE(fd) < 0)
|
|
|
|
VIR_WARN("could not close file %s", path);
|
|
|
|
|
2012-10-13 17:01:27 +00:00
|
|
|
if (ret && ret->backingStoreIsFile) {
|
2012-10-13 16:47:15 +00:00
|
|
|
if (ret->backingStoreFormat == VIR_STORAGE_FILE_AUTO && !allow_probe)
|
|
|
|
ret->backingStoreFormat = VIR_STORAGE_FILE_RAW;
|
|
|
|
else if (ret->backingStoreFormat == VIR_STORAGE_FILE_AUTO_SAFE)
|
|
|
|
ret->backingStoreFormat = VIR_STORAGE_FILE_AUTO;
|
|
|
|
format = ret->backingStoreFormat;
|
|
|
|
ret->backingMeta = virStorageFileGetMetadataRecurse(ret->backingStore,
|
|
|
|
format,
|
|
|
|
uid, gid,
|
|
|
|
allow_probe,
|
|
|
|
cycle);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-06-15 13:58:10 +00:00
|
|
|
/**
|
|
|
|
* virStorageFileGetMetadata:
|
|
|
|
*
|
2010-06-15 15:15:51 +00:00
|
|
|
* Extract metadata about the storage volume with the specified
|
|
|
|
* image format. If image format is VIR_STORAGE_FILE_AUTO, it
|
2012-10-13 16:47:15 +00:00
|
|
|
* will probe to automatically identify the format. Recurses through
|
|
|
|
* the entire chain.
|
|
|
|
*
|
|
|
|
* Open files using UID and GID (or pass -1 for the current user/group).
|
|
|
|
* Treat any backing files without explicit type as raw, unless ALLOW_PROBE.
|
2010-06-15 13:58:10 +00:00
|
|
|
*
|
2010-06-15 15:15:51 +00:00
|
|
|
* Callers are advised never to use VIR_STORAGE_FILE_AUTO as a
|
|
|
|
* format, since a malicious guest can turn a raw file into any
|
|
|
|
* other non-raw format at will.
|
|
|
|
*
|
|
|
|
* If the returned meta.backingStoreFormat is VIR_STORAGE_FILE_AUTO
|
|
|
|
* it indicates the image didn't specify an explicit format for its
|
2012-10-13 16:47:15 +00:00
|
|
|
* backing store. Callers are advised against using ALLOW_PROBE, as
|
|
|
|
* it would probe the backing store format in this case.
|
2011-07-14 10:53:45 +00:00
|
|
|
*
|
2012-10-13 16:47:15 +00:00
|
|
|
* Caller MUST free result after use via virStorageFileFreeMetadata.
|
2010-06-15 13:58:10 +00:00
|
|
|
*/
|
2012-10-13 16:47:15 +00:00
|
|
|
virStorageFileMetadataPtr
|
|
|
|
virStorageFileGetMetadata(const char *path, int format,
|
|
|
|
uid_t uid, gid_t gid,
|
|
|
|
bool allow_probe)
|
2009-09-29 08:41:23 +00:00
|
|
|
{
|
2012-10-13 16:47:15 +00:00
|
|
|
virHashTablePtr cycle = virHashCreate(5, NULL);
|
|
|
|
virStorageFileMetadataPtr ret;
|
2009-09-29 08:41:23 +00:00
|
|
|
|
2012-10-13 16:47:15 +00:00
|
|
|
if (!cycle)
|
|
|
|
return NULL;
|
2009-09-29 08:41:23 +00:00
|
|
|
|
2012-10-13 16:47:15 +00:00
|
|
|
if (format <= VIR_STORAGE_FILE_NONE)
|
|
|
|
format = allow_probe ? VIR_STORAGE_FILE_AUTO : VIR_STORAGE_FILE_RAW;
|
|
|
|
ret = virStorageFileGetMetadataRecurse(path, format, uid, gid,
|
|
|
|
allow_probe, cycle);
|
|
|
|
virHashFree(cycle);
|
2009-09-29 08:41:23 +00:00
|
|
|
return ret;
|
|
|
|
}
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
|
2011-07-14 10:53:45 +00:00
|
|
|
/**
|
|
|
|
* virStorageFileFreeMetadata:
|
|
|
|
*
|
|
|
|
* Free pointers in passed structure and structure itself.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
virStorageFileFreeMetadata(virStorageFileMetadata *meta)
|
|
|
|
{
|
|
|
|
if (!meta)
|
|
|
|
return;
|
|
|
|
|
2012-10-13 16:47:15 +00:00
|
|
|
virStorageFileFreeMetadata(meta->backingMeta);
|
2011-07-14 10:53:45 +00:00
|
|
|
VIR_FREE(meta->backingStore);
|
2012-10-09 23:47:42 +00:00
|
|
|
VIR_FREE(meta->backingStoreRaw);
|
2011-07-14 10:53:45 +00:00
|
|
|
VIR_FREE(meta);
|
|
|
|
}
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
|
2012-01-30 07:40:00 +00:00
|
|
|
/**
|
|
|
|
* virStorageFileResize:
|
|
|
|
*
|
|
|
|
* Change the capacity of the raw storage file at 'path'.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
virStorageFileResize(const char *path, unsigned long long capacity)
|
|
|
|
{
|
2012-02-08 14:03:29 +00:00
|
|
|
int fd = -1;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
if ((fd = open(path, O_RDWR)) < 0) {
|
|
|
|
virReportSystemError(errno, _("Unable to open '%s'"), path);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ftruncate(fd, capacity) < 0) {
|
2012-01-30 07:40:00 +00:00
|
|
|
virReportSystemError(errno, _("Failed to truncate file '%s'"), path);
|
2012-02-08 14:03:29 +00:00
|
|
|
goto cleanup;
|
2012-01-30 07:40:00 +00:00
|
|
|
}
|
|
|
|
|
2012-02-08 14:03:29 +00:00
|
|
|
if (VIR_CLOSE(fd) < 0) {
|
|
|
|
virReportSystemError(errno, _("Unable to save '%s'"), path);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
VIR_FORCE_CLOSE(fd);
|
|
|
|
return ret;
|
2012-01-30 07:40:00 +00:00
|
|
|
}
|
|
|
|
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
#ifdef __linux__
|
|
|
|
|
2010-05-17 14:17:08 +00:00
|
|
|
# ifndef NFS_SUPER_MAGIC
|
|
|
|
# define NFS_SUPER_MAGIC 0x6969
|
|
|
|
# endif
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
# ifndef OCFS2_SUPER_MAGIC
|
|
|
|
# define OCFS2_SUPER_MAGIC 0x7461636f
|
|
|
|
# endif
|
|
|
|
# ifndef GFS2_MAGIC
|
|
|
|
# define GFS2_MAGIC 0x01161970
|
|
|
|
# endif
|
|
|
|
# ifndef AFS_FS_MAGIC
|
|
|
|
# define AFS_FS_MAGIC 0x6B414653
|
|
|
|
# endif
|
|
|
|
|
|
|
|
|
2010-10-29 11:20:40 +00:00
|
|
|
int virStorageFileIsSharedFSType(const char *path,
|
|
|
|
int fstypes)
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
{
|
2010-06-25 16:18:57 +00:00
|
|
|
char *dirpath, *p;
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
struct statfs sb;
|
2010-06-25 16:18:57 +00:00
|
|
|
int statfs_ret;
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
|
2010-06-25 16:18:57 +00:00
|
|
|
if ((dirpath = strdup(path)) == NULL) {
|
|
|
|
virReportOOMError();
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
do {
|
|
|
|
|
|
|
|
/* Try less and less of the path until we get to a
|
|
|
|
* directory we can stat. Even if we don't have 'x'
|
|
|
|
* permission on any directory in the path on the NFS
|
|
|
|
* server (assuming it's NFS), we will be able to stat the
|
|
|
|
* mount point, and that will properly tell us if the
|
|
|
|
* fstype is NFS.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if ((p = strrchr(dirpath, '/')) == NULL) {
|
|
|
|
virReportSystemError(EINVAL,
|
|
|
|
_("Invalid relative path '%s'"), path);
|
|
|
|
VIR_FREE(dirpath);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (p == dirpath)
|
|
|
|
*(p+1) = '\0';
|
|
|
|
else
|
|
|
|
*p = '\0';
|
|
|
|
|
|
|
|
statfs_ret = statfs(dirpath, &sb);
|
|
|
|
|
|
|
|
} while ((statfs_ret < 0) && (p != dirpath));
|
|
|
|
|
|
|
|
VIR_FREE(dirpath);
|
|
|
|
|
|
|
|
if (statfs_ret < 0) {
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
virReportSystemError(errno,
|
|
|
|
_("cannot determine filesystem for '%s'"),
|
|
|
|
path);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_DEBUG("Check if path %s with FS magic %lld is shared",
|
|
|
|
path, (long long int)sb.f_type);
|
|
|
|
|
2010-10-29 11:20:40 +00:00
|
|
|
if ((fstypes & VIR_STORAGE_FILE_SHFS_NFS) &&
|
|
|
|
(sb.f_type == NFS_SUPER_MAGIC))
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
if ((fstypes & VIR_STORAGE_FILE_SHFS_GFS2) &&
|
|
|
|
(sb.f_type == GFS2_MAGIC))
|
|
|
|
return 1;
|
|
|
|
if ((fstypes & VIR_STORAGE_FILE_SHFS_OCFS) &&
|
|
|
|
(sb.f_type == OCFS2_SUPER_MAGIC))
|
|
|
|
return 1;
|
|
|
|
if ((fstypes & VIR_STORAGE_FILE_SHFS_AFS) &&
|
|
|
|
(sb.f_type == AFS_FS_MAGIC))
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#else
|
2010-10-29 11:20:40 +00:00
|
|
|
int virStorageFileIsSharedFSType(const char *path ATTRIBUTE_UNUSED,
|
|
|
|
int fstypes ATTRIBUTE_UNUSED)
|
Don't reset user/group/security label on shared filesystems during migrate
When QEMU runs with its disk on NFS, and as a non-root user, the
disk is chownd to that non-root user. When migration completes
the last step is shutting down the QEMU on the source host. THis
normally resets user/group/security label. This is bad when the
VM was just migrated because the file is still in use on the dest
host. It is thus neccessary to skip the reset step for any files
found to be on a shared filesystem
* src/libvirt_private.syms: Export virStorageFileIsSharedFS
* src/util/storage_file.c, src/util/storage_file.h: Add a new
method virStorageFileIsSharedFS() to determine if a file is
on a shared filesystem (NFS, GFS, OCFS2, etc)
* src/qemu/qemu_driver.c: Tell security driver not to reset
disk labels on migration completion
* src/qemu/qemu_security_dac.c, src/qemu/qemu_security_stacked.c,
src/security/security_selinux.c, src/security/security_driver.h,
src/security/security_apparmor.c: Add ability to skip disk
restore step for files on shared filesystems.
2010-05-13 15:49:22 +00:00
|
|
|
{
|
|
|
|
/* XXX implement me :-) */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
2010-10-29 11:20:40 +00:00
|
|
|
|
|
|
|
int virStorageFileIsSharedFS(const char *path)
|
|
|
|
{
|
|
|
|
return virStorageFileIsSharedFSType(path,
|
|
|
|
VIR_STORAGE_FILE_SHFS_NFS |
|
|
|
|
VIR_STORAGE_FILE_SHFS_GFS2 |
|
|
|
|
VIR_STORAGE_FILE_SHFS_OCFS |
|
|
|
|
VIR_STORAGE_FILE_SHFS_AFS);
|
|
|
|
}
|
2012-02-21 21:58:50 +00:00
|
|
|
|
|
|
|
int virStorageFileIsClusterFS(const char *path)
|
|
|
|
{
|
|
|
|
/* These are coherent cluster filesystems known to be safe for
|
|
|
|
* migration with cache != none
|
|
|
|
*/
|
|
|
|
return virStorageFileIsSharedFSType(path,
|
|
|
|
VIR_STORAGE_FILE_SHFS_GFS2 |
|
|
|
|
VIR_STORAGE_FILE_SHFS_OCFS);
|
|
|
|
}
|
2011-07-20 09:40:53 +00:00
|
|
|
|
|
|
|
#ifdef LVS
|
|
|
|
const char *virStorageFileGetLVMKey(const char *path)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* # lvs --noheadings --unbuffered --nosuffix --options "uuid" LVNAME
|
|
|
|
* 06UgP5-2rhb-w3Bo-3mdR-WeoL-pytO-SAa2ky
|
|
|
|
*/
|
|
|
|
char *key = NULL;
|
|
|
|
virCommandPtr cmd = virCommandNewArgList(
|
|
|
|
LVS,
|
|
|
|
"--noheadings", "--unbuffered", "--nosuffix",
|
|
|
|
"--options", "uuid", path,
|
|
|
|
NULL
|
|
|
|
);
|
|
|
|
|
|
|
|
/* Run the program and capture its output */
|
|
|
|
virCommandSetOutputBuffer(cmd, &key);
|
|
|
|
if (virCommandRun(cmd, NULL) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (key) {
|
|
|
|
char *nl;
|
|
|
|
char *tmp = key;
|
|
|
|
|
|
|
|
/* Find first non-space character */
|
|
|
|
while (*tmp && c_isspace(*tmp)) {
|
|
|
|
tmp++;
|
|
|
|
}
|
|
|
|
/* Kill leading spaces */
|
|
|
|
if (tmp != key)
|
|
|
|
memmove(key, tmp, strlen(tmp)+1);
|
|
|
|
|
|
|
|
/* Kill trailing newline */
|
|
|
|
if ((nl = strchr(key, '\n')))
|
|
|
|
*nl = '\0';
|
|
|
|
}
|
|
|
|
|
|
|
|
if (key && STREQ(key, ""))
|
|
|
|
VIR_FREE(key);
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
virCommandFree(cmd);
|
|
|
|
|
|
|
|
return key;
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
const char *virStorageFileGetLVMKey(const char *path)
|
|
|
|
{
|
|
|
|
virReportSystemError(ENOSYS, _("Unable to get LVM key for %s"), path);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef HAVE_UDEV
|
|
|
|
const char *virStorageFileGetSCSIKey(const char *path)
|
|
|
|
{
|
|
|
|
char *key = NULL;
|
|
|
|
virCommandPtr cmd = virCommandNewArgList(
|
|
|
|
"/lib/udev/scsi_id",
|
|
|
|
"--replace-whitespace",
|
|
|
|
"--whitelisted",
|
|
|
|
"--device", path,
|
|
|
|
NULL
|
|
|
|
);
|
|
|
|
|
|
|
|
/* Run the program and capture its output */
|
|
|
|
virCommandSetOutputBuffer(cmd, &key);
|
|
|
|
if (virCommandRun(cmd, NULL) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (key && STRNEQ(key, "")) {
|
|
|
|
char *nl = strchr(key, '\n');
|
|
|
|
if (nl)
|
|
|
|
*nl = '\0';
|
|
|
|
} else {
|
|
|
|
VIR_FREE(key);
|
|
|
|
}
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
virCommandFree(cmd);
|
|
|
|
|
|
|
|
return key;
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
const char *virStorageFileGetSCSIKey(const char *path)
|
|
|
|
{
|
|
|
|
virReportSystemError(ENOSYS, _("Unable to get SCSI key for %s"), path);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
#endif
|
2012-10-12 22:29:14 +00:00
|
|
|
|
|
|
|
/* Given a CHAIN that starts at the named file START, return a string
|
|
|
|
* pointing to either START or within CHAIN that gives the preferred
|
|
|
|
* name for the backing file NAME within that chain. Pass NULL for
|
|
|
|
* NAME to find the base of the chain. If META is not NULL, set *META
|
|
|
|
* to the point in the chain that describes NAME (or to NULL if the
|
|
|
|
* backing element is not a file). If PARENT is not NULL, set *PARENT
|
|
|
|
* to the preferred name of the parent (or to NULL if NAME matches
|
|
|
|
* START). Since the results point within CHAIN, they must not be
|
|
|
|
* independently freed. */
|
|
|
|
const char *
|
|
|
|
virStorageFileChainLookup(virStorageFileMetadataPtr chain, const char *start,
|
|
|
|
const char *name, virStorageFileMetadataPtr *meta,
|
|
|
|
const char **parent)
|
|
|
|
{
|
|
|
|
virStorageFileMetadataPtr owner;
|
|
|
|
const char *tmp;
|
|
|
|
|
|
|
|
if (!parent)
|
|
|
|
parent = &tmp;
|
|
|
|
|
|
|
|
*parent = NULL;
|
|
|
|
if (name ? STREQ(start, name) || virFileLinkPointsTo(start, name) :
|
|
|
|
!chain->backingStore) {
|
|
|
|
if (meta)
|
|
|
|
*meta = chain;
|
|
|
|
return start;
|
|
|
|
}
|
|
|
|
|
|
|
|
owner = chain;
|
|
|
|
*parent = start;
|
|
|
|
while (owner) {
|
|
|
|
if (!owner->backingStore)
|
|
|
|
goto error;
|
|
|
|
if (!name) {
|
|
|
|
if (!owner->backingMeta ||
|
|
|
|
!owner->backingMeta->backingStore)
|
|
|
|
break;
|
|
|
|
} else if (STREQ_NULLABLE(name, owner->backingStoreRaw) ||
|
|
|
|
STREQ(name, owner->backingStore)) {
|
|
|
|
break;
|
|
|
|
} else if (owner->backingStoreIsFile) {
|
|
|
|
char *absName = absolutePathFromBaseFile(*parent, name);
|
|
|
|
if (absName && STREQ(absName, owner->backingStore)) {
|
|
|
|
VIR_FREE(absName);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
VIR_FREE(absName);
|
|
|
|
}
|
|
|
|
*parent = owner->backingStore;
|
|
|
|
owner = owner->backingMeta;
|
|
|
|
}
|
|
|
|
if (!owner)
|
|
|
|
goto error;
|
|
|
|
if (meta)
|
|
|
|
*meta = owner->backingMeta;
|
|
|
|
return owner->backingStore;
|
|
|
|
|
|
|
|
error:
|
|
|
|
*parent = NULL;
|
|
|
|
if (meta)
|
|
|
|
*meta = NULL;
|
|
|
|
return NULL;
|
|
|
|
}
|