2013-12-11 10:37:58 +00:00
|
|
|
/*
|
|
|
|
* network_event.c: network event queue processing helpers
|
|
|
|
*
|
2014-01-02 14:16:49 +00:00
|
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
2013-12-11 10:37:58 +00:00
|
|
|
* Copyright (C) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library. If not, see
|
|
|
|
* <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
|
|
#include "network_event.h"
|
|
|
|
#include "object_event.h"
|
|
|
|
#include "object_event_private.h"
|
|
|
|
#include "datatypes.h"
|
|
|
|
#include "virlog.h"
|
|
|
|
|
2014-02-28 12:16:17 +00:00
|
|
|
VIR_LOG_INIT("conf.network_event");
|
|
|
|
|
2013-12-11 14:09:01 +00:00
|
|
|
struct _virNetworkEvent {
|
2013-12-11 10:37:58 +00:00
|
|
|
virObjectEvent parent;
|
|
|
|
|
2014-01-02 14:16:49 +00:00
|
|
|
/* Unused attribute to allow for subclass creation */
|
2013-12-11 14:09:01 +00:00
|
|
|
bool dummy;
|
|
|
|
};
|
|
|
|
typedef struct _virNetworkEvent virNetworkEvent;
|
|
|
|
typedef virNetworkEvent *virNetworkEventPtr;
|
|
|
|
|
|
|
|
struct _virNetworkEventLifecycle {
|
|
|
|
virNetworkEvent parent;
|
|
|
|
|
2013-12-11 10:37:58 +00:00
|
|
|
int type;
|
2013-12-11 13:40:41 +00:00
|
|
|
int detail;
|
2013-12-11 10:37:58 +00:00
|
|
|
};
|
|
|
|
typedef struct _virNetworkEventLifecycle virNetworkEventLifecycle;
|
|
|
|
typedef virNetworkEventLifecycle *virNetworkEventLifecyclePtr;
|
|
|
|
|
2013-12-11 14:09:01 +00:00
|
|
|
static virClassPtr virNetworkEventClass;
|
2013-12-11 10:37:58 +00:00
|
|
|
static virClassPtr virNetworkEventLifecycleClass;
|
2013-12-11 14:09:01 +00:00
|
|
|
static void virNetworkEventDispose(void *obj);
|
2013-12-11 10:37:58 +00:00
|
|
|
static void virNetworkEventLifecycleDispose(void *obj);
|
|
|
|
|
|
|
|
static int
|
|
|
|
virNetworkEventsOnceInit(void)
|
|
|
|
{
|
2018-04-17 15:42:33 +00:00
|
|
|
if (!VIR_CLASS_NEW(virNetworkEvent, virClassForObjectEvent()))
|
2013-12-11 14:09:01 +00:00
|
|
|
return -1;
|
2018-04-17 15:42:33 +00:00
|
|
|
|
|
|
|
if (!VIR_CLASS_NEW(virNetworkEventLifecycle, virNetworkEventClass))
|
2013-12-11 10:37:58 +00:00
|
|
|
return -1;
|
2018-04-17 15:42:33 +00:00
|
|
|
|
2013-12-11 10:37:58 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-01-20 17:23:29 +00:00
|
|
|
VIR_ONCE_GLOBAL_INIT(virNetworkEvents);
|
2013-12-11 10:37:58 +00:00
|
|
|
|
2014-01-02 14:16:49 +00:00
|
|
|
static void
|
2013-12-11 14:09:01 +00:00
|
|
|
virNetworkEventDispose(void *obj)
|
|
|
|
{
|
|
|
|
virNetworkEventPtr event = obj;
|
|
|
|
VIR_DEBUG("obj=%p", event);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-01-02 14:16:49 +00:00
|
|
|
static void
|
2013-12-11 10:37:58 +00:00
|
|
|
virNetworkEventLifecycleDispose(void *obj)
|
|
|
|
{
|
|
|
|
virNetworkEventLifecyclePtr event = obj;
|
|
|
|
VIR_DEBUG("obj=%p", event);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-12-12 17:47:42 +00:00
|
|
|
static void
|
2013-12-11 10:37:58 +00:00
|
|
|
virNetworkEventDispatchDefaultFunc(virConnectPtr conn,
|
|
|
|
virObjectEventPtr event,
|
2013-12-12 17:47:42 +00:00
|
|
|
virConnectObjectEventGenericCallback cb,
|
|
|
|
void *cbopaque)
|
2013-12-11 10:37:58 +00:00
|
|
|
{
|
|
|
|
virNetworkPtr net = virGetNetwork(conn, event->meta.name, event->meta.uuid);
|
|
|
|
if (!net)
|
|
|
|
return;
|
|
|
|
|
2013-12-11 14:10:34 +00:00
|
|
|
switch ((virNetworkEventID)event->eventID) {
|
2013-12-11 10:37:58 +00:00
|
|
|
case VIR_NETWORK_EVENT_ID_LIFECYCLE:
|
|
|
|
{
|
|
|
|
virNetworkEventLifecyclePtr networkLifecycleEvent;
|
|
|
|
|
|
|
|
networkLifecycleEvent = (virNetworkEventLifecyclePtr)event;
|
|
|
|
((virConnectNetworkEventLifecycleCallback)cb)(conn, net,
|
|
|
|
networkLifecycleEvent->type,
|
2013-12-11 13:40:41 +00:00
|
|
|
networkLifecycleEvent->detail,
|
2013-12-11 10:37:58 +00:00
|
|
|
cbopaque);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
case VIR_NETWORK_EVENT_ID_LAST:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
VIR_WARN("Unexpected event ID %d", event->eventID);
|
|
|
|
|
2014-03-25 06:48:31 +00:00
|
|
|
cleanup:
|
2014-11-25 12:42:58 +00:00
|
|
|
virObjectUnref(net);
|
2013-12-11 10:37:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* virNetworkEventStateRegisterID:
|
|
|
|
* @conn: connection to associate with callback
|
|
|
|
* @state: object event state
|
|
|
|
* @net: network to filter on or NULL for all networks
|
|
|
|
* @eventID: ID of the event type to register for
|
2014-01-02 14:16:49 +00:00
|
|
|
* @cb: function to invoke when event occurs
|
|
|
|
* @opaque: data blob to pass to @callback
|
2013-12-11 10:37:58 +00:00
|
|
|
* @freecb: callback to free @opaque
|
|
|
|
* @callbackID: filled with callback ID
|
|
|
|
*
|
2014-01-02 14:16:49 +00:00
|
|
|
* Register the function @cb with connection @conn, from @state, for
|
|
|
|
* events of type @eventID, and return the registration handle in
|
|
|
|
* @callbackID.
|
2013-12-11 10:37:58 +00:00
|
|
|
*
|
|
|
|
* Returns: the number of callbacks now registered, or -1 on error
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
virNetworkEventStateRegisterID(virConnectPtr conn,
|
|
|
|
virObjectEventStatePtr state,
|
|
|
|
virNetworkPtr net,
|
|
|
|
int eventID,
|
2014-01-04 22:12:34 +00:00
|
|
|
virConnectNetworkEventGenericCallback cb,
|
2013-12-11 10:37:58 +00:00
|
|
|
void *opaque,
|
|
|
|
virFreeCallback freecb,
|
|
|
|
int *callbackID)
|
|
|
|
{
|
2016-06-23 15:50:05 +00:00
|
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
|
|
|
|
2013-12-11 14:10:34 +00:00
|
|
|
if (virNetworkEventsInitialize() < 0)
|
|
|
|
return -1;
|
|
|
|
|
2016-06-23 15:50:05 +00:00
|
|
|
if (net)
|
|
|
|
virUUIDFormat(net->uuid, uuidstr);
|
|
|
|
return virObjectEventStateRegisterID(conn, state, net ? uuidstr : NULL,
|
event: move event filtering to daemon (regression fix)
https://bugzilla.redhat.com/show_bug.cgi?id=1058839
Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
need to check the ACL rules to filter which events to send. But
it overlooked one thing: the event dispatch queue is running in
the main loop thread, and therefore does not normally have a
current virIdentityPtr. But filter checks can be based on current
identity, so when libvirtd.conf contains access_drivers=["polkit"],
we ended up rejecting access for EVERY event due to failure to
look up the current identity, even if it should have been allowed.
Furthermore, even for events that are triggered by API calls, it
is important to remember that the point of events is that they can
be copied across multiple connections, which may have separate
identities and permissions. So even if events were dispatched
from a context where we have an identity, we must change to the
correct identity of the connection that will be receiving the
event, rather than basing a decision on the context that triggered
the event, when deciding whether to filter an event to a
particular connection.
If there were an easy way to get from virConnectPtr to the
appropriate virIdentityPtr, then object_event.c could adjust the
identity prior to checking whether to dispatch an event. But
setting up that back-reference is a bit invasive. Instead, it
is easier to delay the filtering check until lower down the
stack, at the point where we have direct access to the RPC
client object that owns an identity. As such, this patch ends
up reverting a large portion of the framework of commit f9f56340.
We also have to teach 'make check' to special-case the fact that
the event registration filtering is done at the point of dispatch,
rather than the point of registration. Note that even though we
don't actually use virConnectDomainEventRegisterCheckACL (because
the RegisterAny variant is sufficient), we still generate the
function for the purposes of documenting that the filtering
takes place.
Also note that I did not entirely delete the notion of a filter
from object_event.c; I still plan on using that for my upcoming
patch series for qemu monitor events in libvirt-qemu.so. In
other words, while this patch changes ACL filtering to live in
remote.c and therefore we have no current client of the filtering
in object_event.c, the notion of filtering in object_event.c is
still useful down the road.
* src/check-aclrules.pl: Exempt event registration from having to
pass checkACL filter down call stack.
* daemon/remote.c (remoteRelayDomainEventCheckACL)
(remoteRelayNetworkEventCheckACL): New functions.
(remoteRelay*Event*): Use new functions.
* src/conf/domain_event.h (virDomainEventStateRegister)
(virDomainEventStateRegisterID): Drop unused parameter.
* src/conf/network_event.h (virNetworkEventStateRegisterID):
Likewise.
* src/conf/domain_event.c (virDomainEventFilter): Delete unused
function.
* src/conf/network_event.c (virNetworkEventFilter): Likewise.
* src/libxl/libxl_driver.c: Adjust caller.
* src/lxc/lxc_driver.c: Likewise.
* src/network/bridge_driver.c: Likewise.
* src/qemu/qemu_driver.c: Likewise.
* src/remote/remote_driver.c: Likewise.
* src/test/test_driver.c: Likewise.
* src/uml/uml_driver.c: Likewise.
* src/vbox/vbox_tmpl.c: Likewise.
* src/xen/xen_driver.c: Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-01-28 21:50:02 +00:00
|
|
|
NULL, NULL,
|
|
|
|
virNetworkEventClass, eventID,
|
2014-01-04 22:12:34 +00:00
|
|
|
VIR_OBJECT_EVENT_CALLBACK(cb),
|
2014-01-08 04:00:54 +00:00
|
|
|
opaque, freecb,
|
|
|
|
false, callbackID, false);
|
2014-01-06 12:32:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* virNetworkEventStateRegisterClient:
|
|
|
|
* @conn: connection to associate with callback
|
|
|
|
* @state: object event state
|
|
|
|
* @net: network to filter on or NULL for all networks
|
|
|
|
* @eventID: ID of the event type to register for
|
|
|
|
* @cb: function to invoke when event occurs
|
|
|
|
* @opaque: data blob to pass to @callback
|
|
|
|
* @freecb: callback to free @opaque
|
|
|
|
* @callbackID: filled with callback ID
|
|
|
|
*
|
|
|
|
* Register the function @cb with connection @conn, from @state, for
|
|
|
|
* events of type @eventID, and return the registration handle in
|
|
|
|
* @callbackID. This version is intended for use on the client side
|
|
|
|
* of RPC.
|
|
|
|
*
|
|
|
|
* Returns: the number of callbacks now registered, or -1 on error
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
virNetworkEventStateRegisterClient(virConnectPtr conn,
|
|
|
|
virObjectEventStatePtr state,
|
|
|
|
virNetworkPtr net,
|
|
|
|
int eventID,
|
|
|
|
virConnectNetworkEventGenericCallback cb,
|
|
|
|
void *opaque,
|
|
|
|
virFreeCallback freecb,
|
|
|
|
int *callbackID)
|
|
|
|
{
|
2016-06-23 15:50:05 +00:00
|
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
|
|
|
|
2014-01-06 12:32:55 +00:00
|
|
|
if (virNetworkEventsInitialize() < 0)
|
|
|
|
return -1;
|
|
|
|
|
2016-06-23 15:50:05 +00:00
|
|
|
if (net)
|
|
|
|
virUUIDFormat(net->uuid, uuidstr);
|
|
|
|
return virObjectEventStateRegisterID(conn, state, net ? uuidstr : NULL,
|
event: filter global events by domain:getattr ACL [CVE-2014-0028]
Ever since ACL filtering was added in commit 7639736 (v1.1.1), a
user could still use event registration to obtain access to a
domain that they could not normally access via virDomainLookup*
or virConnectListAllDomains and friends. We already have the
framework in the RPC generator for creating the filter, and
previous cleanup patches got us to the point that we can now
wire the filter through the entire object event stack.
Furthermore, whether or not domain:getattr is honored, use of
global events is a form of obtaining a list of networks, which
is covered by connect:search_domains added in a93cd08 (v1.1.0).
Ideally, we'd have a way to enforce connect:search_domains when
doing global registrations while omitting that check on a
per-domain registration. But this patch just unconditionally
requires connect:search_domains, even when no list could be
obtained, based on the following observations:
1. Administrators are unlikely to grant domain:getattr for one
or all domains while still denying connect:search_domains - a
user that is able to manage domains will want to be able to
manage them efficiently, but efficient management includes being
able to list the domains they can access. The idea of denying
connect:search_domains while still granting access to individual
domains is therefore not adding any real security, but just
serves as a layer of obscurity to annoy the end user.
2. In the current implementation, domain events are filtered
on the client; the server has no idea if a domain filter was
requested, and must therefore assume that all domain event
requests are global. Even if we fix the RPC protocol to
allow for server-side filtering for newer client/server combos,
making the connect:serach_domains ACL check conditional on
whether the domain argument was NULL won't benefit older clients.
Therefore, we choose to document that connect:search_domains
is a pre-requisite to any domain event management.
Network events need the same treatment, with the obvious
change of using connect:search_networks and network:getattr.
* src/access/viraccessperm.h
(VIR_ACCESS_PERM_CONNECT_SEARCH_DOMAINS)
(VIR_ACCESS_PERM_CONNECT_SEARCH_NETWORKS): Document additional
effect of the permission.
* src/conf/domain_event.h (virDomainEventStateRegister)
(virDomainEventStateRegisterID): Add new parameter.
* src/conf/network_event.h (virNetworkEventStateRegisterID):
Likewise.
* src/conf/object_event_private.h (virObjectEventStateRegisterID):
Likewise.
* src/conf/object_event.c (_virObjectEventCallback): Track a filter.
(virObjectEventDispatchMatchCallback): Use filter.
(virObjectEventCallbackListAddID): Register filter.
* src/conf/domain_event.c (virDomainEventFilter): New function.
(virDomainEventStateRegister, virDomainEventStateRegisterID):
Adjust callers.
* src/conf/network_event.c (virNetworkEventFilter): New function.
(virNetworkEventStateRegisterID): Adjust caller.
* src/remote/remote_protocol.x
(REMOTE_PROC_CONNECT_DOMAIN_EVENT_REGISTER)
(REMOTE_PROC_CONNECT_DOMAIN_EVENT_REGISTER_ANY)
(REMOTE_PROC_CONNECT_NETWORK_EVENT_REGISTER_ANY): Generate a
filter, and require connect:search_domains instead of weaker
connect:read.
* src/test/test_driver.c (testConnectDomainEventRegister)
(testConnectDomainEventRegisterAny)
(testConnectNetworkEventRegisterAny): Update callers.
* src/remote/remote_driver.c (remoteConnectDomainEventRegister)
(remoteConnectDomainEventRegisterAny): Likewise.
* src/xen/xen_driver.c (xenUnifiedConnectDomainEventRegister)
(xenUnifiedConnectDomainEventRegisterAny): Likewise.
* src/vbox/vbox_tmpl.c (vboxDomainGetXMLDesc): Likewise.
* src/libxl/libxl_driver.c (libxlConnectDomainEventRegister)
(libxlConnectDomainEventRegisterAny): Likewise.
* src/qemu/qemu_driver.c (qemuConnectDomainEventRegister)
(qemuConnectDomainEventRegisterAny): Likewise.
* src/uml/uml_driver.c (umlConnectDomainEventRegister)
(umlConnectDomainEventRegisterAny): Likewise.
* src/network/bridge_driver.c
(networkConnectNetworkEventRegisterAny): Likewise.
* src/lxc/lxc_driver.c (lxcConnectDomainEventRegister)
(lxcConnectDomainEventRegisterAny): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-01-08 20:34:48 +00:00
|
|
|
NULL, NULL,
|
2014-01-06 12:32:55 +00:00
|
|
|
virNetworkEventClass, eventID,
|
|
|
|
VIR_OBJECT_EVENT_CALLBACK(cb),
|
2014-01-08 04:00:54 +00:00
|
|
|
opaque, freecb,
|
|
|
|
false, callbackID, true);
|
2013-12-11 10:37:58 +00:00
|
|
|
}
|
|
|
|
|
2014-01-02 14:16:49 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* virNetworkEventLifecycleNew:
|
|
|
|
* @name: name of the network object the event describes
|
|
|
|
* @uuid: uuid of the network object the event describes
|
|
|
|
* @type: type of lifecycle event
|
|
|
|
* @detail: more details about @type
|
|
|
|
*
|
|
|
|
* Create a new network lifecycle event.
|
|
|
|
*/
|
2013-12-11 10:37:58 +00:00
|
|
|
virObjectEventPtr
|
|
|
|
virNetworkEventLifecycleNew(const char *name,
|
|
|
|
const unsigned char *uuid,
|
2013-12-11 13:40:41 +00:00
|
|
|
int type,
|
|
|
|
int detail)
|
2013-12-11 10:37:58 +00:00
|
|
|
{
|
|
|
|
virNetworkEventLifecyclePtr event;
|
2016-06-23 16:06:39 +00:00
|
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
2013-12-11 10:37:58 +00:00
|
|
|
|
|
|
|
if (virNetworkEventsInitialize() < 0)
|
|
|
|
return NULL;
|
|
|
|
|
2016-06-23 16:06:39 +00:00
|
|
|
virUUIDFormat(uuid, uuidstr);
|
2013-12-11 10:37:58 +00:00
|
|
|
if (!(event = virObjectEventNew(virNetworkEventLifecycleClass,
|
2013-12-12 17:47:42 +00:00
|
|
|
virNetworkEventDispatchDefaultFunc,
|
2013-12-11 14:10:34 +00:00
|
|
|
VIR_NETWORK_EVENT_ID_LIFECYCLE,
|
2016-06-23 16:06:39 +00:00
|
|
|
0, name, uuid, uuidstr)))
|
2013-12-11 10:37:58 +00:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
event->type = type;
|
2013-12-11 13:40:41 +00:00
|
|
|
event->detail = detail;
|
2013-12-11 10:37:58 +00:00
|
|
|
|
|
|
|
return (virObjectEventPtr)event;
|
|
|
|
}
|