2014-06-06 14:50:39 +00:00
|
|
|
/*
|
|
|
|
* numatune_conf.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library. If not, see
|
|
|
|
* <http://www.gnu.org/licenses/>.
|
|
|
|
*
|
|
|
|
* Author: Martin Kletzander <mkletzan@redhat.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
|
|
#include "numatune_conf.h"
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
#include "domain_conf.h"
|
|
|
|
#include "viralloc.h"
|
|
|
|
#include "virstring.h"
|
|
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_DOMAIN
|
|
|
|
|
2014-06-06 14:50:39 +00:00
|
|
|
VIR_ENUM_IMPL(virDomainNumatuneMemMode,
|
|
|
|
VIR_DOMAIN_NUMATUNE_MEM_LAST,
|
|
|
|
"strict",
|
|
|
|
"preferred",
|
|
|
|
"interleave");
|
|
|
|
|
2014-06-08 17:15:42 +00:00
|
|
|
VIR_ENUM_IMPL(virDomainNumatunePlacement,
|
|
|
|
VIR_DOMAIN_NUMATUNE_PLACEMENT_LAST,
|
2014-06-06 14:50:39 +00:00
|
|
|
"default",
|
|
|
|
"static",
|
|
|
|
"auto");
|
2014-06-09 13:00:22 +00:00
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
typedef struct _virDomainNumatuneNode virDomainNumatuneNode;
|
|
|
|
typedef virDomainNumatuneNode *virDomainNumatuneNodePtr;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
struct _virDomainNumatune {
|
|
|
|
struct {
|
2014-07-15 09:39:44 +00:00
|
|
|
bool specified;
|
2014-06-09 13:00:22 +00:00
|
|
|
virBitmapPtr nodeset;
|
|
|
|
virDomainNumatuneMemMode mode;
|
|
|
|
virDomainNumatunePlacement placement;
|
|
|
|
} memory; /* pinning for all the memory */
|
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
struct _virDomainNumatuneNode {
|
|
|
|
virBitmapPtr nodeset;
|
|
|
|
virDomainNumatuneMemMode mode;
|
|
|
|
} *mem_nodes; /* fine tuning per guest node */
|
|
|
|
size_t nmem_nodes;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
/* Future NUMA tuning related stuff should go here. */
|
|
|
|
};
|
|
|
|
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
static inline bool
|
|
|
|
virDomainNumatuneNodeSpecified(virDomainNumatunePtr numatune,
|
|
|
|
int cellid)
|
|
|
|
{
|
|
|
|
if (numatune &&
|
|
|
|
cellid >= 0 &&
|
|
|
|
cellid < numatune->nmem_nodes)
|
|
|
|
return numatune->mem_nodes[cellid].nodeset;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
static int
|
2014-07-21 09:32:33 +00:00
|
|
|
virDomainNumatuneNodeParseXML(virDomainNumatunePtr *numatunePtr,
|
|
|
|
size_t ncells,
|
2014-07-15 09:39:44 +00:00
|
|
|
xmlXPathContextPtr ctxt)
|
|
|
|
{
|
|
|
|
char *tmp = NULL;
|
2014-08-25 22:26:56 +00:00
|
|
|
int n = 0;
|
2014-07-15 09:39:44 +00:00
|
|
|
int ret = -1;
|
|
|
|
size_t i = 0;
|
2014-07-21 09:32:33 +00:00
|
|
|
virDomainNumatunePtr numatune = *numatunePtr;
|
2014-07-15 09:39:44 +00:00
|
|
|
xmlNodePtr *nodes = NULL;
|
|
|
|
|
|
|
|
if ((n = virXPathNodeSet("./numatune/memnode", ctxt, &nodes)) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Cannot extract memnode nodes"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!n)
|
|
|
|
return 0;
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (numatune && numatune->memory.specified &&
|
|
|
|
numatune->memory.placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO) {
|
2014-07-15 09:39:44 +00:00
|
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
|
|
|
_("Per-node binding is not compatible with "
|
|
|
|
"automatic NUMA placement."));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (!ncells) {
|
2014-07-15 09:39:44 +00:00
|
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
|
|
_("Element 'memnode' is invalid without "
|
|
|
|
"any guest NUMA cells"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (!numatune && VIR_ALLOC(numatune) < 0)
|
2014-07-15 09:39:44 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
*numatunePtr = numatune;
|
|
|
|
|
|
|
|
VIR_FREE(numatune->mem_nodes);
|
|
|
|
if (VIR_ALLOC_N(numatune->mem_nodes, ncells) < 0)
|
2014-07-15 09:39:44 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
numatune->nmem_nodes = ncells;
|
2014-07-15 09:39:44 +00:00
|
|
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
int mode = 0;
|
|
|
|
unsigned int cellid = 0;
|
|
|
|
virDomainNumatuneNodePtr mem_node = NULL;
|
|
|
|
xmlNodePtr cur_node = nodes[i];
|
|
|
|
|
|
|
|
tmp = virXMLPropString(cur_node, "cellid");
|
|
|
|
if (!tmp) {
|
|
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
|
|
_("Missing required cellid attribute "
|
|
|
|
"in memnode element"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (virStrToLong_uip(tmp, NULL, 10, &cellid) < 0) {
|
|
|
|
virReportError(VIR_ERR_XML_ERROR,
|
|
|
|
_("Invalid cellid attribute in memnode element: %s"),
|
|
|
|
tmp);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (cellid >= numatune->nmem_nodes) {
|
2014-07-15 09:39:44 +00:00
|
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
|
|
_("Argument 'cellid' in memnode element must "
|
|
|
|
"correspond to existing guest's NUMA cell"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
mem_node = &numatune->mem_nodes[cellid];
|
2014-07-15 09:39:44 +00:00
|
|
|
|
|
|
|
if (mem_node->nodeset) {
|
|
|
|
virReportError(VIR_ERR_XML_ERROR,
|
|
|
|
_("Multiple memnode elements with cellid %u"),
|
|
|
|
cellid);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
tmp = virXMLPropString(cur_node, "mode");
|
|
|
|
if (!tmp) {
|
|
|
|
mem_node->mode = VIR_DOMAIN_NUMATUNE_MEM_STRICT;
|
|
|
|
} else {
|
|
|
|
if ((mode = virDomainNumatuneMemModeTypeFromString(tmp)) < 0) {
|
|
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
|
|
_("Invalid mode attribute in memnode element"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
mem_node->mode = mode;
|
|
|
|
}
|
|
|
|
|
|
|
|
tmp = virXMLPropString(cur_node, "nodeset");
|
|
|
|
if (!tmp) {
|
|
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
|
|
_("Missing required nodeset attribute "
|
|
|
|
"in memnode element"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (virBitmapParse(tmp, 0, &mem_node->nodeset,
|
|
|
|
VIR_DOMAIN_CPUMASK_LEN) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
|
|
VIR_FREE(nodes);
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
int
|
2014-07-21 09:32:33 +00:00
|
|
|
virDomainNumatuneParseXML(virDomainNumatunePtr *numatunePtr,
|
|
|
|
bool placement_static,
|
|
|
|
size_t ncells,
|
2014-06-09 13:00:22 +00:00
|
|
|
xmlXPathContextPtr ctxt)
|
|
|
|
{
|
|
|
|
char *tmp = NULL;
|
|
|
|
int mode = -1;
|
|
|
|
int n = 0;
|
|
|
|
int placement = -1;
|
|
|
|
int ret = -1;
|
|
|
|
virBitmapPtr nodeset = NULL;
|
|
|
|
xmlNodePtr node = NULL;
|
|
|
|
|
|
|
|
if (virXPathInt("count(./numatune)", ctxt, &n) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("cannot extract numatune nodes"));
|
|
|
|
goto cleanup;
|
|
|
|
} else if (n > 1) {
|
|
|
|
virReportError(VIR_ERR_XML_ERROR, "%s",
|
|
|
|
_("only one numatune is supported"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
node = virXPathNode("./numatune/memory[1]", ctxt);
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (*numatunePtr) {
|
|
|
|
virDomainNumatuneFree(*numatunePtr);
|
|
|
|
*numatunePtr = NULL;
|
2014-06-09 13:00:22 +00:00
|
|
|
}
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (!node && placement_static) {
|
|
|
|
if (virDomainNumatuneNodeParseXML(numatunePtr, ncells, ctxt) < 0)
|
2014-07-15 09:39:44 +00:00
|
|
|
goto cleanup;
|
2014-06-09 13:00:22 +00:00
|
|
|
return 0;
|
2014-07-15 09:39:44 +00:00
|
|
|
}
|
2014-06-09 13:00:22 +00:00
|
|
|
|
|
|
|
if (!node) {
|
2014-07-21 09:32:33 +00:00
|
|
|
/* We know that placement_mode is "auto" if we're here */
|
|
|
|
ret = virDomainNumatuneSet(numatunePtr,
|
|
|
|
placement_static,
|
|
|
|
VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO,
|
|
|
|
-1,
|
|
|
|
NULL);
|
|
|
|
goto cleanup;
|
2014-06-09 13:00:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
tmp = virXMLPropString(node, "mode");
|
|
|
|
if (tmp) {
|
|
|
|
mode = virDomainNumatuneMemModeTypeFromString(tmp);
|
|
|
|
if (mode < 0) {
|
|
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
|
_("Unsupported NUMA memory tuning mode '%s'"),
|
|
|
|
tmp);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
|
|
|
tmp = virXMLPropString(node, "placement");
|
|
|
|
if (tmp) {
|
|
|
|
placement = virDomainNumatunePlacementTypeFromString(tmp);
|
|
|
|
if (placement < 0) {
|
|
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
|
_("Unsupported NUMA memory placement mode '%s'"),
|
|
|
|
tmp);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
|
|
|
tmp = virXMLPropString(node, "nodeset");
|
|
|
|
if (tmp && virBitmapParse(tmp, 0, &nodeset, VIR_DOMAIN_CPUMASK_LEN) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (virDomainNumatuneSet(numatunePtr,
|
|
|
|
placement_static,
|
|
|
|
placement,
|
|
|
|
mode,
|
|
|
|
nodeset) < 0)
|
2014-06-09 13:00:22 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2014-07-21 09:32:33 +00:00
|
|
|
if (virDomainNumatuneNodeParseXML(numatunePtr, ncells, ctxt) < 0)
|
2014-06-09 13:00:22 +00:00
|
|
|
goto cleanup;
|
2014-07-15 09:39:44 +00:00
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
|
|
virBitmapFree(nodeset);
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
virDomainNumatuneFormatXML(virBufferPtr buf,
|
|
|
|
virDomainNumatunePtr numatune)
|
|
|
|
{
|
|
|
|
const char *tmp = NULL;
|
|
|
|
char *nodeset = NULL;
|
2014-07-15 09:39:44 +00:00
|
|
|
size_t i = 0;
|
2014-06-09 13:00:22 +00:00
|
|
|
|
|
|
|
if (!numatune)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
virBufferAddLit(buf, "<numatune>\n");
|
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
if (numatune->memory.specified) {
|
|
|
|
tmp = virDomainNumatuneMemModeTypeToString(numatune->memory.mode);
|
|
|
|
virBufferAsprintf(buf, "<memory mode='%s' ", tmp);
|
|
|
|
|
|
|
|
if (numatune->memory.placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_STATIC) {
|
|
|
|
if (!(nodeset = virBitmapFormat(numatune->memory.nodeset)))
|
|
|
|
return -1;
|
|
|
|
virBufferAsprintf(buf, "nodeset='%s'/>\n", nodeset);
|
|
|
|
VIR_FREE(nodeset);
|
|
|
|
} else if (numatune->memory.placement) {
|
|
|
|
tmp = virDomainNumatunePlacementTypeToString(numatune->memory.placement);
|
|
|
|
virBufferAsprintf(buf, "placement='%s'/>\n", tmp);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < numatune->nmem_nodes; i++) {
|
|
|
|
virDomainNumatuneNodePtr mem_node = &numatune->mem_nodes[i];
|
2014-06-09 13:00:22 +00:00
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
if (!mem_node->nodeset)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!(nodeset = virBitmapFormat(mem_node->nodeset)))
|
2014-06-09 13:00:22 +00:00
|
|
|
return -1;
|
2014-07-15 09:39:44 +00:00
|
|
|
|
|
|
|
virBufferAsprintf(buf,
|
|
|
|
"<memnode cellid='%zu' mode='%s' nodeset='%s'/>\n",
|
|
|
|
i,
|
|
|
|
virDomainNumatuneMemModeTypeToString(mem_node->mode),
|
|
|
|
nodeset);
|
2014-06-09 13:00:22 +00:00
|
|
|
VIR_FREE(nodeset);
|
|
|
|
}
|
|
|
|
|
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</numatune>\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
virDomainNumatuneFree(virDomainNumatunePtr numatune)
|
|
|
|
{
|
2014-07-15 09:39:44 +00:00
|
|
|
size_t i = 0;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
if (!numatune)
|
|
|
|
return;
|
|
|
|
|
|
|
|
virBitmapFree(numatune->memory.nodeset);
|
2014-07-15 09:39:44 +00:00
|
|
|
for (i = 0; i < numatune->nmem_nodes; i++)
|
|
|
|
virBitmapFree(numatune->mem_nodes[i].nodeset);
|
|
|
|
VIR_FREE(numatune->mem_nodes);
|
2014-06-09 13:00:22 +00:00
|
|
|
|
|
|
|
VIR_FREE(numatune);
|
|
|
|
}
|
|
|
|
|
|
|
|
virDomainNumatuneMemMode
|
2014-06-26 17:46:45 +00:00
|
|
|
virDomainNumatuneGetMode(virDomainNumatunePtr numatune,
|
|
|
|
int cellid)
|
2014-06-09 13:00:22 +00:00
|
|
|
{
|
2014-06-26 17:46:45 +00:00
|
|
|
if (!numatune)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (virDomainNumatuneNodeSpecified(numatune, cellid))
|
|
|
|
return numatune->mem_nodes[cellid].mode;
|
|
|
|
|
|
|
|
if (numatune->memory.specified)
|
|
|
|
return numatune->memory.mode;
|
|
|
|
|
|
|
|
return 0;
|
2014-06-09 13:00:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
virBitmapPtr
|
|
|
|
virDomainNumatuneGetNodeset(virDomainNumatunePtr numatune,
|
2014-06-26 17:46:45 +00:00
|
|
|
virBitmapPtr auto_nodeset,
|
|
|
|
int cellid)
|
2014-06-09 13:00:22 +00:00
|
|
|
{
|
|
|
|
if (!numatune)
|
|
|
|
return NULL;
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
if (numatune->memory.specified &&
|
|
|
|
numatune->memory.placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO)
|
2014-06-09 13:00:22 +00:00
|
|
|
return auto_nodeset;
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
if (virDomainNumatuneNodeSpecified(numatune, cellid))
|
|
|
|
return numatune->mem_nodes[cellid].nodeset;
|
|
|
|
|
|
|
|
if (!numatune->memory.specified)
|
2014-06-09 13:00:22 +00:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return numatune->memory.nodeset;
|
|
|
|
}
|
|
|
|
|
|
|
|
char *
|
|
|
|
virDomainNumatuneFormatNodeset(virDomainNumatunePtr numatune,
|
2014-06-26 17:46:45 +00:00
|
|
|
virBitmapPtr auto_nodeset,
|
|
|
|
int cellid)
|
2014-06-09 13:00:22 +00:00
|
|
|
{
|
|
|
|
return virBitmapFormat(virDomainNumatuneGetNodeset(numatune,
|
2014-06-26 17:46:45 +00:00
|
|
|
auto_nodeset,
|
|
|
|
cellid));
|
2014-06-09 13:00:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
virDomainNumatuneMaybeFormatNodeset(virDomainNumatunePtr numatune,
|
|
|
|
virBitmapPtr auto_nodeset,
|
2014-06-26 17:46:45 +00:00
|
|
|
char **mask,
|
|
|
|
int cellid)
|
2014-06-09 13:00:22 +00:00
|
|
|
{
|
|
|
|
*mask = NULL;
|
|
|
|
|
|
|
|
if (!numatune)
|
|
|
|
return 0;
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
if (!virDomainNumatuneNodeSpecified(numatune, cellid) &&
|
|
|
|
!numatune->memory.specified)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (numatune->memory.specified &&
|
|
|
|
numatune->memory.placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO &&
|
2014-06-09 13:00:22 +00:00
|
|
|
!auto_nodeset) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Advice from numad is needed in case of "
|
|
|
|
"automatic numa placement"));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
*mask = virDomainNumatuneFormatNodeset(numatune, auto_nodeset, cellid);
|
2014-06-09 13:00:22 +00:00
|
|
|
if (!*mask)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
2014-07-21 09:32:33 +00:00
|
|
|
virDomainNumatuneSet(virDomainNumatunePtr *numatunePtr,
|
|
|
|
bool placement_static,
|
2014-06-09 13:00:22 +00:00
|
|
|
int placement,
|
|
|
|
int mode,
|
|
|
|
virBitmapPtr nodeset)
|
|
|
|
{
|
2014-08-22 14:05:37 +00:00
|
|
|
bool created = false;
|
2014-06-09 13:00:22 +00:00
|
|
|
int ret = -1;
|
2014-08-22 14:05:37 +00:00
|
|
|
virDomainNumatunePtr numatune;
|
2014-06-09 13:00:22 +00:00
|
|
|
|
|
|
|
/* No need to do anything in this case */
|
|
|
|
if (mode == -1 && placement == -1 && !nodeset)
|
|
|
|
return 0;
|
|
|
|
|
2014-08-22 14:05:37 +00:00
|
|
|
if (!(*numatunePtr)) {
|
|
|
|
if (VIR_ALLOC(*numatunePtr) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
created = true;
|
|
|
|
if (mode == -1)
|
|
|
|
mode = VIR_DOMAIN_NUMATUNE_MEM_STRICT;
|
|
|
|
if (placement == -1)
|
|
|
|
placement = VIR_DOMAIN_NUMATUNE_PLACEMENT_DEFAULT;
|
|
|
|
}
|
|
|
|
|
|
|
|
numatune = *numatunePtr;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
/* Range checks */
|
|
|
|
if (mode != -1 &&
|
|
|
|
(mode < 0 || mode >= VIR_DOMAIN_NUMATUNE_MEM_LAST)) {
|
|
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
|
_("Unsupported numatune mode '%d'"),
|
|
|
|
mode);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2014-08-22 14:05:37 +00:00
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
if (placement != -1 &&
|
|
|
|
(placement < 0 || placement >= VIR_DOMAIN_NUMATUNE_PLACEMENT_LAST)) {
|
|
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
|
_("Unsupported numatune placement '%d'"),
|
|
|
|
mode);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (mode != -1)
|
|
|
|
numatune->memory.mode = mode;
|
2014-08-22 14:05:37 +00:00
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
if (nodeset) {
|
|
|
|
virBitmapFree(numatune->memory.nodeset);
|
|
|
|
numatune->memory.nodeset = virBitmapNewCopy(nodeset);
|
|
|
|
if (!numatune->memory.nodeset)
|
|
|
|
goto cleanup;
|
|
|
|
if (placement == -1)
|
|
|
|
placement = VIR_DOMAIN_NUMATUNE_PLACEMENT_STATIC;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_DEFAULT) {
|
2014-07-21 09:32:33 +00:00
|
|
|
if (numatune->memory.nodeset || placement_static)
|
2014-06-09 13:00:22 +00:00
|
|
|
placement = VIR_DOMAIN_NUMATUNE_PLACEMENT_STATIC;
|
|
|
|
else
|
|
|
|
placement = VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_STATIC &&
|
|
|
|
!numatune->memory.nodeset) {
|
|
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
|
|
|
_("nodeset for NUMA memory tuning must be set "
|
|
|
|
"if 'placement' is 'static'"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-08-22 14:05:37 +00:00
|
|
|
/* setting nodeset when placement auto is invalid */
|
|
|
|
if (placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO &&
|
|
|
|
numatune->memory.nodeset) {
|
|
|
|
virBitmapFree(numatune->memory.nodeset);
|
|
|
|
numatune->memory.nodeset = NULL;
|
|
|
|
}
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
if (placement != -1)
|
|
|
|
numatune->memory.placement = placement;
|
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
numatune->memory.specified = true;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
ret = 0;
|
2014-08-22 14:05:37 +00:00
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
cleanup:
|
2014-08-22 14:05:37 +00:00
|
|
|
if (ret < 0 && created) {
|
|
|
|
virDomainNumatuneFree(*numatunePtr);
|
|
|
|
*numatunePtr = NULL;
|
|
|
|
}
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
static bool
|
|
|
|
virDomainNumatuneNodesEqual(virDomainNumatunePtr n1,
|
|
|
|
virDomainNumatunePtr n2)
|
|
|
|
{
|
|
|
|
size_t i = 0;
|
|
|
|
|
|
|
|
if (n1->nmem_nodes != n2->nmem_nodes)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
for (i = 0; i < n1->nmem_nodes; i++) {
|
|
|
|
virDomainNumatuneNodePtr nd1 = &n1->mem_nodes[i];
|
|
|
|
virDomainNumatuneNodePtr nd2 = &n2->mem_nodes[i];
|
|
|
|
|
|
|
|
if (!nd1->nodeset && !nd2->nodeset)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!nd1->nodeset || !nd2->nodeset)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (nd1->mode != nd2->mode)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (!virBitmapEqual(nd1->nodeset, nd2->nodeset))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
bool
|
|
|
|
virDomainNumatuneEquals(virDomainNumatunePtr n1,
|
|
|
|
virDomainNumatunePtr n2)
|
|
|
|
{
|
|
|
|
if (!n1 && !n2)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (!n1 || !n2)
|
|
|
|
return false;
|
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
if (!n1->memory.specified && !n2->memory.specified)
|
2014-06-26 17:46:45 +00:00
|
|
|
return virDomainNumatuneNodesEqual(n1, n2);
|
2014-07-15 09:39:44 +00:00
|
|
|
|
|
|
|
if (!n1->memory.specified || !n2->memory.specified)
|
|
|
|
return false;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
if (n1->memory.mode != n2->memory.mode)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (n1->memory.placement != n2->memory.placement)
|
|
|
|
return false;
|
|
|
|
|
2014-06-26 17:46:45 +00:00
|
|
|
if (!virBitmapEqual(n1->memory.nodeset, n2->memory.nodeset))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return virDomainNumatuneNodesEqual(n1, n2);
|
2014-06-09 13:00:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool
|
|
|
|
virDomainNumatuneHasPlacementAuto(virDomainNumatunePtr numatune)
|
|
|
|
{
|
|
|
|
if (!numatune)
|
|
|
|
return false;
|
|
|
|
|
2014-07-15 09:39:44 +00:00
|
|
|
if (!numatune->memory.specified)
|
|
|
|
return false;
|
|
|
|
|
2014-06-09 13:00:22 +00:00
|
|
|
if (numatune->memory.placement == VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
2014-06-26 17:46:45 +00:00
|
|
|
|
|
|
|
bool
|
|
|
|
virDomainNumatuneHasPerNodeBinding(virDomainNumatunePtr numatune)
|
|
|
|
{
|
|
|
|
size_t i = 0;
|
|
|
|
|
|
|
|
if (!numatune)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
for (i = 0; i < numatune->nmem_nodes; i++) {
|
|
|
|
if (numatune->mem_nodes[i].nodeset)
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
2014-11-04 02:44:40 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
virDomainNumatuneSpecifiedMaxNode(virDomainNumatunePtr numatune)
|
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
virBitmapPtr nodemask = NULL;
|
|
|
|
size_t i;
|
|
|
|
int bit;
|
|
|
|
|
|
|
|
if (!numatune)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
nodemask = virDomainNumatuneGetNodeset(numatune, NULL, -1);
|
|
|
|
if (nodemask)
|
|
|
|
ret = virBitmapLastSetBit(nodemask);
|
|
|
|
|
|
|
|
for (i = 0; i < numatune->nmem_nodes; i++) {
|
|
|
|
nodemask = numatune->mem_nodes[i].nodeset;
|
|
|
|
if (!nodemask)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
bit = virBitmapLastSetBit(nodemask);
|
|
|
|
if (bit > ret)
|
|
|
|
ret = bit;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|