2014-05-08 21:56:51 +00:00
|
|
|
/*
|
|
|
|
* libxl_migration.c: methods for handling migration with libxenlight
|
|
|
|
*
|
2015-02-11 23:40:07 +00:00
|
|
|
* Copyright (C) 2014-2015 SUSE LINUX Products GmbH, Nuernberg, Germany.
|
2014-05-08 21:56:51 +00:00
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library. If not, see
|
|
|
|
* <http://www.gnu.org/licenses/>.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Jim Fehlig <jfehlig@suse.com>
|
|
|
|
* Chunyan Liu <cyliu@suse.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
|
|
#include "internal.h"
|
|
|
|
#include "virlog.h"
|
|
|
|
#include "virerror.h"
|
|
|
|
#include "virconf.h"
|
|
|
|
#include "datatypes.h"
|
|
|
|
#include "virfile.h"
|
|
|
|
#include "viralloc.h"
|
|
|
|
#include "viruuid.h"
|
|
|
|
#include "vircommand.h"
|
|
|
|
#include "virstring.h"
|
|
|
|
#include "virobject.h"
|
2014-11-12 22:32:02 +00:00
|
|
|
#include "virthread.h"
|
2014-05-08 21:56:51 +00:00
|
|
|
#include "rpc/virnetsocket.h"
|
|
|
|
#include "libxl_domain.h"
|
|
|
|
#include "libxl_driver.h"
|
|
|
|
#include "libxl_conf.h"
|
|
|
|
#include "libxl_migration.h"
|
2015-04-14 20:38:46 +00:00
|
|
|
#include "locking/domain_lock.h"
|
2016-02-05 20:45:02 +00:00
|
|
|
#include "virtypedparam.h"
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_LIBXL
|
|
|
|
|
|
|
|
VIR_LOG_INIT("libxl.libxl_migration");
|
|
|
|
|
|
|
|
typedef struct _libxlMigrationDstArgs {
|
|
|
|
virObject parent;
|
|
|
|
|
2014-11-12 22:32:02 +00:00
|
|
|
int recvfd;
|
2014-05-08 21:56:51 +00:00
|
|
|
virConnectPtr conn;
|
|
|
|
virDomainObjPtr vm;
|
|
|
|
unsigned int flags;
|
|
|
|
|
|
|
|
/* for freeing listen sockets */
|
|
|
|
virNetSocketPtr *socks;
|
|
|
|
size_t nsocks;
|
|
|
|
} libxlMigrationDstArgs;
|
|
|
|
|
|
|
|
static virClassPtr libxlMigrationDstArgsClass;
|
|
|
|
|
|
|
|
static void
|
|
|
|
libxlMigrationDstArgsDispose(void *obj)
|
|
|
|
{
|
|
|
|
libxlMigrationDstArgs *args = obj;
|
|
|
|
|
|
|
|
VIR_FREE(args->socks);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
libxlMigrationDstArgsOnceInit(void)
|
|
|
|
{
|
|
|
|
if (!(libxlMigrationDstArgsClass = virClassNew(virClassForObject(),
|
|
|
|
"libxlMigrationDstArgs",
|
|
|
|
sizeof(libxlMigrationDstArgs),
|
|
|
|
libxlMigrationDstArgsDispose)))
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_ONCE_GLOBAL_INIT(libxlMigrationDstArgs)
|
|
|
|
|
|
|
|
static void
|
2014-11-12 22:32:02 +00:00
|
|
|
libxlDoMigrateReceive(void *opaque)
|
2014-05-08 21:56:51 +00:00
|
|
|
{
|
|
|
|
libxlMigrationDstArgs *args = opaque;
|
|
|
|
virDomainObjPtr vm = args->vm;
|
|
|
|
virNetSocketPtr *socks = args->socks;
|
|
|
|
size_t nsocks = args->nsocks;
|
2014-11-12 22:32:02 +00:00
|
|
|
libxlDriverPrivatePtr driver = args->conn->privateData;
|
|
|
|
int recvfd = args->recvfd;
|
2014-05-08 21:56:51 +00:00
|
|
|
size_t i;
|
|
|
|
int ret;
|
2015-07-16 18:24:32 +00:00
|
|
|
bool remove_dom = 0;
|
|
|
|
|
|
|
|
virObjectLock(vm);
|
|
|
|
if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0)
|
|
|
|
goto cleanup;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
2014-11-13 00:15:37 +00:00
|
|
|
/*
|
|
|
|
* Always start the domain paused. If needed, unpause in the
|
|
|
|
* finish phase, after transfer of the domain is complete.
|
|
|
|
*/
|
libxl: support Xen migration stream V2 in save/restore
Xen 4.6 introduced a new migration stream commonly referred to as
"migration V2". Xen 4.6 and newer always produce this new stream,
whereas Xen 4.5 and older always produce the legacy stream.
Support for migration stream V2 can be detected at build time with
LIBXL_HAVE_SRM_V2 from libxl.h. The legacy and V2 streams are not
compatible, but a V2 host can accept and convert a legacy stream.
Commit e7440656 changed the libxl driver to use the lowest libxl
API version possible (version 0x040200) to ensure the driver
builds against older Xen releases. The old 4.2 restore API does
not support specifying a stream version and assumes a legacy
stream, even if the incoming stream is migration V2. Thinking it
has been given a legacy stream, libxl will fail to convert an
incoming stream that is already V2, which causes the entire
restore operation to fail. Xen's libvirt-related OSSTest has been
failing since commit e7440656 landed in libvirt.git master. One
of the more recent failures can be seen here
http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg00071.html
This patch changes the call to libxl_domain_create_restore() to
include the stream version if LIBXL_HAVE_SRM_V2 is defined. The
version field of the libxlSavefileHeader struct is also updated
to '2' when LIBXL_HAVE_SRM_V2 is defined, ensuring the stream
version in the header matches the actual stream version produced
by Xen. Along with bumping the libxl API requirement to 0x040400,
this patch fixes save/restore on a migration V2 Xen host.
Oddly, migration has never used the libxlSavefileHeader. It
handles passing configuration in the Begin and Prepare phases,
and then calls libxl directly to transfer domain state/memory
in the Perform phase. A subsequent patch will add stream
version handling in the Begin and Prepare phase handshaking,
which will fix the migration related OSSTest failures.
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
2016-05-02 18:00:39 +00:00
|
|
|
ret = libxlDomainStartRestore(driver, vm, true, recvfd, LIBXL_SAVE_VERSION);
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
if (ret < 0 && !vm->persistent)
|
2015-07-16 18:24:32 +00:00
|
|
|
remove_dom = true;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
2014-11-12 22:32:02 +00:00
|
|
|
/* Remove all listen socks from event handler, and close them. */
|
|
|
|
for (i = 0; i < nsocks; i++) {
|
|
|
|
virNetSocketRemoveIOCallback(socks[i]);
|
|
|
|
virNetSocketClose(socks[i]);
|
|
|
|
virObjectUnref(socks[i]);
|
|
|
|
socks[i] = NULL;
|
|
|
|
}
|
|
|
|
args->nsocks = 0;
|
|
|
|
VIR_FORCE_CLOSE(recvfd);
|
2015-07-15 22:35:50 +00:00
|
|
|
virObjectUnref(args);
|
2015-07-16 18:24:32 +00:00
|
|
|
|
|
|
|
if (!libxlDomainObjEndJob(driver, vm))
|
|
|
|
vm = NULL;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
if (remove_dom && vm) {
|
|
|
|
virDomainObjListRemove(driver->domains, vm);
|
|
|
|
vm = NULL;
|
|
|
|
}
|
|
|
|
if (vm)
|
|
|
|
virObjectUnlock(vm);
|
2014-11-12 22:32:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
libxlMigrateReceive(virNetSocketPtr sock,
|
|
|
|
int events ATTRIBUTE_UNUSED,
|
|
|
|
void *opaque)
|
|
|
|
{
|
|
|
|
libxlMigrationDstArgs *args = opaque;
|
|
|
|
virNetSocketPtr *socks = args->socks;
|
|
|
|
size_t nsocks = args->nsocks;
|
|
|
|
virNetSocketPtr client_sock;
|
|
|
|
int recvfd = -1;
|
|
|
|
virThread thread;
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
/* Accept migration connection */
|
2014-12-01 16:10:18 +00:00
|
|
|
if (virNetSocketAccept(sock, &client_sock) < 0 || !client_sock) {
|
2014-11-12 22:32:02 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Failed to accept migration connection"));
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
VIR_DEBUG("Accepted migration connection."
|
|
|
|
" Spawing thread to process migration data");
|
|
|
|
recvfd = virNetSocketDupFD(client_sock, true);
|
|
|
|
virObjectUnref(client_sock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Avoid blocking the event loop. Start a thread to receive
|
|
|
|
* the migration data
|
|
|
|
*/
|
|
|
|
args->recvfd = recvfd;
|
|
|
|
if (virThreadCreate(&thread, false,
|
|
|
|
libxlDoMigrateReceive, args) < 0) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Failed to create thread for receiving migration data"));
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
fail:
|
2014-05-08 21:56:51 +00:00
|
|
|
/* Remove all listen socks from event handler, and close them. */
|
|
|
|
for (i = 0; i < nsocks; i++) {
|
|
|
|
virNetSocketUpdateIOCallback(socks[i], 0);
|
|
|
|
virNetSocketRemoveIOCallback(socks[i]);
|
|
|
|
virNetSocketClose(socks[i]);
|
|
|
|
socks[i] = NULL;
|
|
|
|
}
|
|
|
|
args->nsocks = 0;
|
|
|
|
VIR_FORCE_CLOSE(recvfd);
|
2015-07-15 22:35:50 +00:00
|
|
|
virObjectUnref(args);
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
libxlDoMigrateSend(libxlDriverPrivatePtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
unsigned long flags,
|
|
|
|
int sockfd)
|
|
|
|
{
|
|
|
|
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
|
|
|
|
int xl_flags = 0;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (flags & VIR_MIGRATE_LIVE)
|
|
|
|
xl_flags = LIBXL_SUSPEND_LIVE;
|
|
|
|
|
2015-02-11 23:40:07 +00:00
|
|
|
ret = libxl_domain_suspend(cfg->ctx, vm->def->id, sockfd,
|
2014-05-08 21:56:51 +00:00
|
|
|
xl_flags, NULL);
|
|
|
|
if (ret != 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Failed to send migration data to destination host"));
|
|
|
|
ret = -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
virObjectUnref(cfg);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
|
|
|
libxlDomainMigrationIsAllowed(virDomainDefPtr def)
|
|
|
|
{
|
|
|
|
/* Migration is not allowed if definition contains any hostdevs */
|
|
|
|
if (def->nhostdevs > 0) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("domain has assigned host devices"));
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
char *
|
|
|
|
libxlDomainMigrationBegin(virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *xmlin)
|
|
|
|
{
|
|
|
|
libxlDriverPrivatePtr driver = conn->privateData;
|
|
|
|
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
|
|
|
|
virDomainDefPtr tmpdef = NULL;
|
|
|
|
virDomainDefPtr def;
|
|
|
|
char *xml = NULL;
|
|
|
|
|
|
|
|
if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (xmlin) {
|
|
|
|
if (!(tmpdef = virDomainDefParseString(xmlin, cfg->caps,
|
|
|
|
driver->xmlopt,
|
2014-11-18 16:44:00 +00:00
|
|
|
VIR_DOMAIN_DEF_PARSE_INACTIVE)))
|
2014-05-08 21:56:51 +00:00
|
|
|
goto endjob;
|
|
|
|
|
|
|
|
if (!libxlDomainDefCheckABIStability(driver, vm->def, tmpdef))
|
|
|
|
goto endjob;
|
|
|
|
|
|
|
|
def = tmpdef;
|
|
|
|
} else {
|
|
|
|
def = vm->def;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!libxlDomainMigrationIsAllowed(def))
|
|
|
|
goto endjob;
|
|
|
|
|
2016-02-03 21:40:35 +00:00
|
|
|
xml = virDomainDefFormat(def, cfg->caps, VIR_DOMAIN_DEF_FORMAT_SECURE);
|
2014-05-08 21:56:51 +00:00
|
|
|
|
2014-07-08 21:17:58 +00:00
|
|
|
endjob:
|
|
|
|
if (!libxlDomainObjEndJob(driver, vm))
|
|
|
|
vm = NULL;
|
|
|
|
|
2014-05-08 21:56:51 +00:00
|
|
|
cleanup:
|
|
|
|
if (vm)
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
|
|
|
|
virDomainDefFree(tmpdef);
|
|
|
|
virObjectUnref(cfg);
|
|
|
|
return xml;
|
|
|
|
}
|
|
|
|
|
|
|
|
virDomainDefPtr
|
|
|
|
libxlDomainMigrationPrepareDef(libxlDriverPrivatePtr driver,
|
|
|
|
const char *dom_xml,
|
|
|
|
const char *dname)
|
|
|
|
{
|
|
|
|
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
|
|
|
|
virDomainDefPtr def;
|
|
|
|
char *name = NULL;
|
|
|
|
|
|
|
|
if (!dom_xml) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("no domain XML passed"));
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(def = virDomainDefParseString(dom_xml, cfg->caps, driver->xmlopt,
|
2014-11-18 16:44:00 +00:00
|
|
|
VIR_DOMAIN_DEF_PARSE_INACTIVE)))
|
2014-05-08 21:56:51 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (dname) {
|
|
|
|
name = def->name;
|
|
|
|
if (VIR_STRDUP(def->name, dname) < 0) {
|
|
|
|
virDomainDefFree(def);
|
|
|
|
def = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
virObjectUnref(cfg);
|
|
|
|
VIR_FREE(name);
|
|
|
|
return def;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
libxlDomainMigrationPrepare(virConnectPtr dconn,
|
2014-07-08 17:15:34 +00:00
|
|
|
virDomainDefPtr *def,
|
2014-05-08 21:56:51 +00:00
|
|
|
const char *uri_in,
|
|
|
|
char **uri_out,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
libxlDriverPrivatePtr driver = dconn->privateData;
|
|
|
|
virDomainObjPtr vm = NULL;
|
|
|
|
char *hostname = NULL;
|
|
|
|
unsigned short port;
|
|
|
|
char portstr[100];
|
|
|
|
virURIPtr uri = NULL;
|
|
|
|
virNetSocketPtr *socks = NULL;
|
|
|
|
size_t nsocks = 0;
|
|
|
|
int nsocks_listen = 0;
|
2015-07-15 22:35:50 +00:00
|
|
|
libxlMigrationDstArgs *args = NULL;
|
2014-05-08 21:56:51 +00:00
|
|
|
size_t i;
|
|
|
|
int ret = -1;
|
|
|
|
|
2014-07-08 17:15:34 +00:00
|
|
|
if (!(vm = virDomainObjListAdd(driver->domains, *def,
|
2014-05-08 21:56:51 +00:00
|
|
|
driver->xmlopt,
|
|
|
|
VIR_DOMAIN_OBJ_LIST_ADD_LIVE |
|
|
|
|
VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE,
|
|
|
|
NULL)))
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-07-08 17:15:34 +00:00
|
|
|
*def = NULL;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
/* Create socket connection to receive migration data */
|
|
|
|
if (!uri_in) {
|
|
|
|
if ((hostname = virGetHostname()) == NULL)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
if (STRPREFIX(hostname, "localhost")) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("hostname on destination resolved to localhost,"
|
|
|
|
" but migration requires an FQDN"));
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
if (virAsprintf(uri_out, "tcp://%s:%d", hostname, port) < 0)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
} else {
|
|
|
|
if (!(STRPREFIX(uri_in, "tcp://"))) {
|
|
|
|
/* not full URI, add prefix tcp:// */
|
|
|
|
char *tmp;
|
|
|
|
if (virAsprintf(&tmp, "tcp://%s", uri_in) < 0)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
uri = virURIParse(tmp);
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
} else {
|
|
|
|
uri = virURIParse(uri_in);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uri == NULL) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("unable to parse URI: %s"),
|
|
|
|
uri_in);
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (uri->server == NULL) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("missing host in migration URI: %s"),
|
|
|
|
uri_in);
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
} else {
|
|
|
|
hostname = uri->server;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uri->port == 0) {
|
|
|
|
if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
} else {
|
|
|
|
port = uri->port;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (virAsprintf(uri_out, "tcp://%s:%d", hostname, port) < 0)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
snprintf(portstr, sizeof(portstr), "%d", port);
|
|
|
|
|
2015-05-21 14:51:28 +00:00
|
|
|
if (virNetSocketNewListenTCP(hostname, portstr,
|
|
|
|
AF_UNSPEC,
|
|
|
|
&socks, &nsocks) < 0) {
|
2014-05-08 21:56:51 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Fail to create socket for incoming migration"));
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (libxlMigrationDstArgsInitialize() < 0)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
if (!(args = virObjectNew(libxlMigrationDstArgsClass)))
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
args->conn = dconn;
|
|
|
|
args->vm = vm;
|
|
|
|
args->flags = flags;
|
|
|
|
args->socks = socks;
|
|
|
|
args->nsocks = nsocks;
|
|
|
|
|
|
|
|
for (i = 0; i < nsocks; i++) {
|
|
|
|
if (virNetSocketSetBlocking(socks[i], true) < 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (virNetSocketListen(socks[i], 1) < 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (virNetSocketAddIOCallback(socks[i],
|
|
|
|
VIR_EVENT_HANDLE_READABLE,
|
2014-11-12 22:32:02 +00:00
|
|
|
libxlMigrateReceive,
|
2014-05-08 21:56:51 +00:00
|
|
|
args,
|
2015-07-15 22:35:50 +00:00
|
|
|
NULL) < 0)
|
2014-05-08 21:56:51 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
nsocks_listen++;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!nsocks_listen)
|
2014-07-08 16:59:39 +00:00
|
|
|
goto error;
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
goto done;
|
|
|
|
|
2014-07-08 16:59:39 +00:00
|
|
|
error:
|
2014-05-08 21:56:51 +00:00
|
|
|
for (i = 0; i < nsocks; i++) {
|
|
|
|
virNetSocketClose(socks[i]);
|
|
|
|
virObjectUnref(socks[i]);
|
|
|
|
}
|
2015-05-01 11:25:39 +00:00
|
|
|
VIR_FREE(socks);
|
2015-07-15 22:35:50 +00:00
|
|
|
virObjectUnref(args);
|
|
|
|
|
2014-07-08 17:15:34 +00:00
|
|
|
/* Remove virDomainObj from domain list */
|
|
|
|
if (vm) {
|
|
|
|
virDomainObjListRemove(driver->domains, vm);
|
|
|
|
vm = NULL;
|
|
|
|
}
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
done:
|
2014-08-27 19:22:33 +00:00
|
|
|
if (!uri_in)
|
|
|
|
VIR_FREE(hostname);
|
|
|
|
else
|
|
|
|
virURIFree(uri);
|
2014-05-08 21:56:51 +00:00
|
|
|
if (vm)
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-02-05 20:45:02 +00:00
|
|
|
/* This function is a simplification of virDomainMigrateVersion3Full
|
|
|
|
* excluding tunnel support and restricting it to migration v3
|
|
|
|
* with params since it was the first to be introduced in libxl.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
libxlDoMigrateP2P(libxlDriverPrivatePtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
virConnectPtr sconn,
|
|
|
|
const char *xmlin,
|
|
|
|
virConnectPtr dconn,
|
|
|
|
const char *dconnuri ATTRIBUTE_UNUSED,
|
|
|
|
const char *dname,
|
|
|
|
const char *uri,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
virDomainPtr ddomain = NULL;
|
|
|
|
virTypedParameterPtr params = NULL;
|
|
|
|
int nparams = 0;
|
|
|
|
int maxparams = 0;
|
|
|
|
char *uri_out = NULL;
|
|
|
|
char *dom_xml = NULL;
|
|
|
|
unsigned long destflags;
|
|
|
|
bool cancelled = true;
|
|
|
|
virErrorPtr orig_err = NULL;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
dom_xml = libxlDomainMigrationBegin(sconn, vm, xmlin);
|
|
|
|
if (!dom_xml)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_XML, dom_xml) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (dname &&
|
|
|
|
virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_NAME, dname) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (uri &&
|
|
|
|
virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_URI, uri) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
/* We don't require the destination to have P2P support
|
|
|
|
* as it looks to be normal migration from the receiver perpective.
|
|
|
|
*/
|
|
|
|
destflags = flags & ~(VIR_MIGRATE_PEER2PEER);
|
|
|
|
|
|
|
|
VIR_DEBUG("Prepare3");
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
ret = dconn->driver->domainMigratePrepare3Params
|
|
|
|
(dconn, params, nparams, NULL, 0, NULL, NULL, &uri_out, destflags);
|
|
|
|
virObjectLock(vm);
|
|
|
|
|
|
|
|
if (ret == -1)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (uri_out) {
|
|
|
|
if (virTypedParamsReplaceString(¶ms, &nparams,
|
|
|
|
VIR_MIGRATE_PARAM_URI, uri_out) < 0) {
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
goto finish;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("domainMigratePrepare3 did not set uri"));
|
|
|
|
goto finish;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_DEBUG("Perform3 uri=%s", NULLSTR(uri_out));
|
|
|
|
ret = libxlDomainMigrationPerform(driver, vm, NULL, NULL,
|
|
|
|
uri_out, NULL, flags);
|
|
|
|
|
|
|
|
if (ret < 0)
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
|
|
|
cancelled = (ret < 0);
|
|
|
|
|
|
|
|
finish:
|
|
|
|
VIR_DEBUG("Finish3 ret=%d", ret);
|
|
|
|
if (virTypedParamsGetString(params, nparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_NAME, NULL) <= 0 &&
|
|
|
|
virTypedParamsReplaceString(¶ms, &nparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_NAME,
|
|
|
|
vm->def->name) < 0) {
|
|
|
|
ddomain = NULL;
|
|
|
|
} else {
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
ddomain = dconn->driver->domainMigrateFinish3Params
|
|
|
|
(dconn, params, nparams, NULL, 0, NULL, NULL,
|
|
|
|
destflags, cancelled);
|
|
|
|
virObjectLock(vm);
|
|
|
|
}
|
|
|
|
|
|
|
|
cancelled = (ddomain == NULL);
|
|
|
|
|
|
|
|
/* If Finish3Params set an error, and we don't have an earlier
|
|
|
|
* one we need to preserve it in case confirm3 overwrites
|
|
|
|
*/
|
|
|
|
if (!orig_err)
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
|
|
|
VIR_DEBUG("Confirm3 cancelled=%d vm=%p", cancelled, vm);
|
|
|
|
ret = libxlDomainMigrationConfirm(driver, vm, flags, cancelled);
|
|
|
|
|
|
|
|
if (ret < 0)
|
|
|
|
VIR_WARN("Guest %s probably left in 'paused' state on source",
|
|
|
|
vm->def->name);
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
if (ddomain) {
|
|
|
|
virObjectUnref(ddomain);
|
|
|
|
ret = 0;
|
|
|
|
} else {
|
|
|
|
ret = -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_FREE(dom_xml);
|
|
|
|
VIR_FREE(uri_out);
|
|
|
|
virTypedParamsFree(params, nparams);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int virConnectCredType[] = {
|
|
|
|
VIR_CRED_AUTHNAME,
|
|
|
|
VIR_CRED_PASSPHRASE,
|
|
|
|
};
|
|
|
|
|
|
|
|
static virConnectAuth virConnectAuthConfig = {
|
|
|
|
.credtype = virConnectCredType,
|
|
|
|
.ncredtype = ARRAY_CARDINALITY(virConnectCredType),
|
|
|
|
};
|
|
|
|
|
|
|
|
/* On P2P mode there is only the Perform3 phase and we need to handle
|
|
|
|
* the connection with the destination libvirtd and perform the migration.
|
|
|
|
* Here we first tackle the first part of it, and libxlDoMigrationP2P handles
|
|
|
|
* the migration process with an established virConnectPtr to the destination.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
libxlDomainMigrationPerformP2P(libxlDriverPrivatePtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
virConnectPtr sconn,
|
|
|
|
const char *xmlin,
|
|
|
|
const char *dconnuri,
|
|
|
|
const char *uri_str ATTRIBUTE_UNUSED,
|
|
|
|
const char *dname,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
bool useParams;
|
|
|
|
virConnectPtr dconn = NULL;
|
|
|
|
virErrorPtr orig_err = NULL;
|
2016-02-05 20:45:03 +00:00
|
|
|
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
|
2016-02-05 20:45:02 +00:00
|
|
|
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
dconn = virConnectOpenAuth(dconnuri, &virConnectAuthConfig, 0);
|
|
|
|
virObjectLock(vm);
|
|
|
|
|
|
|
|
if (dconn == NULL) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
|
|
|
_("Failed to connect to remote libvirt URI %s: %s"),
|
|
|
|
dconnuri, virGetLastErrorMessage());
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-02-05 20:45:03 +00:00
|
|
|
if (virConnectSetKeepAlive(dconn, cfg->keepAliveInterval,
|
|
|
|
cfg->keepAliveCount) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2016-02-05 20:45:02 +00:00
|
|
|
virObjectUnlock(vm);
|
|
|
|
useParams = VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
|
|
|
|
VIR_DRV_FEATURE_MIGRATION_PARAMS);
|
|
|
|
virObjectLock(vm);
|
|
|
|
|
|
|
|
if (!useParams) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Destination libvirt does not support migration with extensible parameters"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = libxlDoMigrateP2P(driver, vm, sconn, xmlin, dconn, dconnuri,
|
|
|
|
dname, uri_str, flags);
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
virObjectUnref(dconn);
|
2016-02-05 20:45:03 +00:00
|
|
|
virObjectUnref(cfg);
|
2016-02-05 20:45:02 +00:00
|
|
|
virObjectLock(vm);
|
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-05-08 21:56:51 +00:00
|
|
|
int
|
|
|
|
libxlDomainMigrationPerform(libxlDriverPrivatePtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *dom_xml ATTRIBUTE_UNUSED,
|
|
|
|
const char *dconnuri ATTRIBUTE_UNUSED,
|
|
|
|
const char *uri_str,
|
|
|
|
const char *dname ATTRIBUTE_UNUSED,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
2015-04-14 20:38:46 +00:00
|
|
|
libxlDomainObjPrivatePtr priv = vm->privateData;
|
2014-05-08 21:56:51 +00:00
|
|
|
char *hostname = NULL;
|
|
|
|
unsigned short port = 0;
|
|
|
|
char portstr[100];
|
|
|
|
virURIPtr uri = NULL;
|
|
|
|
virNetSocketPtr sock;
|
|
|
|
int sockfd = -1;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
/* parse dst host:port from uri */
|
|
|
|
uri = virURIParse(uri_str);
|
|
|
|
if (uri == NULL || uri->server == NULL || uri->port == 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
hostname = uri->server;
|
|
|
|
port = uri->port;
|
|
|
|
snprintf(portstr, sizeof(portstr), "%d", port);
|
|
|
|
|
|
|
|
/* socket connect to dst host:port */
|
2015-05-21 14:51:28 +00:00
|
|
|
if (virNetSocketNewConnectTCP(hostname, portstr,
|
|
|
|
AF_UNSPEC,
|
2015-09-03 16:14:20 +00:00
|
|
|
&sock) < 0)
|
2014-05-08 21:56:51 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virNetSocketSetBlocking(sock, true) < 0) {
|
|
|
|
virObjectUnref(sock);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
sockfd = virNetSocketDupFD(sock, true);
|
|
|
|
virObjectUnref(sock);
|
|
|
|
|
2015-04-14 20:38:46 +00:00
|
|
|
if (virDomainLockProcessPause(driver->lockManager, vm, &priv->lockState) < 0)
|
|
|
|
VIR_WARN("Unable to release lease on %s", vm->def->name);
|
|
|
|
VIR_DEBUG("Preserving lock state '%s'", NULLSTR(priv->lockState));
|
|
|
|
|
2014-05-08 21:56:51 +00:00
|
|
|
/* suspend vm and send saved data to dst through socket fd */
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
ret = libxlDoMigrateSend(driver, vm, flags, sockfd);
|
|
|
|
virObjectLock(vm);
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
VIR_FORCE_CLOSE(sockfd);
|
|
|
|
virURIFree(uri);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
virDomainPtr
|
|
|
|
libxlDomainMigrationFinish(virConnectPtr dconn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
unsigned int flags,
|
|
|
|
int cancelled)
|
|
|
|
{
|
|
|
|
libxlDriverPrivatePtr driver = dconn->privateData;
|
|
|
|
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
|
|
|
|
libxlDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
virObjectEventPtr event = NULL;
|
|
|
|
virDomainPtr dom = NULL;
|
|
|
|
|
|
|
|
virPortAllocatorRelease(driver->migrationPorts, priv->migrationPort);
|
|
|
|
priv->migrationPort = 0;
|
|
|
|
|
|
|
|
if (cancelled)
|
|
|
|
goto cleanup;
|
|
|
|
|
2014-11-13 00:52:02 +00:00
|
|
|
/* Check if domain is alive */
|
|
|
|
if (!virDomainObjIsActive(vm)) {
|
|
|
|
/* Migration failed if domain is inactive */
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
|
|
|
"%s", _("Migration failed. Domain is not running "
|
|
|
|
"on destination host"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Unpause if requested */
|
2014-05-08 21:56:51 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_PAUSED)) {
|
2015-02-11 23:40:07 +00:00
|
|
|
if (libxl_domain_unpause(cfg->ctx, vm->def->id) != 0) {
|
2014-05-08 21:56:51 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Failed to unpause domain"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_RUNNING,
|
|
|
|
VIR_DOMAIN_RUNNING_MIGRATED);
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED_MIGRATED);
|
|
|
|
} else {
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, VIR_DOMAIN_PAUSED_USER);
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED_PAUSED);
|
|
|
|
}
|
|
|
|
|
2014-08-28 18:56:33 +00:00
|
|
|
if (event) {
|
|
|
|
libxlDomainEventQueue(driver, event);
|
|
|
|
event = NULL;
|
|
|
|
}
|
|
|
|
|
2016-02-04 12:32:45 +00:00
|
|
|
if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, cfg->caps) < 0)
|
2014-11-13 00:52:02 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2014-05-08 21:56:51 +00:00
|
|
|
dom = virGetDomain(dconn, vm->def->name, vm->def->uuid);
|
|
|
|
|
2014-11-13 00:52:02 +00:00
|
|
|
cleanup:
|
2014-05-08 21:56:51 +00:00
|
|
|
if (dom == NULL) {
|
2015-03-04 00:54:50 +00:00
|
|
|
libxlDomainDestroyInternal(driver, vm);
|
2015-07-07 18:29:24 +00:00
|
|
|
libxlDomainCleanup(driver, vm);
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF,
|
|
|
|
VIR_DOMAIN_SHUTOFF_FAILED);
|
2014-05-08 21:56:51 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED,
|
|
|
|
VIR_DOMAIN_EVENT_STOPPED_FAILED);
|
2014-11-13 00:52:02 +00:00
|
|
|
if (!vm->persistent)
|
|
|
|
virDomainObjListRemove(driver->domains, vm);
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (event)
|
|
|
|
libxlDomainEventQueue(driver, event);
|
|
|
|
virObjectUnref(cfg);
|
|
|
|
return dom;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
libxlDomainMigrationConfirm(libxlDriverPrivatePtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
unsigned int flags,
|
|
|
|
int cancelled)
|
|
|
|
{
|
|
|
|
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
|
|
|
|
virObjectEventPtr event = NULL;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
if (cancelled) {
|
2015-02-11 23:40:07 +00:00
|
|
|
if (libxl_domain_resume(cfg->ctx, vm->def->id, 1, 0) == 0) {
|
2014-05-08 21:56:51 +00:00
|
|
|
ret = 0;
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG("Unable to resume domain '%s' after failed migration",
|
|
|
|
vm->def->name);
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_PAUSED,
|
|
|
|
VIR_DOMAIN_PAUSED_MIGRATION);
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_SUSPENDED,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED);
|
2016-02-04 12:32:45 +00:00
|
|
|
ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, cfg->caps));
|
2014-05-08 21:56:51 +00:00
|
|
|
}
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2015-03-04 00:54:50 +00:00
|
|
|
libxlDomainDestroyInternal(driver, vm);
|
2015-07-07 18:29:24 +00:00
|
|
|
libxlDomainCleanup(driver, vm);
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF,
|
|
|
|
VIR_DOMAIN_SHUTOFF_MIGRATED);
|
2014-05-08 21:56:51 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED,
|
|
|
|
VIR_DOMAIN_EVENT_STOPPED_MIGRATED);
|
|
|
|
|
|
|
|
VIR_DEBUG("Domain '%s' successfully migrated", vm->def->name);
|
|
|
|
|
|
|
|
if (flags & VIR_MIGRATE_UNDEFINE_SOURCE)
|
|
|
|
virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm);
|
|
|
|
|
libxl: fix crash in migrate confirm for transient domains
In libxlDomainMigrationConfirm(), a transient domain is removed
from the domain list after successful migration. Later in cleanup,
the domain object is unlocked, resulting in a crash
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fb4208ed700 (LWP 12044)]
0x00007fb4267251e6 in virClassIsDerivedFrom (klass=0xdeadbeef,
parent=0x7fb42830d0c0) at util/virobject.c:169
169 if (klass->magic == parent->magic)
(gdb) bt
0 0x00007fb4267251e6 in virClassIsDerivedFrom (klass=0xdeadbeef,
parent=0x7fb42830d0c0) at util/virobject.c:169
1 0x00007fb42672591b in virObjectIsClass (anyobj=0x7fb4100082b0,
klass=0x7fb42830d0c0) at util/virobject.c:365
2 0x00007fb42672583c in virObjectUnlock (anyobj=0x7fb4100082b0)
at util/virobject.c:338
3 0x00007fb41a8c7d7a in libxlDomainMigrationConfirm (driver=0x7fb4100404c0,
vm=0x7fb4100082b0, flags=1, cancelled=0) at libxl/libxl_migration.c:583
Fix by setting the virDomainObjPtr to NULL after removing it from
the domain list.
2014-07-08 21:34:48 +00:00
|
|
|
if (!vm->persistent || (flags & VIR_MIGRATE_UNDEFINE_SOURCE)) {
|
2014-05-08 21:56:51 +00:00
|
|
|
virDomainObjListRemove(driver->domains, vm);
|
libxl: fix crash in migrate confirm for transient domains
In libxlDomainMigrationConfirm(), a transient domain is removed
from the domain list after successful migration. Later in cleanup,
the domain object is unlocked, resulting in a crash
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fb4208ed700 (LWP 12044)]
0x00007fb4267251e6 in virClassIsDerivedFrom (klass=0xdeadbeef,
parent=0x7fb42830d0c0) at util/virobject.c:169
169 if (klass->magic == parent->magic)
(gdb) bt
0 0x00007fb4267251e6 in virClassIsDerivedFrom (klass=0xdeadbeef,
parent=0x7fb42830d0c0) at util/virobject.c:169
1 0x00007fb42672591b in virObjectIsClass (anyobj=0x7fb4100082b0,
klass=0x7fb42830d0c0) at util/virobject.c:365
2 0x00007fb42672583c in virObjectUnlock (anyobj=0x7fb4100082b0)
at util/virobject.c:338
3 0x00007fb41a8c7d7a in libxlDomainMigrationConfirm (driver=0x7fb4100404c0,
vm=0x7fb4100082b0, flags=1, cancelled=0) at libxl/libxl_migration.c:583
Fix by setting the virDomainObjPtr to NULL after removing it from
the domain list.
2014-07-08 21:34:48 +00:00
|
|
|
vm = NULL;
|
|
|
|
}
|
2014-05-08 21:56:51 +00:00
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
if (event)
|
|
|
|
libxlDomainEventQueue(driver, event);
|
|
|
|
if (vm)
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
virObjectUnref(cfg);
|
|
|
|
return ret;
|
|
|
|
}
|