libvirt/tests/qemuxml2argvdata/virtio-rng-egd-crash.xml

<domain type='qemu'>
  <name>QEMUGuest1</name>
  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
  <memory unit='KiB'>219100</memory>
  <currentMemory unit='KiB'>219100</currentMemory>
  <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
  <os>
    <type arch='i686' machine='pc'>hvm</type>
    <boot dev='hd'/>
  </os>
  <clock offset='utc'/>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>destroy</on_crash>
  <devices>
    <emulator>/usr/bin/qemu-system-i386</emulator>
    <controller type='usb' index='0'/>
    <controller type='pci' index='0' model='pci-root'/>
    <memballoon model='virtio'/>
    <rng model='virtio'>
      <backend model='egd' type='unix'>
        <!-- https://bugzilla.redhat.com/show_bug.cgi?id=1012196 -->
        <source mode='connect' host='1.2.3.4' service='1234'/>
      </backend>
    </rng>
  </devices>
</domain>
conf: Don't crash on invalid chardev source definition of RNGs and other Since commit 297c99a5 an invalid source definition XML of a character device that is used as backend for RNG devices, smartcards and redirdevs causes crash of the daemon when parsing such a definition. The device types mentioned above are not a part of a regular character device but are backends for other types. Thus when parsing such device NULL is passed as the argument @chr_def. Later when checking the validity of the definition @chr_def was dereferenced when parsing a UNIX socket backend with missing path of the socket and crashed the daemon. Sample offending configuration: <devices> ... <rng model='virtio'> <backend model='egd' type='unix'> <source mode='bind' service='1024'/> </backend> </rng> </devices> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1012196 2013-09-26 06:12:39 +00:00			`<domain type='qemu'>`
			`<name>QEMUGuest1</name>`
			`<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>`
			`<memory unit='KiB'>219100</memory>`
			`<currentMemory unit='KiB'>219100</currentMemory>`
			`<vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>`
			`<os>`
			`<type arch='i686' machine='pc'>hvm</type>`
			`<boot dev='hd'/>`
			`</os>`
			`<clock offset='utc'/>`
			`<on_poweroff>destroy</on_poweroff>`
			`<on_reboot>restart</on_reboot>`
			`<on_crash>destroy</on_crash>`
			`<devices>`
tests: fix name of 32-bit x86 QEMU binary The 32-bit x86 binary is called qemu-system-i386, not qemu-system-i686. This mistake across many test XML files was not noticed because the mistake was also made in testutilsqemu.c when mocking the capabilities. Reviewed-by: Erik Skultety <eskultet@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 2019-11-29 16:33:37 +00:00			`<emulator>/usr/bin/qemu-system-i386</emulator>`
conf: Don't crash on invalid chardev source definition of RNGs and other Since commit 297c99a5 an invalid source definition XML of a character device that is used as backend for RNG devices, smartcards and redirdevs causes crash of the daemon when parsing such a definition. The device types mentioned above are not a part of a regular character device but are backends for other types. Thus when parsing such device NULL is passed as the argument @chr_def. Later when checking the validity of the definition @chr_def was dereferenced when parsing a UNIX socket backend with missing path of the socket and crashed the daemon. Sample offending configuration: <devices> ... <rng model='virtio'> <backend model='egd' type='unix'> <source mode='bind' service='1024'/> </backend> </rng> </devices> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1012196 2013-09-26 06:12:39 +00:00			`<controller type='usb' index='0'/>`
			`<controller type='pci' index='0' model='pci-root'/>`
			`<memballoon model='virtio'/>`
			`<rng model='virtio'>`
			`<backend model='egd' type='unix'>`
			`<!-- https://bugzilla.redhat.com/show_bug.cgi?id=1012196 -->`
			`<source mode='connect' host='1.2.3.4' service='1234'/>`
			`</backend>`
			`</rng>`
			`</devices>`
			`</domain>`