External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-09-14 03:35:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
8a21339e63
libvirt/tests/virstoragetestdata/out/qcow2-symlinks

30 lines
526 B
Plaintext
Raw Normal View History

virstoragetest: Convert symlink and relative image testing use preformatted images Use prepared test images instead to simplify and clarify the code instead of rewriting existing images multiple times. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-08 14:30:52 +00:00
path:ABS_SRCDIR/virstoragetestdata/images/sub/link2
virstoragetest: Store output of TEST_CHAIN in output files The TEST_CHAIN cases were storing the expected output (or rather data to generate the expected output) in code. This made the code really hard to follow and even harder to modify to add new cases. This patch modifies the code to store the expected output in text files (using the same generator as we've used to) and uses 'virTestCompareToFile' to check the outputs. The result is that the code is way simpler and doesn't require fiddling with 'testFileData' structs when adding new cases. Additionally this removes mixing of code and declaration so we can stop disabling the warning for this file. Another advantage is that the tests are now named so it's easier to figure out if one of them breaks. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-06 12:13:29 +00:00
backingStoreRaw: ../sub/link1
capacity: 1024
encryption: 0
relPath:<null>
type:1
format:14
protocol:none
hostname:<null>
virstoragetest: Convert symlink and relative image testing use preformatted images Use prepared test images instead to simplify and clarify the code instead of rewriting existing images multiple times. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-08 14:30:52 +00:00
path:ABS_SRCDIR/virstoragetestdata/images/sub/../sub/link1
virstoragetest: Store output of TEST_CHAIN in output files The TEST_CHAIN cases were storing the expected output (or rather data to generate the expected output) in code. This made the code really hard to follow and even harder to modify to add new cases. This patch modifies the code to store the expected output in text files (using the same generator as we've used to) and uses 'virTestCompareToFile' to check the outputs. The result is that the code is way simpler and doesn't require fiddling with 'testFileData' structs when adding new cases. Additionally this removes mixing of code and declaration so we can stop disabling the warning for this file. Another advantage is that the tests are now named so it's easier to figure out if one of them breaks. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-06 12:13:29 +00:00
backingStoreRaw: ../raw
capacity: 1024
encryption: 0
relPath:../sub/link1
type:1
format:14
protocol:none
hostname:<null>
virstoragetest: Convert symlink and relative image testing use preformatted images Use prepared test images instead to simplify and clarify the code instead of rewriting existing images multiple times. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-08 14:30:52 +00:00
path:ABS_SRCDIR/virstoragetestdata/images/sub/../sub/../raw
virstoragetest: Store output of TEST_CHAIN in output files The TEST_CHAIN cases were storing the expected output (or rather data to generate the expected output) in code. This made the code really hard to follow and even harder to modify to add new cases. This patch modifies the code to store the expected output in text files (using the same generator as we've used to) and uses 'virTestCompareToFile' to check the outputs. The result is that the code is way simpler and doesn't require fiddling with 'testFileData' structs when adding new cases. Additionally this removes mixing of code and declaration so we can stop disabling the warning for this file. Another advantage is that the tests are now named so it's easier to figure out if one of them breaks. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-06 12:13:29 +00:00
backingStoreRaw: <null>
capacity: 0
encryption: 0
relPath:../raw
type:1
format:1
protocol:none
hostname:<null>
Reference in New Issue Copy Permalink