libvirt/tests/qemuxml2argvdata/firmware-manual-bios-rw.xml

<domain type='qemu'>
  <name>test-bios</name>
  <uuid>362d1fc1-df7d-193e-5c18-49a71bd1da66</uuid>
  <memory unit='KiB'>1048576</memory>
  <vcpu placement='static'>1</vcpu>
  <os>
    <type arch='x86_64' machine='pc'>hvm</type>
    <loader readonly='no' type='pflash'>/var/lib/libvirt/qemu/nvram/test-bios.fd</loader>
  </os>
  <features>
    <acpi/>
  </features>
  <devices>
    <emulator>/usr/bin/qemu-system-x86_64</emulator>
    <controller type='usb' model='none'/>
    <memballoon model='none'/>
  </devices>
</domain>
qemu: fix formatting of pflash readonly attribute When the <loader> had an explicit readonly='no' attribute we accidentally still marked the plfash as readonly due to the bad conversion from virTristateBool to bool. This was missed because the test cases run with no capabilities set and thus are validated the -drive approach for pflash configuration, not the -blockdev approach. This affected the following config: <os> <loader readonly='no' type='pflash'>/var/lib/libvirt/qemu/nvram/test-bios.fd</loader> </os> for the sake of completeness, we also add a test XML config with no readonly attribute at all, to demonstrate that the default for pflash is intended to be r/w. Reviewed-by: Ján Tomko <jtomko@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 2022-02-07 12:10:28 +00:00			`<domain type='qemu'>`
			`<name>test-bios</name>`
			`<uuid>362d1fc1-df7d-193e-5c18-49a71bd1da66</uuid>`
			`<memory unit='KiB'>1048576</memory>`
			`<vcpu placement='static'>1</vcpu>`
			`<os>`
			`<type arch='x86_64' machine='pc'>hvm</type>`
			`<loader readonly='no' type='pflash'>/var/lib/libvirt/qemu/nvram/test-bios.fd</loader>`
			`</os>`
			`<features>`
			`<acpi/>`
			`</features>`
			`<devices>`
			`<emulator>/usr/bin/qemu-system-x86_64</emulator>`
tests: Use minimal hardware for firmware tests When testing firmware selection, we don't really care about any of the hardware assigned to the VM, and in fact it's better to keep it as minimal as possible to make sure that the focus remains on the firmware bits. Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com> 2022-06-09 13:02:19 +00:00			`<controller type='usb' model='none'/>`
			`<memballoon model='none'/>`
qemu: fix formatting of pflash readonly attribute When the <loader> had an explicit readonly='no' attribute we accidentally still marked the plfash as readonly due to the bad conversion from virTristateBool to bool. This was missed because the test cases run with no capabilities set and thus are validated the -drive approach for pflash configuration, not the -blockdev approach. This affected the following config: <os> <loader readonly='no' type='pflash'>/var/lib/libvirt/qemu/nvram/test-bios.fd</loader> </os> for the sake of completeness, we also add a test XML config with no readonly attribute at all, to demonstrate that the default for pflash is intended to be r/w. Reviewed-by: Ján Tomko <jtomko@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 2022-02-07 12:10:28 +00:00			`</devices>`
			`</domain>`