2008-08-13 10:25:34 +00:00
|
|
|
/*
|
|
|
|
* Copyright IBM Corp. 2008
|
|
|
|
*
|
|
|
|
* lxc_controller.c: linux container process controller
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* David L. Leskovec <dlesko at linux.vnet.ibm.com>
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
|
|
#include <sys/epoll.h>
|
2008-08-13 10:52:15 +00:00
|
|
|
#include <sys/wait.h>
|
|
|
|
#include <sys/socket.h>
|
2008-08-20 20:55:32 +00:00
|
|
|
#include <sys/types.h>
|
|
|
|
#include <sys/un.h>
|
2008-08-13 10:25:34 +00:00
|
|
|
#include <unistd.h>
|
2008-08-13 10:52:15 +00:00
|
|
|
#include <paths.h>
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include <signal.h>
|
2008-08-20 20:55:32 +00:00
|
|
|
#include <getopt.h>
|
2009-04-22 14:26:50 +00:00
|
|
|
#include <sys/mount.h>
|
2008-08-13 10:25:34 +00:00
|
|
|
|
2009-06-29 17:09:42 +00:00
|
|
|
#if HAVE_CAPNG
|
2010-03-09 18:22:22 +00:00
|
|
|
# include <cap-ng.h>
|
2009-06-29 17:09:42 +00:00
|
|
|
#endif
|
|
|
|
|
2008-11-04 22:30:33 +00:00
|
|
|
#include "virterror_internal.h"
|
2008-11-06 16:36:07 +00:00
|
|
|
#include "logging.h"
|
2008-08-13 10:25:34 +00:00
|
|
|
#include "util.h"
|
|
|
|
|
|
|
|
#include "lxc_conf.h"
|
2008-08-13 10:52:15 +00:00
|
|
|
#include "lxc_container.h"
|
|
|
|
#include "veth.h"
|
|
|
|
#include "memory.h"
|
|
|
|
#include "util.h"
|
2008-08-13 10:25:34 +00:00
|
|
|
|
2009-01-20 17:13:33 +00:00
|
|
|
#define VIR_FROM_THIS VIR_FROM_LXC
|
|
|
|
|
2008-10-03 16:46:01 +00:00
|
|
|
struct cgroup_device_policy {
|
|
|
|
char type;
|
|
|
|
int major;
|
|
|
|
int minor;
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* lxcSetContainerResources
|
|
|
|
* @def: pointer to virtual machine structure
|
|
|
|
*
|
|
|
|
* Creates a cgroup for the container, moves the task inside,
|
|
|
|
* and sets resource limits
|
|
|
|
*
|
|
|
|
* Returns 0 on success or -1 in case of error
|
|
|
|
*/
|
|
|
|
static int lxcSetContainerResources(virDomainDefPtr def)
|
|
|
|
{
|
2009-07-10 10:40:04 +00:00
|
|
|
virCgroupPtr driver;
|
2008-10-03 16:46:01 +00:00
|
|
|
virCgroupPtr cgroup;
|
|
|
|
int rc = -1;
|
|
|
|
int i;
|
|
|
|
struct cgroup_device_policy devices[] = {
|
|
|
|
{'c', LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_NULL},
|
|
|
|
{'c', LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_ZERO},
|
|
|
|
{'c', LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_FULL},
|
|
|
|
{'c', LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_RANDOM},
|
|
|
|
{'c', LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_URANDOM},
|
2010-03-04 11:15:42 +00:00
|
|
|
{'c', LXC_DEV_MAJ_TTY, LXC_DEV_MIN_TTY},
|
2008-10-03 16:46:01 +00:00
|
|
|
{'c', LXC_DEV_MAJ_TTY, LXC_DEV_MIN_CONSOLE},
|
2009-05-08 10:22:46 +00:00
|
|
|
{'c', LXC_DEV_MAJ_TTY, LXC_DEV_MIN_PTMX},
|
2008-10-03 16:46:01 +00:00
|
|
|
{0, 0, 0}};
|
|
|
|
|
2009-07-10 10:40:04 +00:00
|
|
|
rc = virCgroupForDriver("lxc", &driver, 1, 0);
|
|
|
|
if (rc != 0) {
|
2009-07-31 13:37:25 +00:00
|
|
|
/* Skip all if no driver cgroup is configured */
|
|
|
|
if (rc == -ENXIO || rc == -ENOENT)
|
|
|
|
return 0;
|
|
|
|
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc, "%s",
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to get cgroup for driver"));
|
2009-07-10 10:40:04 +00:00
|
|
|
return rc;
|
|
|
|
}
|
2008-10-03 16:46:01 +00:00
|
|
|
|
2009-07-10 10:40:04 +00:00
|
|
|
rc = virCgroupForDomain(driver, def->name, &cgroup, 1);
|
2008-10-03 16:46:01 +00:00
|
|
|
if (rc != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc,
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to create cgroup for domain %s"),
|
|
|
|
def->name);
|
2009-07-10 10:40:04 +00:00
|
|
|
goto cleanup;
|
2008-10-03 16:46:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
rc = virCgroupSetMemory(cgroup, def->maxmem);
|
2009-07-31 13:37:25 +00:00
|
|
|
if (rc != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc,
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to set memory limit for domain %s"),
|
|
|
|
def->name);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-10-03 16:46:01 +00:00
|
|
|
|
|
|
|
rc = virCgroupDenyAllDevices(cgroup);
|
2009-07-31 13:37:25 +00:00
|
|
|
if (rc != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc,
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to deny devices for domain %s"),
|
|
|
|
def->name);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-10-03 16:46:01 +00:00
|
|
|
|
|
|
|
for (i = 0; devices[i].type != 0; i++) {
|
|
|
|
struct cgroup_device_policy *dev = &devices[i];
|
|
|
|
rc = virCgroupAllowDevice(cgroup,
|
|
|
|
dev->type,
|
|
|
|
dev->major,
|
|
|
|
dev->minor);
|
2009-07-31 13:37:25 +00:00
|
|
|
if (rc != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc,
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to allow device %c:%d:%d for domain %s"),
|
|
|
|
dev->type, dev->major, dev->minor, def->name);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-10-03 16:46:01 +00:00
|
|
|
}
|
|
|
|
|
2008-10-21 16:46:47 +00:00
|
|
|
rc = virCgroupAllowDeviceMajor(cgroup, 'c', LXC_DEV_MAJ_PTY);
|
2009-07-31 13:37:25 +00:00
|
|
|
if (rc != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc,
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to allow PYT devices for domain %s"),
|
|
|
|
def->name);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-10-21 16:46:47 +00:00
|
|
|
|
2008-10-03 16:46:01 +00:00
|
|
|
rc = virCgroupAddTask(cgroup, getpid());
|
|
|
|
if (rc != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(-rc,
|
2009-07-31 13:37:25 +00:00
|
|
|
_("Unable to add task %d to cgroup for domain %s"),
|
|
|
|
getpid(), def->name);
|
2008-10-03 16:46:01 +00:00
|
|
|
}
|
|
|
|
|
2009-07-10 10:40:04 +00:00
|
|
|
cleanup:
|
|
|
|
virCgroupFree(&driver);
|
2008-10-03 16:46:01 +00:00
|
|
|
virCgroupFree(&cgroup);
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
static char*lxcMonitorPath(virDomainDefPtr def)
|
|
|
|
{
|
|
|
|
char *sockpath;
|
2008-12-23 13:03:29 +00:00
|
|
|
|
|
|
|
if (virAsprintf(&sockpath, "%s/%s.sock",
|
|
|
|
LXC_STATE_DIR, def->name) < 0)
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2008-08-20 20:55:32 +00:00
|
|
|
return sockpath;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int lxcMonitorServer(const char *sockpath)
|
|
|
|
{
|
|
|
|
int fd;
|
|
|
|
struct sockaddr_un addr;
|
|
|
|
|
|
|
|
if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-01-20 17:13:33 +00:00
|
|
|
_("failed to create server socket '%s'"),
|
|
|
|
sockpath);
|
2008-08-20 20:55:32 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
unlink(sockpath);
|
|
|
|
memset(&addr, 0, sizeof(addr));
|
|
|
|
addr.sun_family = AF_UNIX;
|
2009-08-03 12:37:44 +00:00
|
|
|
if (virStrcpyStatic(addr.sun_path, sockpath) == NULL) {
|
2010-02-09 18:22:56 +00:00
|
|
|
lxcError(VIR_ERR_INTERNAL_ERROR,
|
2009-08-03 12:37:44 +00:00
|
|
|
_("Socket path %s too long for destination"), sockpath);
|
|
|
|
goto error;
|
|
|
|
}
|
2008-08-20 20:55:32 +00:00
|
|
|
|
|
|
|
if (bind(fd, (struct sockaddr *) &addr, sizeof(addr)) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-01-20 17:13:33 +00:00
|
|
|
_("failed to bind server socket '%s'"),
|
|
|
|
sockpath);
|
2008-08-20 20:55:32 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
if (listen(fd, 30 /* backlog */ ) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-01-20 17:13:33 +00:00
|
|
|
_("failed to listen server socket %s"),
|
|
|
|
sockpath);
|
2008-08-20 20:55:32 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
return fd;
|
|
|
|
|
|
|
|
error:
|
|
|
|
if (fd != -1)
|
|
|
|
close(fd);
|
|
|
|
return -1;
|
|
|
|
}
|
2008-08-13 10:25:34 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* lxcFdForward:
|
|
|
|
* @readFd: file descriptor to read
|
|
|
|
* @writeFd: file desriptor to write
|
|
|
|
*
|
|
|
|
* Reads 1 byte of data from readFd and writes to writeFd.
|
|
|
|
*
|
|
|
|
* Returns 0 on success, EAGAIN if returned on read, or -1 in case of error
|
|
|
|
*/
|
|
|
|
static int lxcFdForward(int readFd, int writeFd)
|
|
|
|
{
|
|
|
|
int rc = -1;
|
|
|
|
char buf[2];
|
|
|
|
|
|
|
|
if (1 != (saferead(readFd, buf, 1))) {
|
|
|
|
if (EAGAIN == errno) {
|
|
|
|
rc = EAGAIN;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-01-20 17:13:33 +00:00
|
|
|
_("read of fd %d failed"),
|
|
|
|
readFd);
|
2008-08-13 10:25:34 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (1 != (safewrite(writeFd, buf, 1))) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-01-20 17:13:33 +00:00
|
|
|
_("write to fd %d failed"),
|
|
|
|
writeFd);
|
2008-08-13 10:25:34 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
rc = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2009-06-29 17:09:42 +00:00
|
|
|
|
|
|
|
static int lxcControllerClearCapabilities(void)
|
|
|
|
{
|
|
|
|
#if HAVE_CAPNG
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
capng_clear(CAPNG_SELECT_BOTH);
|
|
|
|
|
|
|
|
if ((ret = capng_apply(CAPNG_SELECT_BOTH)) < 0) {
|
2010-02-09 18:22:56 +00:00
|
|
|
lxcError(VIR_ERR_INTERNAL_ERROR,
|
2009-06-29 17:09:42 +00:00
|
|
|
_("failed to apply capabilities: %d"), ret);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
#else
|
2010-05-19 10:00:18 +00:00
|
|
|
VIR_WARN0("libcap-ng support not compiled in, unable to clear capabilities");
|
2009-06-29 17:09:42 +00:00
|
|
|
#endif
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-08-13 10:25:34 +00:00
|
|
|
typedef struct _lxcTtyForwardFd_t {
|
|
|
|
int fd;
|
|
|
|
int active;
|
|
|
|
} lxcTtyForwardFd_t;
|
|
|
|
|
2010-05-20 12:30:36 +00:00
|
|
|
/* Return true if it is ok to ignore an accept-after-epoll syscall
|
|
|
|
that fails with the specified errno value. Else false. */
|
|
|
|
static bool
|
|
|
|
ignorable_epoll_accept_errno(int errnum)
|
|
|
|
{
|
|
|
|
return (errnum == EINVAL
|
|
|
|
|| errnum == ECONNABORTED
|
|
|
|
|| errnum == EAGAIN
|
|
|
|
|| errnum == EWOULDBLOCK);
|
|
|
|
}
|
|
|
|
|
2008-08-13 10:25:34 +00:00
|
|
|
/**
|
2009-11-05 12:35:13 +00:00
|
|
|
* lxcControllerMain
|
|
|
|
* @monitor: server socket fd to accept client requests
|
|
|
|
* @client: initial client which is the libvirtd daemon
|
|
|
|
* @appPty: open fd for application facing Pty
|
|
|
|
* @contPty: open fd for container facing Pty
|
2008-08-13 10:25:34 +00:00
|
|
|
*
|
|
|
|
* Forwards traffic between fds. Data read from appPty will be written to contPty
|
|
|
|
* This process loops forever.
|
|
|
|
* This uses epoll in edge triggered mode to avoid a hard loop on POLLHUP
|
|
|
|
* events when the user disconnects the virsh console via ctrl-]
|
|
|
|
*
|
|
|
|
* Returns 0 on success or -1 in case of error
|
|
|
|
*/
|
2008-08-13 10:52:15 +00:00
|
|
|
static int lxcControllerMain(int monitor,
|
|
|
|
int client,
|
|
|
|
int appPty,
|
|
|
|
int contPty)
|
2008-08-13 10:25:34 +00:00
|
|
|
{
|
|
|
|
int rc = -1;
|
|
|
|
int epollFd;
|
|
|
|
struct epoll_event epollEvent;
|
|
|
|
int numEvents;
|
|
|
|
int numActive = 0;
|
|
|
|
lxcTtyForwardFd_t fdArray[2];
|
|
|
|
int timeout = -1;
|
|
|
|
int curFdOff = 0;
|
|
|
|
int writeFdOff = 0;
|
|
|
|
|
|
|
|
fdArray[0].fd = appPty;
|
|
|
|
fdArray[0].active = 0;
|
|
|
|
fdArray[1].fd = contPty;
|
|
|
|
fdArray[1].active = 0;
|
2010-03-04 11:15:42 +00:00
|
|
|
VIR_ERROR("monitor=%d client=%d appPty=%d contPty=%d", monitor,client, appPty, contPty);
|
2008-08-13 10:25:34 +00:00
|
|
|
/* create the epoll fild descriptor */
|
|
|
|
epollFd = epoll_create(2);
|
|
|
|
if (0 > epollFd) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("epoll_create(2) failed"));
|
2008-08-13 10:25:34 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* add the file descriptors the epoll fd */
|
|
|
|
memset(&epollEvent, 0x00, sizeof(epollEvent));
|
|
|
|
epollEvent.events = EPOLLIN|EPOLLET; /* edge triggered */
|
|
|
|
epollEvent.data.fd = appPty;
|
|
|
|
if (0 > epoll_ctl(epollFd, EPOLL_CTL_ADD, appPty, &epollEvent)) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("epoll_ctl(appPty) failed"));
|
2008-08-13 10:25:34 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
epollEvent.data.fd = contPty;
|
|
|
|
if (0 > epoll_ctl(epollFd, EPOLL_CTL_ADD, contPty, &epollEvent)) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("epoll_ctl(contPty) failed"));
|
2008-08-13 10:25:34 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2008-08-13 10:52:15 +00:00
|
|
|
epollEvent.events = EPOLLIN;
|
|
|
|
epollEvent.data.fd = monitor;
|
|
|
|
if (0 > epoll_ctl(epollFd, EPOLL_CTL_ADD, monitor, &epollEvent)) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("epoll_ctl(monitor) failed"));
|
2008-08-13 10:52:15 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
epollEvent.events = EPOLLHUP;
|
|
|
|
epollEvent.data.fd = client;
|
|
|
|
if (0 > epoll_ctl(epollFd, EPOLL_CTL_ADD, client, &epollEvent)) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("epoll_ctl(client) failed"));
|
2008-08-13 10:52:15 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2008-08-13 10:25:34 +00:00
|
|
|
while (1) {
|
|
|
|
/* if active fd's, return if no events, else wait forever */
|
|
|
|
timeout = (numActive > 0) ? 0 : -1;
|
|
|
|
numEvents = epoll_wait(epollFd, &epollEvent, 1, timeout);
|
2008-08-13 10:52:15 +00:00
|
|
|
if (numEvents > 0) {
|
|
|
|
if (epollEvent.data.fd == monitor) {
|
|
|
|
int fd = accept(monitor, NULL, 0);
|
2010-05-20 12:30:36 +00:00
|
|
|
if (fd < 0) {
|
|
|
|
/* First reflex may be simply to declare accept failure
|
|
|
|
to be a fatal error. However, accept may fail when
|
|
|
|
a client quits between the above epoll_wait and here.
|
|
|
|
That case is not fatal, but rather to be expected,
|
|
|
|
if not common, so ignore it. */
|
|
|
|
if (ignorable_epoll_accept_errno(errno))
|
|
|
|
continue;
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("accept(monitor,...) failed"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
if (client != -1) { /* Already connected, so kick new one out */
|
|
|
|
close(fd);
|
|
|
|
continue;
|
2008-08-13 10:25:34 +00:00
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
client = fd;
|
|
|
|
epollEvent.events = EPOLLHUP;
|
|
|
|
epollEvent.data.fd = client;
|
|
|
|
if (0 > epoll_ctl(epollFd, EPOLL_CTL_ADD, client, &epollEvent)) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("epoll_ctl(client) failed"));
|
2008-08-13 10:52:15 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
} else if (client != -1 && epollEvent.data.fd == client) {
|
|
|
|
if (0 > epoll_ctl(epollFd, EPOLL_CTL_DEL, client, &epollEvent)) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("epoll_ctl(client) failed"));
|
2008-08-13 10:52:15 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
close(client);
|
|
|
|
client = -1;
|
2008-08-13 10:25:34 +00:00
|
|
|
} else {
|
2008-08-13 10:52:15 +00:00
|
|
|
if (epollEvent.events & EPOLLIN) {
|
|
|
|
curFdOff = epollEvent.data.fd == appPty ? 0 : 1;
|
|
|
|
if (!fdArray[curFdOff].active) {
|
|
|
|
fdArray[curFdOff].active = 1;
|
|
|
|
++numActive;
|
|
|
|
}
|
|
|
|
} else if (epollEvent.events & EPOLLHUP) {
|
|
|
|
DEBUG("EPOLLHUP from fd %d", epollEvent.data.fd);
|
|
|
|
continue;
|
|
|
|
} else {
|
2010-02-09 18:22:56 +00:00
|
|
|
lxcError(VIR_ERR_INTERNAL_ERROR,
|
2008-08-13 10:52:15 +00:00
|
|
|
_("error event %d"), epollEvent.events);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-08-13 10:25:34 +00:00
|
|
|
}
|
|
|
|
} else if (0 == numEvents) {
|
|
|
|
if (2 == numActive) {
|
|
|
|
/* both fds active, toggle between the two */
|
|
|
|
curFdOff ^= 1;
|
|
|
|
} else {
|
|
|
|
/* only one active, if current is active, use it, else it */
|
|
|
|
/* must be the other one (ie. curFd just went inactive) */
|
|
|
|
curFdOff = fdArray[curFdOff].active ? curFdOff : curFdOff ^ 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
} else {
|
|
|
|
if (EINTR == errno) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* error */
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("epoll_wait() failed"));
|
2008-08-13 10:25:34 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
if (0 < numActive) {
|
|
|
|
writeFdOff = curFdOff ^ 1;
|
|
|
|
rc = lxcFdForward(fdArray[curFdOff].fd, fdArray[writeFdOff].fd);
|
|
|
|
|
|
|
|
if (EAGAIN == rc) {
|
|
|
|
/* this fd no longer has data, set it as inactive */
|
|
|
|
--numActive;
|
|
|
|
fdArray[curFdOff].active = 0;
|
|
|
|
} else if (-1 == rc) {
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
rc = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
close(appPty);
|
|
|
|
close(contPty);
|
|
|
|
close(epollFd);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2008-08-13 10:52:15 +00:00
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* lxcControllerMoveInterfaces
|
|
|
|
* @nveths: number of interfaces
|
|
|
|
* @veths: interface names
|
|
|
|
* @container: pid of container
|
|
|
|
*
|
|
|
|
* Moves network interfaces into a container's namespace
|
|
|
|
*
|
|
|
|
* Returns 0 on success or -1 in case of error
|
|
|
|
*/
|
|
|
|
static int lxcControllerMoveInterfaces(unsigned int nveths,
|
|
|
|
char **veths,
|
|
|
|
pid_t container)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
for (i = 0 ; i < nveths ; i++)
|
|
|
|
if (moveInterfaceToNetNs(veths[i], container) < 0) {
|
2010-02-09 18:22:56 +00:00
|
|
|
lxcError(VIR_ERR_INTERNAL_ERROR,
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to move interface %s to ns %d"),
|
2008-08-13 10:52:15 +00:00
|
|
|
veths[i], container);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* lxcCleanupInterfaces:
|
2009-11-05 12:35:13 +00:00
|
|
|
* @nveths: number of interfaces
|
|
|
|
* @veths: interface names
|
2008-08-13 10:52:15 +00:00
|
|
|
*
|
|
|
|
* Cleans up the container interfaces by deleting the veth device pairs.
|
|
|
|
*
|
|
|
|
* Returns 0 on success or -1 in case of error
|
|
|
|
*/
|
|
|
|
static int lxcControllerCleanupInterfaces(unsigned int nveths,
|
|
|
|
char **veths)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
for (i = 0 ; i < nveths ; i++)
|
|
|
|
if (vethDelete(veths[i]) < 0)
|
2010-02-09 18:22:56 +00:00
|
|
|
lxcError(VIR_ERR_INTERNAL_ERROR,
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to delete veth: %s"), veths[i]);
|
2008-08-13 10:52:15 +00:00
|
|
|
/* will continue to try to cleanup any other interfaces */
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-04-22 14:26:50 +00:00
|
|
|
#ifndef MS_REC
|
2010-03-09 18:22:22 +00:00
|
|
|
# define MS_REC 16384
|
2009-04-22 14:26:50 +00:00
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef MS_SLAVE
|
2010-03-09 18:22:22 +00:00
|
|
|
# define MS_SLAVE (1<<19)
|
2009-04-22 14:26:50 +00:00
|
|
|
#endif
|
2008-08-13 10:52:15 +00:00
|
|
|
|
|
|
|
static int
|
2008-08-20 20:55:32 +00:00
|
|
|
lxcControllerRun(virDomainDefPtr def,
|
2008-08-13 10:52:15 +00:00
|
|
|
unsigned int nveths,
|
|
|
|
char **veths,
|
|
|
|
int monitor,
|
|
|
|
int client,
|
|
|
|
int appPty)
|
|
|
|
{
|
|
|
|
int rc = -1;
|
|
|
|
int control[2] = { -1, -1};
|
2009-11-10 11:56:11 +00:00
|
|
|
int containerPty = -1;
|
2008-08-13 10:52:15 +00:00
|
|
|
char *containerPtyPath;
|
|
|
|
pid_t container = -1;
|
2009-04-22 14:26:50 +00:00
|
|
|
virDomainFSDefPtr root;
|
|
|
|
char *devpts = NULL;
|
|
|
|
char *devptmx = NULL;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
|
|
|
if (socketpair(PF_UNIX, SOCK_STREAM, 0, control) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("sockpair failed"));
|
2008-08-13 10:52:15 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2009-04-22 14:26:50 +00:00
|
|
|
root = virDomainGetRootFilesystem(def);
|
|
|
|
|
2010-03-04 11:15:42 +00:00
|
|
|
if (lxcSetContainerResources(def) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2009-04-22 14:26:50 +00:00
|
|
|
/*
|
|
|
|
* If doing a chroot style setup, we need to prepare
|
|
|
|
* a private /dev/pts for the child now, which they
|
|
|
|
* will later move into position.
|
|
|
|
*
|
|
|
|
* This is complex because 'virsh console' needs to
|
|
|
|
* use /dev/pts from the host OS, and the guest OS
|
|
|
|
* needs to use /dev/pts from the guest.
|
|
|
|
*
|
|
|
|
* This means that we (libvirt_lxc) need to see and
|
|
|
|
* use both /dev/pts instances. We're running in the
|
|
|
|
* host OS context though and don't want to expose
|
|
|
|
* the guest OS /dev/pts there.
|
|
|
|
*
|
|
|
|
* Thus we call unshare(CLONE_NS) so that we can see
|
|
|
|
* the guest's new /dev/pts, without it becoming
|
|
|
|
* visible to the host OS. We also put the root FS
|
|
|
|
* into slave mode, just in case it was currently
|
|
|
|
* marked as shared
|
|
|
|
*/
|
|
|
|
if (root) {
|
|
|
|
VIR_DEBUG0("Setting up private /dev/pts");
|
|
|
|
if (unshare(CLONE_NEWNS) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Cannot unshare mount namespace"));
|
2009-04-22 14:26:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (mount("", "/", NULL, MS_SLAVE|MS_REC, NULL) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to switch root mount into slave mode"));
|
2009-04-22 14:26:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (virAsprintf(&devpts, "%s/dev/pts", root->src) < 0 ||
|
|
|
|
virAsprintf(&devptmx, "%s/dev/pts/ptmx", root->src) < 0) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2009-04-22 14:26:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2010-01-20 23:52:13 +00:00
|
|
|
if (virFileMakePath(devpts) != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to make path %s"),
|
2009-04-22 14:26:50 +00:00
|
|
|
devpts);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_DEBUG("Mouting 'devpts' on %s", devpts);
|
|
|
|
if (mount("devpts", devpts, "devpts", 0, "newinstance,ptmxmode=0666") < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno,
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to mount devpts on %s"),
|
2009-04-22 14:26:50 +00:00
|
|
|
devpts);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (access(devptmx, R_OK) < 0) {
|
2009-11-05 12:39:09 +00:00
|
|
|
VIR_WARN0("Kernel does not support private devpts, using shared devpts");
|
2009-04-22 14:26:50 +00:00
|
|
|
VIR_FREE(devptmx);
|
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
|
|
|
|
2009-04-22 14:26:50 +00:00
|
|
|
if (devptmx) {
|
|
|
|
VIR_DEBUG("Opening tty on private %s", devptmx);
|
|
|
|
if (virFileOpenTtyAt(devptmx,
|
|
|
|
&containerPty,
|
|
|
|
&containerPtyPath,
|
|
|
|
0) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to allocate tty"));
|
2009-04-22 14:26:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG0("Opening tty on shared /dev/ptmx");
|
|
|
|
if (virFileOpenTty(&containerPty,
|
|
|
|
&containerPtyPath,
|
|
|
|
0) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to allocate tty"));
|
2009-04-22 14:26:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-08-13 10:52:15 +00:00
|
|
|
if ((container = lxcContainerStart(def,
|
|
|
|
nveths,
|
|
|
|
veths,
|
|
|
|
control[1],
|
|
|
|
containerPtyPath)) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
close(control[1]);
|
|
|
|
control[1] = -1;
|
|
|
|
|
|
|
|
if (lxcControllerMoveInterfaces(nveths, veths, container) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (lxcContainerSendContinue(control[0]) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2009-06-29 17:09:42 +00:00
|
|
|
/* Now the container is running, there's no need for us to keep
|
|
|
|
any elevated capabilities */
|
|
|
|
if (lxcControllerClearCapabilities() < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2008-08-13 10:52:15 +00:00
|
|
|
rc = lxcControllerMain(monitor, client, appPty, containerPty);
|
|
|
|
|
|
|
|
cleanup:
|
2009-04-22 14:26:50 +00:00
|
|
|
VIR_FREE(devptmx);
|
|
|
|
VIR_FREE(devpts);
|
2008-08-13 10:52:15 +00:00
|
|
|
if (control[0] != -1)
|
|
|
|
close(control[0]);
|
|
|
|
if (control[1] != -1)
|
|
|
|
close(control[1]);
|
|
|
|
VIR_FREE(containerPtyPath);
|
|
|
|
if (containerPty != -1)
|
|
|
|
close(containerPty);
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if (container > 1) {
|
|
|
|
kill(container, SIGTERM);
|
|
|
|
waitpid(container, NULL, 0);
|
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
int main(int argc, char *argv[])
|
2008-08-13 10:52:15 +00:00
|
|
|
{
|
|
|
|
pid_t pid;
|
2008-08-20 20:55:32 +00:00
|
|
|
int rc = 1;
|
2008-08-13 10:52:15 +00:00
|
|
|
int client;
|
2008-08-20 20:55:32 +00:00
|
|
|
char *name = NULL;
|
|
|
|
int nveths = 0;
|
|
|
|
char **veths = NULL;
|
|
|
|
int monitor = -1;
|
|
|
|
int appPty = -1;
|
|
|
|
int bg = 0;
|
|
|
|
virCapsPtr caps = NULL;
|
|
|
|
virDomainDefPtr def = NULL;
|
|
|
|
char *configFile = NULL;
|
|
|
|
char *sockpath = NULL;
|
2009-02-03 13:08:59 +00:00
|
|
|
const struct option options[] = {
|
2008-08-20 20:55:32 +00:00
|
|
|
{ "background", 0, NULL, 'b' },
|
|
|
|
{ "name", 1, NULL, 'n' },
|
|
|
|
{ "veth", 1, NULL, 'v' },
|
|
|
|
{ "console", 1, NULL, 'c' },
|
|
|
|
{ "help", 0, NULL, 'h' },
|
|
|
|
{ 0, 0, 0, 0 },
|
|
|
|
};
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
while (1) {
|
|
|
|
int c;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
c = getopt_long(argc, argv, "dn:v:m:c:h",
|
|
|
|
options, NULL);
|
|
|
|
|
|
|
|
if (c == -1)
|
|
|
|
break;
|
|
|
|
|
|
|
|
switch (c) {
|
|
|
|
case 'b':
|
|
|
|
bg = 1;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 'n':
|
|
|
|
if ((name = strdup(optarg)) == NULL) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
2008-08-20 20:55:32 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case 'v':
|
|
|
|
if (VIR_REALLOC_N(veths, nveths+1) < 0) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
2008-08-20 20:55:32 +00:00
|
|
|
if ((veths[nveths++] = strdup(optarg)) == NULL) {
|
2010-02-04 18:19:08 +00:00
|
|
|
virReportOOMError();
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
2008-08-20 20:55:32 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case 'c':
|
|
|
|
if (virStrToLong_i(optarg, NULL, 10, &appPty) < 0) {
|
|
|
|
fprintf(stderr, "malformed --console argument '%s'", optarg);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 'h':
|
|
|
|
case '?':
|
|
|
|
fprintf(stderr, "\n");
|
|
|
|
fprintf(stderr, "syntax: %s [OPTIONS]\n", argv[0]);
|
|
|
|
fprintf(stderr, "\n");
|
|
|
|
fprintf(stderr, "Options\n");
|
|
|
|
fprintf(stderr, "\n");
|
|
|
|
fprintf(stderr, " -b, --background\n");
|
|
|
|
fprintf(stderr, " -n NAME, --name NAME\n");
|
|
|
|
fprintf(stderr, " -c FD, --console FD\n");
|
|
|
|
fprintf(stderr, " -v VETH, --veth VETH\n");
|
|
|
|
fprintf(stderr, " -h, --help\n");
|
|
|
|
fprintf(stderr, "\n");
|
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if (name == NULL) {
|
|
|
|
fprintf(stderr, "%s: missing --name argument for configuration\n", argv[0]);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (appPty < 0) {
|
|
|
|
fprintf(stderr, "%s: missing --console argument for container PTY\n", argv[0]);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2009-11-10 11:56:11 +00:00
|
|
|
if (getuid() != 0) {
|
2008-08-20 20:55:32 +00:00
|
|
|
fprintf(stderr, "%s: must be run as the 'root' user\n", argv[0]);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if ((caps = lxcCapsInit()) == NULL)
|
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2010-02-09 18:58:01 +00:00
|
|
|
if ((configFile = virDomainConfigFile(LXC_STATE_DIR,
|
2008-08-20 20:55:32 +00:00
|
|
|
name)) == NULL)
|
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2010-02-09 18:58:01 +00:00
|
|
|
if ((def = virDomainDefParseFile(caps, configFile,
|
2008-12-04 12:02:59 +00:00
|
|
|
VIR_DOMAIN_XML_INACTIVE)) == NULL)
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-10-10 16:08:01 +00:00
|
|
|
if (def->nnets != nveths) {
|
2008-08-20 20:55:32 +00:00
|
|
|
fprintf(stderr, "%s: expecting %d veths, but got %d\n",
|
2008-10-10 16:08:01 +00:00
|
|
|
argv[0], def->nnets, nveths);
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if ((sockpath = lxcMonitorPath(def)) == NULL)
|
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if ((monitor = lxcMonitorServer(sockpath)) < 0)
|
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if (bg) {
|
|
|
|
if ((pid = fork()) < 0)
|
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
if (pid > 0) {
|
|
|
|
if ((rc = virFileWritePid(LXC_STATE_DIR, name, pid)) != 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(rc,
|
2009-01-20 17:13:33 +00:00
|
|
|
_("Unable to write pid file '%s/%s.pid'"),
|
|
|
|
LXC_STATE_DIR, name);
|
2008-08-20 20:55:32 +00:00
|
|
|
_exit(1);
|
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
/* First child now exits, allowing original caller
|
|
|
|
* (ie libvirtd's LXC driver to complete their
|
|
|
|
* waitpid & continue */
|
|
|
|
_exit(0);
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
/* Don't hold onto any cwd we inherit from libvirtd either */
|
|
|
|
if (chdir("/") < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("Unable to change to root dir"));
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (setsid() < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-01-20 17:13:33 +00:00
|
|
|
_("Unable to become session leader"));
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
2008-08-13 10:52:15 +00:00
|
|
|
|
2009-10-08 15:16:08 +00:00
|
|
|
/* Initialize logging */
|
|
|
|
virLogSetFromEnv();
|
|
|
|
|
2008-08-13 10:52:15 +00:00
|
|
|
/* Accept initial client which is the libvirtd daemon */
|
2008-08-20 20:55:32 +00:00
|
|
|
if ((client = accept(monitor, NULL, 0)) < 0) {
|
2010-02-04 20:02:58 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2009-11-05 12:39:09 +00:00
|
|
|
_("Failed to accept a connection from driver"));
|
2008-08-20 20:55:32 +00:00
|
|
|
goto cleanup;
|
2008-08-13 10:52:15 +00:00
|
|
|
}
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
rc = lxcControllerRun(def, nveths, veths, monitor, client, appPty);
|
2008-08-13 10:52:15 +00:00
|
|
|
|
|
|
|
|
2008-08-20 20:55:32 +00:00
|
|
|
cleanup:
|
2009-05-07 07:17:25 +00:00
|
|
|
if (def)
|
|
|
|
virFileDeletePid(LXC_STATE_DIR, def->name);
|
2008-08-20 20:55:32 +00:00
|
|
|
lxcControllerCleanupInterfaces(nveths, veths);
|
2009-09-02 08:02:49 +00:00
|
|
|
if (sockpath)
|
|
|
|
unlink(sockpath);
|
2008-08-20 20:55:32 +00:00
|
|
|
VIR_FREE(sockpath);
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|