backup: Parse and output checkpoint XML
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in time. Add some basic testing of round trip
XML handling through the new code.
Of note - this code intentionally differs from snapshots in that XML
schema validation is unconditional, rather than based on a public API
flag. We have many existing interfaces that still need to add a flag
for opt-in schema validation, but those interfaces have existing
clients that may not have been producing strictly-compliant XML, or we
may still uncover bugs where our RNG grammar is inconsistent with our
code (where omitting the opt-in flag allows existing apps to keep
working while waiting for an RNG patch). But since checkpoints are
brand-new, it's easier to ensure the code matches the schema by always
using the schema. If needed, a later patch could extend the API and
add a flag to turn on to request schema validation, rather than having
it forced (possibly just the validation of the <domain> sub-element
during REDEFINE) - but if a user encounters XML that looks like it
should be good but fails to validate with our RNG schema, they would
either have to upgrade to a new libvirt that adds the new flag, or
upgrade to a new libvirt that fixes the RNG schema, which implies
adding such a flag won't help much.
Also, the redefine flag requires the <domain> sub-element to be
present, rather than catering to historical back-compat to older
versions.
Signed-off-by: Eric Blake <eblake@redhat.com>
2018-07-08 02:01:14 +00:00
|
|
|
/*
|
|
|
|
* checkpoint_conf.h: domain checkpoint XML processing
|
|
|
|
* (based on snapshot_conf.h)
|
|
|
|
*
|
|
|
|
* Copyright (C) 2006-2019 Red Hat, Inc.
|
|
|
|
* Copyright (C) 2006-2008 Daniel P. Berrange
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library. If not, see
|
|
|
|
* <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
#include "internal.h"
|
|
|
|
#include "domain_conf.h"
|
|
|
|
#include "moment_conf.h"
|
|
|
|
#include "virobject.h"
|
|
|
|
|
|
|
|
/* Items related to checkpoint state */
|
|
|
|
|
|
|
|
typedef enum {
|
|
|
|
VIR_DOMAIN_CHECKPOINT_TYPE_DEFAULT = 0,
|
|
|
|
VIR_DOMAIN_CHECKPOINT_TYPE_NONE,
|
|
|
|
VIR_DOMAIN_CHECKPOINT_TYPE_BITMAP,
|
|
|
|
|
|
|
|
VIR_DOMAIN_CHECKPOINT_TYPE_LAST
|
|
|
|
} virDomainCheckpointType;
|
|
|
|
|
|
|
|
/* Stores disk-checkpoint information */
|
|
|
|
typedef struct _virDomainCheckpointDiskDef virDomainCheckpointDiskDef;
|
|
|
|
typedef virDomainCheckpointDiskDef *virDomainCheckpointDiskDefPtr;
|
|
|
|
struct _virDomainCheckpointDiskDef {
|
|
|
|
char *name; /* name matching the <target dev='...' of the domain */
|
|
|
|
int type; /* virDomainCheckpointType */
|
|
|
|
char *bitmap; /* bitmap name, if type is bitmap */
|
|
|
|
unsigned long long size; /* current checkpoint size in bytes */
|
2020-07-01 14:58:29 +00:00
|
|
|
bool sizeValid;
|
backup: Parse and output checkpoint XML
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in time. Add some basic testing of round trip
XML handling through the new code.
Of note - this code intentionally differs from snapshots in that XML
schema validation is unconditional, rather than based on a public API
flag. We have many existing interfaces that still need to add a flag
for opt-in schema validation, but those interfaces have existing
clients that may not have been producing strictly-compliant XML, or we
may still uncover bugs where our RNG grammar is inconsistent with our
code (where omitting the opt-in flag allows existing apps to keep
working while waiting for an RNG patch). But since checkpoints are
brand-new, it's easier to ensure the code matches the schema by always
using the schema. If needed, a later patch could extend the API and
add a flag to turn on to request schema validation, rather than having
it forced (possibly just the validation of the <domain> sub-element
during REDEFINE) - but if a user encounters XML that looks like it
should be good but fails to validate with our RNG schema, they would
either have to upgrade to a new libvirt that adds the new flag, or
upgrade to a new libvirt that fixes the RNG schema, which implies
adding such a flag won't help much.
Also, the redefine flag requires the <domain> sub-element to be
present, rather than catering to historical back-compat to older
versions.
Signed-off-by: Eric Blake <eblake@redhat.com>
2018-07-08 02:01:14 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
/* Stores the complete checkpoint metadata */
|
|
|
|
struct _virDomainCheckpointDef {
|
|
|
|
virDomainMomentDef parent;
|
|
|
|
|
|
|
|
/* Additional Public XML. */
|
|
|
|
size_t ndisks; /* should not exceed dom->ndisks */
|
|
|
|
virDomainCheckpointDiskDef *disks;
|
|
|
|
};
|
|
|
|
|
2019-10-15 12:47:50 +00:00
|
|
|
G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainCheckpointDef, virObjectUnref);
|
backup: Parse and output checkpoint XML
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in time. Add some basic testing of round trip
XML handling through the new code.
Of note - this code intentionally differs from snapshots in that XML
schema validation is unconditional, rather than based on a public API
flag. We have many existing interfaces that still need to add a flag
for opt-in schema validation, but those interfaces have existing
clients that may not have been producing strictly-compliant XML, or we
may still uncover bugs where our RNG grammar is inconsistent with our
code (where omitting the opt-in flag allows existing apps to keep
working while waiting for an RNG patch). But since checkpoints are
brand-new, it's easier to ensure the code matches the schema by always
using the schema. If needed, a later patch could extend the API and
add a flag to turn on to request schema validation, rather than having
it forced (possibly just the validation of the <domain> sub-element
during REDEFINE) - but if a user encounters XML that looks like it
should be good but fails to validate with our RNG schema, they would
either have to upgrade to a new libvirt that adds the new flag, or
upgrade to a new libvirt that fixes the RNG schema, which implies
adding such a flag won't help much.
Also, the redefine flag requires the <domain> sub-element to be
present, rather than catering to historical back-compat to older
versions.
Signed-off-by: Eric Blake <eblake@redhat.com>
2018-07-08 02:01:14 +00:00
|
|
|
|
|
|
|
typedef enum {
|
|
|
|
VIR_DOMAIN_CHECKPOINT_PARSE_REDEFINE = 1 << 0,
|
|
|
|
} virDomainCheckpointParseFlags;
|
|
|
|
|
|
|
|
typedef enum {
|
|
|
|
VIR_DOMAIN_CHECKPOINT_FORMAT_SECURE = 1 << 0,
|
|
|
|
VIR_DOMAIN_CHECKPOINT_FORMAT_NO_DOMAIN = 1 << 1,
|
|
|
|
VIR_DOMAIN_CHECKPOINT_FORMAT_SIZE = 1 << 2,
|
|
|
|
} virDomainCheckpointFormatFlags;
|
|
|
|
|
|
|
|
unsigned int
|
|
|
|
virDomainCheckpointFormatConvertXMLFlags(unsigned int flags);
|
|
|
|
|
|
|
|
virDomainCheckpointDefPtr
|
|
|
|
virDomainCheckpointDefParseString(const char *xmlStr,
|
|
|
|
virDomainXMLOptionPtr xmlopt,
|
2019-08-06 12:19:35 +00:00
|
|
|
void *parseOpaque,
|
backup: Parse and output checkpoint XML
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in time. Add some basic testing of round trip
XML handling through the new code.
Of note - this code intentionally differs from snapshots in that XML
schema validation is unconditional, rather than based on a public API
flag. We have many existing interfaces that still need to add a flag
for opt-in schema validation, but those interfaces have existing
clients that may not have been producing strictly-compliant XML, or we
may still uncover bugs where our RNG grammar is inconsistent with our
code (where omitting the opt-in flag allows existing apps to keep
working while waiting for an RNG patch). But since checkpoints are
brand-new, it's easier to ensure the code matches the schema by always
using the schema. If needed, a later patch could extend the API and
add a flag to turn on to request schema validation, rather than having
it forced (possibly just the validation of the <domain> sub-element
during REDEFINE) - but if a user encounters XML that looks like it
should be good but fails to validate with our RNG schema, they would
either have to upgrade to a new libvirt that adds the new flag, or
upgrade to a new libvirt that fixes the RNG schema, which implies
adding such a flag won't help much.
Also, the redefine flag requires the <domain> sub-element to be
present, rather than catering to historical back-compat to older
versions.
Signed-off-by: Eric Blake <eblake@redhat.com>
2018-07-08 02:01:14 +00:00
|
|
|
unsigned int flags);
|
|
|
|
|
|
|
|
virDomainCheckpointDefPtr
|
|
|
|
virDomainCheckpointDefNew(void);
|
|
|
|
|
|
|
|
char *
|
|
|
|
virDomainCheckpointDefFormat(virDomainCheckpointDefPtr def,
|
|
|
|
virDomainXMLOptionPtr xmlopt,
|
|
|
|
unsigned int flags);
|
|
|
|
|
|
|
|
int
|
|
|
|
virDomainCheckpointAlignDisks(virDomainCheckpointDefPtr checkpoint);
|
|
|
|
|
2020-11-04 09:10:56 +00:00
|
|
|
int
|
|
|
|
virDomainCheckpointRedefinePrep(virDomainObjPtr vm,
|
|
|
|
virDomainCheckpointDefPtr def,
|
|
|
|
bool *update_current);
|
|
|
|
|
|
|
|
virDomainMomentObjPtr
|
|
|
|
virDomainCheckpointRedefineCommit(virDomainObjPtr vm,
|
|
|
|
virDomainCheckpointDefPtr *defptr,
|
|
|
|
virDomainXMLOptionPtr xmlopt);
|
2019-07-26 19:28:44 +00:00
|
|
|
|
backup: Parse and output checkpoint XML
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in time. Add some basic testing of round trip
XML handling through the new code.
Of note - this code intentionally differs from snapshots in that XML
schema validation is unconditional, rather than based on a public API
flag. We have many existing interfaces that still need to add a flag
for opt-in schema validation, but those interfaces have existing
clients that may not have been producing strictly-compliant XML, or we
may still uncover bugs where our RNG grammar is inconsistent with our
code (where omitting the opt-in flag allows existing apps to keep
working while waiting for an RNG patch). But since checkpoints are
brand-new, it's easier to ensure the code matches the schema by always
using the schema. If needed, a later patch could extend the API and
add a flag to turn on to request schema validation, rather than having
it forced (possibly just the validation of the <domain> sub-element
during REDEFINE) - but if a user encounters XML that looks like it
should be good but fails to validate with our RNG schema, they would
either have to upgrade to a new libvirt that adds the new flag, or
upgrade to a new libvirt that fixes the RNG schema, which implies
adding such a flag won't help much.
Also, the redefine flag requires the <domain> sub-element to be
present, rather than catering to historical back-compat to older
versions.
Signed-off-by: Eric Blake <eblake@redhat.com>
2018-07-08 02:01:14 +00:00
|
|
|
VIR_ENUM_DECL(virDomainCheckpoint);
|