2009-03-02 16:18:11 +00:00
|
|
|
/*
|
2012-12-13 14:52:25 +00:00
|
|
|
* virpci.h: helper APIs for managing host PCI devices
|
|
|
|
|
*
|
2011-12-14 10:50:01 +00:00
|
|
|
* Copyright (C) 2009, 2011-2012 Red Hat, Inc.
|
2009-03-02 16:18:11 +00:00
|
|
|
*
|
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
2012-09-20 22:30:55 +00:00
|
|
|
* License along with this library. If not, see
|
2012-07-21 10:06:23 +00:00
|
|
|
* <http://www.gnu.org/licenses/>.
|
2009-03-02 16:18:11 +00:00
|
|
|
*
|
|
|
|
|
* Authors:
|
|
|
|
|
* Mark McLoughlin <markmc@redhat.com>
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifndef __VIR_PCI_H__
|
2010-03-09 18:22:22 +00:00
|
|
|
# define __VIR_PCI_H__
|
2009-03-02 16:18:11 +00:00
|
|
|
|
2010-03-09 18:22:22 +00:00
|
|
|
# include "internal.h"
|
2009-03-02 16:18:11 +00:00
|
|
|
|
|
|
|
|
typedef struct _pciDevice pciDevice;
|
2009-10-27 17:30:16 +00:00
|
|
|
typedef struct _pciDeviceList pciDeviceList;
|
2009-08-17 14:05:23 +00:00
|
|
|
|
2011-08-16 04:28:43 +00:00
|
|
|
struct pci_config_address {
|
|
|
|
|
unsigned int domain;
|
|
|
|
|
unsigned int bus;
|
|
|
|
|
unsigned int slot;
|
|
|
|
|
unsigned int function;
|
|
|
|
|
};
|
|
|
|
|
|
2010-02-04 23:16:34 +00:00
|
|
|
pciDevice *pciGetDevice (unsigned domain,
|
2009-03-02 16:18:11 +00:00
|
|
|
unsigned bus,
|
|
|
|
|
unsigned slot,
|
|
|
|
|
unsigned function);
|
2010-02-04 23:16:34 +00:00
|
|
|
void pciFreeDevice (pciDevice *dev);
|
qemu: Do not reattach PCI device used by other domain when shutdown
When failing on starting a domain, it tries to reattach all the PCI
devices defined in the domain conf, regardless of whether the devices
are still used by other domain. This will cause the devices to be deleted
from the list qemu_driver->activePciHostdevs, thus the devices will be
thought as usable even if it's not true. And following commands
nodedev-{reattach,reset} will be successful.
How to reproduce:
1) Define two domains with same PCI device defined in the confs.
2) # virsh start domain1
3) # virsh start domain2
4) # virsh nodedev-reattach $pci_device
You will see the device will be reattached to host successfully.
As pciDeviceReattach just check if the device is still used by
other domain via checking if the device is in list driver->activePciHostdevs,
however, the device is deleted from the list by step 2).
This patch is to prohibit the bug by:
1) Prohibit a domain starting or device attachment right at
preparation period (qemuPrepareHostdevPCIDevices) if the
device is in list driver->activePciHostdevs, which means
it's used by other domain.
2) Introduces a new field for struct _pciDevice, (const char *used_by),
it will be set as the domain name at preparation period,
(qemuPrepareHostdevPCIDevices). Thus we can prohibit deleting
the device from driver->activePciHostdevs if it's still used by
other domain when stopping the domain process.
* src/pci.h (define two internal functions, pciDeviceSetUsedBy and
pciDevceGetUsedBy)
* src/pci.c (new field "const char *used_by" for struct _pciDevice,
implementations for the two new functions)
* src/libvirt_private.syms (Add the two new internal functions)
* src/qemu_hostdev.h (Modify the definition of functions
qemuPrepareHostdevPCIDevices, and qemuDomainReAttachHostdevDevices)
* src/qemu_hostdev.c (Prohibit preparation and don't delete the
device from activePciHostdevs list if it's still used by other domain)
* src/qemu_hotplug.c (Update function usage, as the definitions are
changed)
Signed-off-by: Eric Blake <eblake@redhat.com>
2011-10-13 04:05:04 +00:00
|
|
|
const char *pciDeviceGetName (pciDevice *dev);
|
qemu: Introduce inactive PCI device list
pciTrySecondaryBusReset checks if there is active device on the
same bus, however, qemu driver doesn't maintain an effective
list for the inactive devices, and it passes meaningless argument
for parameter "inactiveDevs". e.g. (qemuPrepareHostdevPCIDevices)
if (!(pcidevs = qemuGetPciHostDeviceList(hostdevs, nhostdevs)))
return -1;
..skipped...
if (pciResetDevice(dev, driver->activePciHostdevs, pcidevs) < 0)
goto reattachdevs;
NB, the "pcidevs" used above are extracted from domain def, and
thus one won't be able to attach a device of which bus has other
device even detached from host (nodedev-detach). To see more
details of the problem:
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=773667
This patch is to resolve the problem by introducing an inactive
PCI device list (just like qemu_driver->activePciHostdevs), and
the whole logic is:
* Add the device to inactive list during nodedev-dettach
* Remove the device from inactive list during nodedev-reattach
* Remove the device from inactive list during attach-device
(for non-managed device)
* Add the device to inactive list after detach-device, only
if the device is not managed
With the above, we have a sufficient inactive PCI device list, and thus
we can use it for pciResetDevice. e.g.(qemuPrepareHostdevPCIDevices)
if (pciResetDevice(dev, driver->activePciHostdevs,
driver->inactivePciHostdevs) < 0)
goto reattachdevs;
2012-01-17 20:02:05 +00:00
|
|
|
int pciDettachDevice (pciDevice *dev,
|
|
|
|
|
pciDeviceList *activeDevs,
|
2013-01-10 07:51:43 +00:00
|
|
|
pciDeviceList *inactiveDevs,
|
|
|
|
|
const char *driver);
|
qemu: Introduce inactive PCI device list
pciTrySecondaryBusReset checks if there is active device on the
same bus, however, qemu driver doesn't maintain an effective
list for the inactive devices, and it passes meaningless argument
for parameter "inactiveDevs". e.g. (qemuPrepareHostdevPCIDevices)
if (!(pcidevs = qemuGetPciHostDeviceList(hostdevs, nhostdevs)))
return -1;
..skipped...
if (pciResetDevice(dev, driver->activePciHostdevs, pcidevs) < 0)
goto reattachdevs;
NB, the "pcidevs" used above are extracted from domain def, and
thus one won't be able to attach a device of which bus has other
device even detached from host (nodedev-detach). To see more
details of the problem:
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=773667
This patch is to resolve the problem by introducing an inactive
PCI device list (just like qemu_driver->activePciHostdevs), and
the whole logic is:
* Add the device to inactive list during nodedev-dettach
* Remove the device from inactive list during nodedev-reattach
* Remove the device from inactive list during attach-device
(for non-managed device)
* Add the device to inactive list after detach-device, only
if the device is not managed
With the above, we have a sufficient inactive PCI device list, and thus
we can use it for pciResetDevice. e.g.(qemuPrepareHostdevPCIDevices)
if (pciResetDevice(dev, driver->activePciHostdevs,
driver->inactivePciHostdevs) < 0)
goto reattachdevs;
2012-01-17 20:02:05 +00:00
|
|
|
int pciReAttachDevice (pciDevice *dev,
|
|
|
|
|
pciDeviceList *activeDevs,
|
2013-01-10 07:51:43 +00:00
|
|
|
pciDeviceList *inactiveDevs,
|
|
|
|
|
const char *driver);
|
2010-02-04 23:16:34 +00:00
|
|
|
int pciResetDevice (pciDevice *dev,
|
2010-07-26 16:43:04 +00:00
|
|
|
pciDeviceList *activeDevs,
|
|
|
|
|
pciDeviceList *inactiveDevs);
|
2009-08-17 14:05:23 +00:00
|
|
|
void pciDeviceSetManaged(pciDevice *dev,
|
|
|
|
|
unsigned managed);
|
|
|
|
|
unsigned pciDeviceGetManaged(pciDevice *dev);
|
qemu: Do not reattach PCI device used by other domain when shutdown
When failing on starting a domain, it tries to reattach all the PCI
devices defined in the domain conf, regardless of whether the devices
are still used by other domain. This will cause the devices to be deleted
from the list qemu_driver->activePciHostdevs, thus the devices will be
thought as usable even if it's not true. And following commands
nodedev-{reattach,reset} will be successful.
How to reproduce:
1) Define two domains with same PCI device defined in the confs.
2) # virsh start domain1
3) # virsh start domain2
4) # virsh nodedev-reattach $pci_device
You will see the device will be reattached to host successfully.
As pciDeviceReattach just check if the device is still used by
other domain via checking if the device is in list driver->activePciHostdevs,
however, the device is deleted from the list by step 2).
This patch is to prohibit the bug by:
1) Prohibit a domain starting or device attachment right at
preparation period (qemuPrepareHostdevPCIDevices) if the
device is in list driver->activePciHostdevs, which means
it's used by other domain.
2) Introduces a new field for struct _pciDevice, (const char *used_by),
it will be set as the domain name at preparation period,
(qemuPrepareHostdevPCIDevices). Thus we can prohibit deleting
the device from driver->activePciHostdevs if it's still used by
other domain when stopping the domain process.
* src/pci.h (define two internal functions, pciDeviceSetUsedBy and
pciDevceGetUsedBy)
* src/pci.c (new field "const char *used_by" for struct _pciDevice,
implementations for the two new functions)
* src/libvirt_private.syms (Add the two new internal functions)
* src/qemu_hostdev.h (Modify the definition of functions
qemuPrepareHostdevPCIDevices, and qemuDomainReAttachHostdevDevices)
* src/qemu_hostdev.c (Prohibit preparation and don't delete the
device from activePciHostdevs list if it's still used by other domain)
* src/qemu_hotplug.c (Update function usage, as the definitions are
changed)
Signed-off-by: Eric Blake <eblake@redhat.com>
2011-10-13 04:05:04 +00:00
|
|
|
void pciDeviceSetUsedBy(pciDevice *dev,
|
|
|
|
|
const char *used_by);
|
|
|
|
|
const char *pciDeviceGetUsedBy(pciDevice *dev);
|
2011-10-20 09:50:10 +00:00
|
|
|
unsigned pciDeviceGetUnbindFromStub(pciDevice *dev);
|
|
|
|
|
void pciDeviceSetUnbindFromStub(pciDevice *dev,
|
|
|
|
|
unsigned unbind);
|
|
|
|
|
unsigned pciDeviceGetRemoveSlot(pciDevice *dev);
|
|
|
|
|
void pciDeviceSetRemoveSlot(pciDevice *dev,
|
|
|
|
|
unsigned remove_slot);
|
|
|
|
|
unsigned pciDeviceGetReprobe(pciDevice *dev);
|
|
|
|
|
void pciDeviceSetReprobe(pciDevice *dev,
|
|
|
|
|
unsigned reprobe);
|
2011-07-03 12:09:44 +00:00
|
|
|
void pciDeviceReAttachInit(pciDevice *dev);
|
2009-08-17 14:05:23 +00:00
|
|
|
|
2010-02-04 23:16:34 +00:00
|
|
|
pciDeviceList *pciDeviceListNew (void);
|
|
|
|
|
void pciDeviceListFree (pciDeviceList *list);
|
|
|
|
|
int pciDeviceListAdd (pciDeviceList *list,
|
2009-08-17 14:05:23 +00:00
|
|
|
pciDevice *dev);
|
2009-10-27 17:30:16 +00:00
|
|
|
pciDevice * pciDeviceListGet (pciDeviceList *list,
|
|
|
|
|
int idx);
|
|
|
|
|
int pciDeviceListCount (pciDeviceList *list);
|
2010-02-04 23:16:34 +00:00
|
|
|
pciDevice * pciDeviceListSteal (pciDeviceList *list,
|
2009-10-27 17:30:16 +00:00
|
|
|
pciDevice *dev);
|
2012-12-04 07:30:46 +00:00
|
|
|
pciDevice * pciDeviceListStealIndex(pciDeviceList *list,
|
|
|
|
|
int idx);
|
2010-02-04 23:16:34 +00:00
|
|
|
void pciDeviceListDel (pciDeviceList *list,
|
2009-08-17 14:05:23 +00:00
|
|
|
pciDevice *dev);
|
|
|
|
|
pciDevice * pciDeviceListFind (pciDeviceList *list,
|
|
|
|
|
pciDevice *dev);
|
2012-12-04 07:30:46 +00:00
|
|
|
int pciDeviceListFindIndex(pciDeviceList *list,
|
|
|
|
|
pciDevice *dev);
|
2009-08-14 07:31:11 +00:00
|
|
|
|
2009-08-14 13:20:40 +00:00
|
|
|
/*
|
|
|
|
|
* Callback that will be invoked once for each file
|
|
|
|
|
* associated with / used for PCI host device access.
|
|
|
|
|
*
|
|
|
|
|
* Should return 0 if successfully processed, or
|
|
|
|
|
* -1 to indicate error and abort iteration
|
|
|
|
|
*/
|
2010-02-10 09:55:39 +00:00
|
|
|
typedef int (*pciDeviceFileActor)(pciDevice *dev,
|
2009-08-14 13:20:40 +00:00
|
|
|
const char *path, void *opaque);
|
|
|
|
|
|
2010-02-10 09:55:39 +00:00
|
|
|
int pciDeviceFileIterate(pciDevice *dev,
|
2009-08-14 13:20:40 +00:00
|
|
|
pciDeviceFileActor actor,
|
|
|
|
|
void *opaque);
|
|
|
|
|
|
2010-02-04 23:16:34 +00:00
|
|
|
int pciDeviceIsAssignable(pciDevice *dev,
|
2009-12-22 17:21:15 +00:00
|
|
|
int strict_acs_check);
|
2010-01-20 20:53:59 +00:00
|
|
|
int pciWaitForDeviceCleanup(pciDevice *dev, const char *matcher);
|
2009-12-22 17:21:15 +00:00
|
|
|
|
2011-08-16 04:28:43 +00:00
|
|
|
int pciGetPhysicalFunction(const char *sysfs_path,
|
|
|
|
|
struct pci_config_address **phys_fn);
|
|
|
|
|
|
|
|
|
|
int pciGetVirtualFunctions(const char *sysfs_path,
|
|
|
|
|
struct pci_config_address ***virtual_functions,
|
|
|
|
|
unsigned int *num_virtual_functions);
|
|
|
|
|
|
2011-08-16 04:28:48 +00:00
|
|
|
int pciDeviceIsVirtualFunction(const char *vf_sysfs_device_link);
|
|
|
|
|
|
|
|
|
|
int pciGetVirtualFunctionIndex(const char *pf_sysfs_device_link,
|
|
|
|
|
const char *vf_sysfs_device_link,
|
|
|
|
|
int *vf_index);
|
|
|
|
|
|
2012-03-06 01:12:23 +00:00
|
|
|
int pciConfigAddressToSysfsFile(struct pci_config_address *dev,
|
|
|
|
|
char **pci_sysfs_device_link);
|
|
|
|
|
|
2011-08-16 04:28:48 +00:00
|
|
|
int pciDeviceNetName(char *device_link_sysfs_path, char **netname);
|
|
|
|
|
|
2011-12-14 10:50:01 +00:00
|
|
|
int pciSysfsFile(char *pciDeviceName, char **pci_sysfs_device_link)
|
|
|
|
|
ATTRIBUTE_RETURN_CHECK;
|
|
|
|
|
|
2011-12-14 10:50:14 +00:00
|
|
|
int pciGetDeviceAddrString(unsigned domain,
|
|
|
|
|
unsigned bus,
|
|
|
|
|
unsigned slot,
|
|
|
|
|
unsigned function,
|
|
|
|
|
char **pciConfigAddr)
|
|
|
|
|
ATTRIBUTE_NONNULL(5) ATTRIBUTE_RETURN_CHECK;
|
2012-03-06 01:12:23 +00:00
|
|
|
|
|
|
|
|
int pciDeviceGetVirtualFunctionInfo(const char *vf_sysfs_device_path,
|
|
|
|
|
char **pfname, int *vf_index);
|
|
|
|
|
|
2009-03-02 16:18:11 +00:00
|
|
|
#endif /* __VIR_PCI_H__ */
|
