2015-08-14 07:17:01 +00:00
|
|
|
/*
|
|
|
|
* admin_server.c: admin methods to manage daemons and clients
|
|
|
|
*
|
|
|
|
* Copyright (C) 2016 Red Hat, Inc.
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library. If not, see
|
|
|
|
* <http://www.gnu.org/licenses/>.
|
|
|
|
*
|
|
|
|
* Authors: Erik Skultety <eskultet@redhat.com>
|
|
|
|
* Martin Kletzander <mkletzan@redhat.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
|
|
#include "admin_server.h"
|
|
|
|
#include "datatypes.h"
|
|
|
|
#include "viralloc.h"
|
|
|
|
#include "virerror.h"
|
|
|
|
#include "virlog.h"
|
|
|
|
#include "virnetdaemon.h"
|
|
|
|
#include "virnetserver.h"
|
|
|
|
#include "virstring.h"
|
2015-11-23 11:41:32 +00:00
|
|
|
#include "virthreadpool.h"
|
admin: Introduce virAdmServerSetThreadPoolParameters
Since threadpool increments the current number of threads according to current
load, i.e. how many jobs are waiting in the queue. The count however, is
constrained by max and min limits of workers. The logic of this new API works
like this:
1) setting the minimum
a) When the limit is increased, depending on the current number of
threads, new threads are possibly spawned if the current number of
threads is less than the new minimum limit
b) Decreasing the minimum limit has no possible effect on the current
number of threads
2) setting the maximum
a) Icreasing the maximum limit has no immediate effect on the current
number of threads, it only allows the threadpool to spawn more
threads when new jobs, that would otherwise end up queued, arrive.
b) Decreasing the maximum limit may affect the current number of
threads, if the current number of threads is less than the new
maximum limit. Since there may be some ongoing time-consuming jobs
that would effectively block this API from killing any threads.
Therefore, this API is asynchronous with best-effort execution,
i.e. the necessary number of workers will be terminated once they
finish their previous job, unless other workers had already
terminated, decreasing the limit to the requested value.
3) setting priority workers
- both increase and decrease in count of these workers have an
immediate impact on the current number of workers, new ones will be
spawned or some of them get terminated respectively.
Signed-off-by: Erik Skultety <eskultet@redhat.com>
2016-02-22 13:24:04 +00:00
|
|
|
#include "virtypedparam.h"
|
2015-08-14 07:17:01 +00:00
|
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_ADMIN
|
|
|
|
|
|
|
|
VIR_LOG_INIT("daemon.admin_server");
|
|
|
|
|
|
|
|
int
|
2016-03-02 14:32:55 +00:00
|
|
|
adminConnectListServers(virNetDaemonPtr dmn,
|
|
|
|
virNetServerPtr **servers,
|
|
|
|
unsigned int flags)
|
2015-08-14 07:17:01 +00:00
|
|
|
{
|
|
|
|
int ret = -1;
|
2016-03-01 14:31:18 +00:00
|
|
|
virNetServerPtr *srvs = NULL;
|
2015-08-14 07:17:01 +00:00
|
|
|
|
|
|
|
virCheckFlags(0, -1);
|
|
|
|
|
2016-03-01 15:28:58 +00:00
|
|
|
if ((ret = virNetDaemonGetServers(dmn, &srvs)) < 0)
|
2015-08-14 07:17:01 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (servers) {
|
|
|
|
*servers = srvs;
|
|
|
|
srvs = NULL;
|
|
|
|
}
|
|
|
|
cleanup:
|
2016-03-25 09:18:00 +00:00
|
|
|
if (ret > 0)
|
|
|
|
virObjectListFreeCount(srvs, ret);
|
2015-08-14 07:17:01 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2016-03-01 16:33:37 +00:00
|
|
|
|
|
|
|
virNetServerPtr
|
|
|
|
adminConnectLookupServer(virNetDaemonPtr dmn,
|
|
|
|
const char *name,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
virCheckFlags(flags, NULL);
|
|
|
|
|
|
|
|
return virNetDaemonGetServer(dmn, name);
|
|
|
|
}
|
2015-11-23 11:41:32 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
adminServerGetThreadPoolParameters(virNetServerPtr srv,
|
|
|
|
virTypedParameterPtr *params,
|
|
|
|
int *nparams,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
int maxparams = 0;
|
|
|
|
size_t minWorkers;
|
|
|
|
size_t maxWorkers;
|
|
|
|
size_t nWorkers;
|
|
|
|
size_t freeWorkers;
|
|
|
|
size_t nPrioWorkers;
|
|
|
|
size_t jobQueueDepth;
|
|
|
|
virTypedParameterPtr tmpparams = NULL;
|
|
|
|
|
|
|
|
virCheckFlags(0, -1);
|
|
|
|
|
|
|
|
if (virNetServerGetThreadPoolParameters(srv, &minWorkers, &maxWorkers,
|
|
|
|
&nWorkers, &freeWorkers,
|
|
|
|
&nPrioWorkers,
|
|
|
|
&jobQueueDepth) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Unable to retrieve threadpool parameters"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (virTypedParamsAddUInt(&tmpparams, nparams,
|
|
|
|
&maxparams, VIR_THREADPOOL_WORKERS_MIN,
|
|
|
|
minWorkers) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virTypedParamsAddUInt(&tmpparams, nparams,
|
|
|
|
&maxparams, VIR_THREADPOOL_WORKERS_MAX,
|
|
|
|
maxWorkers) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virTypedParamsAddUInt(&tmpparams, nparams,
|
|
|
|
&maxparams, VIR_THREADPOOL_WORKERS_CURRENT,
|
|
|
|
nWorkers) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virTypedParamsAddUInt(&tmpparams, nparams,
|
|
|
|
&maxparams, VIR_THREADPOOL_WORKERS_FREE,
|
|
|
|
freeWorkers) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virTypedParamsAddUInt(&tmpparams, nparams,
|
|
|
|
&maxparams, VIR_THREADPOOL_WORKERS_PRIORITY,
|
|
|
|
nPrioWorkers) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (virTypedParamsAddUInt(&tmpparams, nparams,
|
|
|
|
&maxparams, VIR_THREADPOOL_JOB_QUEUE_DEPTH,
|
|
|
|
jobQueueDepth) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
*params = tmpparams;
|
|
|
|
tmpparams = NULL;
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
virTypedParamsFree(tmpparams, *nparams);
|
|
|
|
return ret;
|
|
|
|
}
|
admin: Introduce virAdmServerSetThreadPoolParameters
Since threadpool increments the current number of threads according to current
load, i.e. how many jobs are waiting in the queue. The count however, is
constrained by max and min limits of workers. The logic of this new API works
like this:
1) setting the minimum
a) When the limit is increased, depending on the current number of
threads, new threads are possibly spawned if the current number of
threads is less than the new minimum limit
b) Decreasing the minimum limit has no possible effect on the current
number of threads
2) setting the maximum
a) Icreasing the maximum limit has no immediate effect on the current
number of threads, it only allows the threadpool to spawn more
threads when new jobs, that would otherwise end up queued, arrive.
b) Decreasing the maximum limit may affect the current number of
threads, if the current number of threads is less than the new
maximum limit. Since there may be some ongoing time-consuming jobs
that would effectively block this API from killing any threads.
Therefore, this API is asynchronous with best-effort execution,
i.e. the necessary number of workers will be terminated once they
finish their previous job, unless other workers had already
terminated, decreasing the limit to the requested value.
3) setting priority workers
- both increase and decrease in count of these workers have an
immediate impact on the current number of workers, new ones will be
spawned or some of them get terminated respectively.
Signed-off-by: Erik Skultety <eskultet@redhat.com>
2016-02-22 13:24:04 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
adminServerSetThreadPoolParameters(virNetServerPtr srv,
|
|
|
|
virTypedParameterPtr params,
|
|
|
|
int nparams,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
long long int minWorkers = -1;
|
|
|
|
long long int maxWorkers = -1;
|
|
|
|
long long int prioWorkers = -1;
|
|
|
|
virTypedParameterPtr param = NULL;
|
|
|
|
|
|
|
|
virCheckFlags(0, -1);
|
|
|
|
|
|
|
|
if (virTypedParamsValidate(params, nparams,
|
|
|
|
VIR_THREADPOOL_WORKERS_MIN,
|
|
|
|
VIR_TYPED_PARAM_UINT,
|
|
|
|
VIR_THREADPOOL_WORKERS_MAX,
|
|
|
|
VIR_TYPED_PARAM_UINT,
|
|
|
|
VIR_THREADPOOL_WORKERS_PRIORITY,
|
|
|
|
VIR_TYPED_PARAM_UINT,
|
|
|
|
NULL) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if ((param = virTypedParamsGet(params, nparams,
|
|
|
|
VIR_THREADPOOL_WORKERS_MIN)))
|
|
|
|
minWorkers = param->value.ui;
|
|
|
|
|
|
|
|
if ((param = virTypedParamsGet(params, nparams,
|
|
|
|
VIR_THREADPOOL_WORKERS_MAX)))
|
|
|
|
maxWorkers = param->value.ui;
|
|
|
|
|
|
|
|
if ((param = virTypedParamsGet(params, nparams,
|
|
|
|
VIR_THREADPOOL_WORKERS_PRIORITY)))
|
|
|
|
prioWorkers = param->value.ui;
|
|
|
|
|
|
|
|
if (virNetServerSetThreadPoolParameters(srv, minWorkers,
|
|
|
|
maxWorkers, prioWorkers) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|