External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-05 04:41:20 +00:00
Code Issues Packages Projects Releases Wiki Activity
f19357ce37
libvirt/docs/hacking.html.in

830 lines
25 KiB
HTML
Raw Normal View History

Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<html>
<body>
<h1>Contributor guidelines</h1>
<ul id="toc"></ul>
<h2><a name="patches">General tips for contributing patches</a></h2>
<ol>
<li>Discuss any large changes on the mailing list first. Post patches
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
early and listen to feedback.</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li><p>Post patches in unified diff format. A command similar to this
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
should work:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
diff -urp libvirt.orig/ libvirt.modified/ &gt; libvirt-myfeature.patch
</pre>
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
<p>
or:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
git diff > libvirt-myfeature.patch
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li>Split large changes into a series of smaller patches, self-contained
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
if possible, with an explanation of each patch and an explanation of how
the sequence of patches fits together.</li>
Replace old CVS references with GIT
2010-01-08 00:40:38 +00:00
<li>Make sure your patches apply against libvirt GIT. Developers
only follow GIT and don't care much about released versions.</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li><p>Run the automated tests on your code before submitting any changes.
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
In particular, configure with compile warnings set to -Werror:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
./configure --enable-compile-warnings=error
</pre>
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
<p>
and run the tests:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
make check
make syntax-check
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
make -C tests valgrind
</pre>
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
<p>
The latter test checks for memory leaks.
</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<p>
If you encounter any failing tests, the VIR_TEST_DEBUG
environment variable may provide extra information to debug
the failures. Larger values of VIR_TEST_DEBUG may provide
larger amounts of information:
</p>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
VIR_TEST_DEBUG=1 make check (or)
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
VIR_TEST_DEBUG=2 make check
</pre>
<p>
Also, individual tests can be run from inside the <code>tests/</code>
directory, like:
</p>
<pre>
./qemuxml2xmltest
</pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li>Update tests and/or documentation, particularly if you are adding
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
a new feature or changing the output of a program.</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</ol>
<p>
There is more on this subject, including lots of links to background
reading on the subject, on
<a href="http://et.redhat.com/~rjones/how-to-supply-code-to-open-source-projects/">
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
Richard Jones' guide to working with open source projects</a>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</p>
<h2><a name="indent">Code indentation</a></h2>
<p>
Libvirt's C source code generally adheres to some basic code-formatting
conventions. The existing code base is not totally consistent on this
front, but we do prefer that contributed code be formatted similarly.
In short, use spaces-not-TABs for indentation, use 4 spaces for each
indentation level, and other than that, follow the K&amp;R style.
</p>
<p>
If you use Emacs, add the following to one of one of your start-up files
(e.g., ~/.emacs), to help ensure that you get indentation right:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
;;; When editing C sources in libvirt, use this style.
(defun libvirt-c-mode ()
"C mode with adjusted defaults for use with libvirt."
(interactive)
(c-set-style "K&amp;R")
(setq indent-tabs-mode nil) ; indent using spaces, not TABs
(setq c-indent-level 4)
(setq c-basic-offset 4))
(add-hook 'c-mode-hook
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
'(lambda () (if (string-match "/libvirt" (buffer-file-name))
(libvirt-c-mode))))
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
<h2><a name="formatting">Code formatting (especially for new code)</a></h2>
<p>
With new code, we can be even more strict.
Please apply the following function (using GNU indent) to any new code.
Note that this also gives you an idea of the type of spacing we prefer
around operators and keywords:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
indent-libvirt()
{
indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l75 -lc75 \
-sbi4 -psl -saf -sai -saw -sbi4 -ss -sc -cdw -cli4 -npcs -nbc \
--no-tabs "$@"
}
</pre>
<p>
doc: fix typos in hacking.html.in; mark HACKING as read-only * HACKING: Mark as read-only. Soon we'll generate it from... * docs/hacking.html.in: ... this file. More typo fixes.
2010-03-09 16:59:25 +00:00
Note that sometimes you'll have to post-process that output further, by
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
piping it through <code>expand -i</code>, since some leading TABs can get through.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
Usually they're in macro definitions or strings, and should be converted
anyhow.
</p>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<h2><a name="curly_braces">Curly braces</a></h2>
<p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
Omit the curly braces around an <code>if</code>, <code>while</code>,
<code>for</code> etc. body only
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
when that body occupies a single line. In every other case we require
the braces. This ensures that it is trivially easy to identify a
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
single-<i>statement</i> loop: each has only one <i>line</i> in its body.
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
</p>
<p>
Omitting braces with a single-line body is fine:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
while (expr) // one-line body -> omitting curly braces is ok
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
single_line_stmt();
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
However, the moment your loop/if/else body extends onto a second
line, for whatever reason (even if it's just an added comment), then
you should add braces. Otherwise, it would be too easy to insert a
statement just before that comment (without adding braces), thinking
it is already a multi-statement loop:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
while (true) // BAD! multi-line body with no braces
/* comment... */
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
single_line_stmt();
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
Do this instead:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
while (true) { // Always put braces around a multi-line body.
/* comment... */
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
single_line_stmt();
}
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
There is one exception: when the second body line is not at the same
indentation level as the first body line:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
if (expr)
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
die("a diagnostic that would make this line"
" extend past the 80-column limit"));
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
It is safe to omit the braces in the code above, since the
further-indented second body line makes it obvious that this is still
a single-statement body.
</p>
<p>
To reiterate, don't do this:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
if (expr) // BAD: no braces around...
while (expr_2) { // ... a multi-line body
...
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
}
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
Do this, instead:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
if (expr) {
while (expr_2) {
...
}
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
}
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
However, there is one exception in the other direction, when even a
one-line block should have braces. That occurs when that one-line,
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
brace-less block is an <code>if</code> or <code>else</code>
block, and the counterpart block <b>does</b> use braces. In
that case, put braces around both blocks. Also, if
the <code>else</code> block is much shorter than
the <code>if</code> block, consider negating the
<code>if</code>-condition and swapping the bodies, putting the
short block first and making the longer, multi-line block be the
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<code>else</code> block.
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
if (expr) {
...
...
}
else
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
x = y; // BAD: braceless "else" with braced "then",
// and short block last
if (expr)
x = y; // BAD: braceless "if" with braced "else"
else {
...
...
}
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
Keeping braces consistent and putting the short block first is
preferred, especially when the multi-line body is more than a
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
few lines long, because it is easier to read and grasp the semantics of
an if-then-else block when the simpler block occurs first, rather than
after the more involved block:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
if (!expr) {
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
x = y; // putting the smaller block first is more readable
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
} else {
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
...
...
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
}
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
<p>
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
But if negating a complex condition is too ugly, then at least
add braces:
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
maint: document dislike of mismatched if/else bracing * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange.
2011-01-05 17:58:35 +00:00
if (complex expr not worth negating) {
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
...
...
} else {
x = y;
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
}
</pre>
docs: hacking: explain why using curly braces well is important * docs/hacking.html.in: Use the "curly braces" section from coreutils' HACKING, adapting for libvirt's different formatting style. * HACKING: Sync from the above, still mostly manually.
2010-04-15 17:31:04 +00:00
hacking: add a section on preprocessor conventions * doc/hacking.html.in (preprocessor): New section to document recently-discussed style issues. Signed-off-by: Eric Blake <eblake@redhat.com>
2010-03-09 00:02:45 +00:00
<h2><a href="types">Preprocessor</a></h2>
<p>
For variadic macros, stick with C99 syntax:
docs: <pre> cannot be nested in <p> xsltproc complained about this.
2010-03-13 14:04:34 +00:00
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
hacking: add a section on preprocessor conventions * doc/hacking.html.in (preprocessor): New section to document recently-discussed style issues. Signed-off-by: Eric Blake <eblake@redhat.com>
2010-03-09 00:02:45 +00:00
#define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__)
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
hacking: add a section on preprocessor conventions * doc/hacking.html.in (preprocessor): New section to document recently-discussed style issues. Signed-off-by: Eric Blake <eblake@redhat.com>
2010-03-09 00:02:45 +00:00
<p>Use parenthesis when checking if a macro is defined, and use
indentation to track nesting:
docs: <pre> cannot be nested in <p> xsltproc complained about this.
2010-03-13 14:04:34 +00:00
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
hacking: add a section on preprocessor conventions * doc/hacking.html.in (preprocessor): New section to document recently-discussed style issues. Signed-off-by: Eric Blake <eblake@redhat.com>
2010-03-09 00:02:45 +00:00
#if defined(HAVE_POSIX_FALLOCATE) &amp;&amp; !defined(HAVE_FALLOCATE)
# define fallocate(a,ignored,b,c) posix_fallocate(a,b,c)
#endif
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
hacking: add a section on preprocessor conventions * doc/hacking.html.in (preprocessor): New section to document recently-discussed style issues. Signed-off-by: Eric Blake <eblake@redhat.com>
2010-03-09 00:02:45 +00:00
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<h2><a href="types">C types</a></h2>
<p>
Use the right type.
</p>
<h3>Scalars</h3>
<ul>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<li>If you're using <code>int</code> or <code>long</code>, odds are
good that there's a better type.</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li>If a variable is counting something, be sure to declare it with an
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
unsigned type.</li>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<li>If it's memory-size-related, use <code>size_t</code> (use
<code>ssize_t</code> only if required).</li>
<li>If it's file-size related, use uintmax_t, or maybe <code>off_t</code>.</li>
<li>If it's file-offset related (i.e., signed), use <code>off_t</code>.</li>
<li>If it's just counting small numbers use <code>unsigned int</code>;
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
(on all but oddball embedded systems, you can assume that that
type is at least four bytes wide).</li>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<li>If a variable has boolean semantics, give it the <code>bool</code> type
and use the corresponding <code>true</code> and <code>false</code> macros.
It's ok to include &lt;stdbool.h&gt;, since libvirt's use of gnulib ensures
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
that it exists and is usable.</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li>In the unusual event that you require a specific width, use a
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
standard type like <code>int32_t</code>, <code>uint32_t</code>,
<code>uint64_t</code>, etc.</li>
<li>While using <code>bool</code> is good for readability, it comes with
minor caveats:
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
<ul>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<li>Don't use <code>bool</code> in places where the type size must be constant across
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
all systems, like public interfaces and on-the-wire protocols. Note
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
that it would be possible (albeit wasteful) to use <code>bool</code> in libvirt's
logical wire protocol, since XDR maps that to its lower-level <code>bool_t</code>
type, which <b>is</b> fixed-size.</li>
<li>Don't compare a bool variable against the literal, <code>true</code>,
since a value with a logical non-false value need not be <code>1</code>.
I.e., don't write <code>if (seen == true) ...</code>. Rather,
write <code>if (seen)...</code>.</li>
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
</ul>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</li>
</ul>
<p>
Of course, take all of the above with a grain of salt. If you're about
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
to use some system interface that requires a type like <code>size_t</code>,
<code>pid_t</code> or <code>off_t</code>, use matching types for any
corresponding variables.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</p>
<p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
Also, if you try to use e.g., <code>unsigned int</code> as a type, and that
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
conflicts with the signedness of a related variable, sometimes
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
it's best just to use the <b>wrong</b> type, if <i>pulling the thread</i>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
and fixing all related variables would be too invasive.
</p>
<p>
Finally, while using descriptive types is important, be careful not to
go overboard. If whatever you're doing causes warnings, or requires
casts, then reconsider or ask for help.
</p>
<h3>Pointers</h3>
<p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
Ensure that all of your pointers are <i>const-correct</i>.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
Unless a pointer is used to modify the pointed-to storage,
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
give it the <code>const</code> attribute. That way, the reader knows
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
up-front that this is a read-only pointer. Perhaps more
importantly, if we're diligent about this, when you see a non-const
pointer, you're guaranteed that it is used to modify the storage
it points to, or it is aliased to another pointer that is.
</p>
<h2><a name="memalloc">Low level memory management</a></h2>
<p>
Use of the malloc/free/realloc/calloc APIs is deprecated in the libvirt
codebase, because they encourage a number of serious coding bugs and do
not enable compile time verification of checks for NULL. Instead of these
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
routines, use the macros from memory.h.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</p>
<ul>
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>To allocate a single object:</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<pre>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
virDomainPtr domain;
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
if (VIR_ALLOC(domain) &lt; 0) {
virReportOOMError();
return NULL;
}
</pre>
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>To allocate an array of objects:</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<pre>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
virDomainPtr domains;
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
size_t ndomains = 10;
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
if (VIR_ALLOC_N(domains, ndomains) &lt; 0) {
virReportOOMError();
return NULL;
}
</pre>
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>To allocate an array of object pointers:</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<pre>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
virDomainPtr *domains;
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
size_t ndomains = 10;
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
if (VIR_ALLOC_N(domains, ndomains) &lt; 0) {
virReportOOMError();
return NULL;
}
</pre>
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
<li><p>To re-allocate the array of domains to be 1 element
longer (however, note that repeatedly expanding an array by 1
scales quadratically, so this is recommended only for smaller
arrays):</p>
<pre>
virDomainPtr domains;
size_t ndomains = 0;
if (VIR_EXPAND_N(domains, ndomains, 1) &lt; 0) {
virReportOOMError();
return NULL;
}
domains[ndomains - 1] = domain;
</pre></li>
<li><p>To ensure an array has room to hold at least one more
element (this approach scales better, but requires tracking
allocation separately from usage)</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<pre>
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
virDomainPtr domains;
size_t ndomains = 0;
size_t ndomains_max = 0;
if (VIR_RESIZE_N(domains, ndomains_max, ndomains, 1) &lt; 0) {
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
virReportOOMError();
return NULL;
}
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
domains[ndomains++] = domain;
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
libvirtd: fix bug when shrinking number of clients * daemon/libvirtd.c (qemudRunLoop): Pass allocation size, not current count, to VIR_SHRINK_N. * docs/hacking.html.in: Update doc example. * HACKING: Regenerate.
2010-11-22 19:27:07 +00:00
<li><p>To trim an array of domains from its allocated size down
to the actual used size:</p>
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<pre>
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
virDomainPtr domains;
size_t ndomains = x;
size_t ndomains_max = y;
libvirtd: fix bug when shrinking number of clients * daemon/libvirtd.c (qemudRunLoop): Pass allocation size, not current count, to VIR_SHRINK_N. * docs/hacking.html.in: Update doc example. * HACKING: Regenerate.
2010-11-22 19:27:07 +00:00
VIR_SHRINK_N(domains, ndomains_max, ndomains_max - ndomains);
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
</pre></li>
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
<li><p>To free an array of domains:</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<pre>
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
virDomainPtr domains;
size_t ndomains = x;
size_t ndomains_max = y;
size_t i;
for (i = 0; i &lt; ndomains; i++)
VIR_FREE(domains[i]);
VIR_FREE(domains);
ndomains_max = ndomains = 0;
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
memory: make it easier to avoid quadratic scaling of arrays * src/util/memory.h (VIR_RESIZE_N): New macro. * src/util/memory.c (virResizeN): New function. * src/libvirt_private.syms: Export new helper. * docs/hacking.html.in: Document it. * HACKING: Regenerate.
2010-08-14 15:42:51 +00:00
</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</ul>
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
<h2><a name="file_handling">File handling</a></h2>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
<p>
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
Usage of the <code>fdopen()</code>, <code>close()</code>, <code>fclose()</code>
APIs is deprecated in libvirt code base to help avoiding double-closing of files
or file descriptors, which is particulary dangerous in a multi-threaded
applications. Instead of these APIs, use the macros from files.h
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
</p>
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
<ul>
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>Open a file from a file descriptor:</p>
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
<pre>
if ((file = VIR_FDOPEN(fd, "r")) == NULL) {
virReportSystemError(errno, "%s",
_("failed to open file from file descriptor"));
return -1;
}
/* fd is now invalid; only access the file using file variable */
</pre></li>
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>Close a file descriptor:</p>
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
<pre>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
if (VIR_CLOSE(fd) &lt; 0) {
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
virReportSystemError(errno, "%s", _("failed to close file"));
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
}
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
</pre></li>
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>Close a file:</p>
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
<pre>
if (VIR_FCLOSE(file) &lt; 0) {
virReportSystemError(errno, "%s", _("failed to close file"));
}
</pre></li>
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<li><p>Close a file or file descriptor in an error path, without losing
the previous <code>errno</code> value:</p>
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
<pre>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
VIR_FORCE_CLOSE(fd);
deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() Similarly to deprecating close(), I am now deprecating fclose() and introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE(). Also, fdopen() is replaced with VIR_FDOPEN(). Most of the files are opened in read-only mode, so usage of VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write mode already had the fclose()< 0 check and I converted those to VIR_FCLOSE()< 0. I did not find occurrences of possible double-closed files on the way.
2010-11-17 02:13:29 +00:00
VIR_FORCE_FCLOSE(file);
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
</li>
Introduce VIR_CLOSE to be used rather than close() Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
2010-10-19 14:23:51 +00:00
</ul>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
<h2><a name="string_comparision">String comparisons</a></h2>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<p>
Do not use the strcmp, strncmp, etc functions directly. Instead use
one of the following semantically named macros
</p>
<ul>
<li><p>For strict equality:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
STREQ(a,b)
STRNEQ(a,b)
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
</li>
maint: fix spelling error in hacking * HACKING: STRCASEEQ is case insensitive. * docs/hacking.html.in: Likewise.
2010-01-27 13:33:58 +00:00
<li><p>For case insensitive equality:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
STRCASEEQ(a,b)
STRCASENEQ(a,b)
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
</li>
<li><p>For strict equality of a substring:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
STREQLEN(a,b,n)
STRNEQLEN(a,b,n)
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
</li>
maint: fix spelling error in hacking * HACKING: STRCASEEQ is case insensitive. * docs/hacking.html.in: Likewise.
2010-01-27 13:33:58 +00:00
<li><p>For case insensitive equality of a substring:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
STRCASEEQLEN(a,b,n)
STRCASENEQLEN(a,b,n)
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
</li>
<li><p>For strict equality of a prefix:</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
STRPREFIX(a,b)
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
</li>
</ul>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
<h2><a name="string_copying">String copying</a></h2>
<p>
Do not use the strncpy function. According to the man page, it
does <b>not</b> guarantee a NULL-terminated buffer, which makes
it extremely dangerous to use. Instead, use one of the
functionally equivalent functions:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
virStrncpy(char *dest, const char *src, size_t n, size_t destbytes)
</pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
<p>
The first three arguments have the same meaning as for strncpy;
namely the destination, source, and number of bytes to copy,
respectively. The last argument is the number of bytes
available in the destination string; if a copy of the source
string (including a \0) will not fit into the destination, no
bytes are copied and the routine returns NULL. Otherwise, n
bytes from the source are copied into the destination and a
trailing \0 is appended.
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
virStrcpy(char *dest, const char *src, size_t destbytes)
</pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
<p>
Use this variant if you know you want to copy the entire src
string into dest. Note that this is a macro, so arguments could
be evaluated more than once. This is equivalent to
virStrncpy(dest, src, strlen(src), destbytes)
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
virStrcpyStatic(char *dest, const char *src)
</pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
<p>
Use this variant if you know you want to copy the entire src
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
string into dest <b>and</b> you know that your destination string is
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
a static string (i.e. that sizeof(dest) returns something
meaningful). Note that this is a macro, so arguments could be
evaluated more than once. This is equivalent to
virStrncpy(dest, src, strlen(src), sizeof(dest)).
</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<h2><a name="strbuf">Variable length string buffer</a></h2>
<p>
If there is a need for complex string concatenations, avoid using
the usual sequence of malloc/strcpy/strcat/snprintf functions and
make use of the virBuffer API described in buf.h
</p>
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
<p>Typical usage is as follows:</p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
char *
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
somefunction(...)
{
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
virBuffer buf = VIR_BUFFER_INITIALIZER;
...
virBufferAddLit(&amp;buf, "&lt;domain&gt;\n");
doc: Fix spelling of virBufferVSprintf
2010-11-25 13:48:08 +00:00
virBufferVSprintf(&amp;buf, " &lt;memory&gt;%d&lt;/memory&gt;\n", memory);
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
...
virBufferAddLit(&amp;buf, "&lt;/domain&gt;\n");
Add virBufferFreeAndReset() and replace free() Replace free(virBufferContentAndReset()) with virBufferFreeAndReset(). Update documentation and replace all remaining calls to free() with calls to VIR_FREE(). Also add missing calls to virBufferFreeAndReset() and virReportOOMError() in OOM error cases.
2009-12-09 23:00:50 +00:00
...
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
if (virBufferError(&amp;buf)) {
Add virBufferFreeAndReset() and replace free() Replace free(virBufferContentAndReset()) with virBufferFreeAndReset(). Update documentation and replace all remaining calls to free() with calls to VIR_FREE(). Also add missing calls to virBufferFreeAndReset() and virReportOOMError() in OOM error cases.
2009-12-09 23:00:50 +00:00
virBufferFreeAndReset(&amp;buf);
Remove conn parameter from virReportOOMError
2010-02-04 18:19:08 +00:00
virReportOOMError();
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
return NULL;
}
return virBufferContentAndReset(&amp;buf);
}
</pre>
<h2><a name="includes">Include files</a></h2>
<p>
There are now quite a large number of include files, both libvirt
internal and external, and system includes. To manage all this
complexity it's best to stick to the following general plan for all
*.c source files:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
/*
* Copyright notice
* ....
* ....
* ....
*
*/
#include &lt;config.h&gt; Must come first in every file.
#include &lt;stdio.h&gt; Any system includes you need.
#include &lt;string.h&gt;
#include &lt;limits.h&gt;
#if HAVE_NUMACTL Some system includes aren't supported
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
# include &lt;numa.h&gt; everywhere so need these #if guards.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
#endif
#include "internal.h" Include this first, after system includes.
#include "util.h" Any libvirt internal header files.
#include "buf.h"
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
static int
myInternalFunc() The actual code.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
{
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
...
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
<p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
Of particular note: <b>Do not</b> include libvirt/libvirt.h or
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
libvirt/virterror.h. It is included by "internal.h" already and there
are some special reasons why you cannot include these files
explicitly.
</p>
<h2><a name="printf">Printf-style functions</a></h2>
<p>
Whenever you add a new printf-style function, i.e., one with a format
string argument and following "..." in its prototype, be sure to use
gcc's printf attribute directive in the prototype. For example, here's
the one for virAsprintf, in util.h:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
int virAsprintf(char **strp, const char *fmt, ...)
ATTRIBUTE_FORMAT(printf, 2, 3);
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</pre>
<p>
This makes it so gcc's -Wformat and -Wformat-security options can do
their jobs and cross-check format strings with the number and types
of arguments.
</p>
maint: avoid remaining sprintf uses * cfg.mk (sc_prohibit_sprintf): New rule. (sc_prohibit_asprintf): Avoid false positives. * docs/hacking.html.in (Printf-style functions): Document the policy. * HACKING: Regenerate. * .x-sc_prohibit_sprintf: New exemptions. * Makefile.am (syntax_check_exceptions): Ship new file. * src/vbox/vbox_tmpl.c (vboxStartMachine, vboxAttachUSB): Use virAsprintf instead. * src/uml/uml_driver.c (umlOpenMonitor): Use snprintf instead. * tools/virsh.c (cmdDetachInterface): Likewise. * src/security/security_selinux.c (SELinuxGenSecurityLabel): Likewise. * src/openvz/openvz_driver.c (openvzDomainDefineCmd): Likewise, and ensure large enough buffer.
2010-08-18 23:31:39 +00:00
<p>
When printing to a string, consider using virBuffer for
incremental allocations, virAsprintf for a one-shot allocation,
and snprintf for fixed-width buffers. Do not use sprintf, even
if you can prove the buffer won't overflow, since gnulib does
not provide the same portability guarantees for sprintf as it
does for snprintf.
</p>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
<h2><a name="goto">Use of goto</a></h2>
<p>
The use of goto is not forbidden, and goto is widely used
throughout libvirt. While the uncontrolled use of goto will
quickly lead to unmaintainable code, there is a place for it in
well structured code where its use increases readability and
maintainability. In general, if goto is used for error
recovery, it's likely to be ok, otherwise, be cautious or avoid
it all together.
</p>
<p>
The typical use of goto is to jump to cleanup code in the case
of a long list of actions, any of which may fail and cause the
entire operation to fail. In this case, a function will have a
single label at the end of the function. It's almost always ok
to use this style. In particular, if the cleanup code only
involves free'ing memory, then having multiple labels is
overkill. VIR_FREE() and every function named XXXFree() in
libvirt is required to handle NULL as its arg. Thus you can
safely call free on all the variables even if they were not yet
allocated (yes they have to have been initialized to NULL).
This is much simpler and clearer than having multiple labels.
</p>
<p>
There are a couple of signs that a particular use of goto is not
ok:
</p>
<ul>
<li>You're using multiple labels. If you find yourself using
multiple labels, you're strongly encouraged to rework your code
to eliminate all but one of them.</li>
<li>The goto jumps back up to a point above the current line of
code being executed. Please use some combination of looping
constructs to re-execute code instead; it's almost certainly
going to be more understandable by others. One well-known
exception to this rule is restarting an i/o operation following
EINTR.</li>
<li>The goto jumps down to an arbitrary place in the middle of a
function followed by further potentially failing calls. You
should almost certainly be using a conditional and a block
instead of a goto. Perhaps some of your function's logic would
be better pulled out into a helper function.</li>
</ul>
<p>
Although libvirt does not encourage the Linux kernel wind/unwind
style of multiple labels, there's a good general discussion of
the issue archived at
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<a href="http://kerneltrap.org/node/553/2131">KernelTrap</a>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
</p>
<p>
When using goto, please use one of these standard labels if it
makes sense:
</p>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
<pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
error: A path only taken upon return with an error code
cleanup: A path taken upon return with success code + optional error
no_memory: A path only taken upon return with an OOM error code
memory: make it safer to expand arrays * src/util/memory.h (VIR_REALLOC_N): Update docs. (VIR_EXPAND_N, VIR_SHRINK_N): New macros. (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some gcc attributes. * src/util/memory.c (virExpandN, virShrinkN): New functions. (virReallocN): Update docs. * src/libvirt_private.syms: Export new helpers. * docs/hacking.html.in: Prefer newer interfaces over VIR_REALLOC_N, since uninitialized memory can bite us. * HACKING: Regenerate.
2010-08-13 21:00:47 +00:00
retry: If needing to jump upwards (e.g., retry on EINTR)
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
</pre>
Update hacking.html.in * Added section on use of goto * Added missing content from HACKING document
2010-03-08 15:26:30 +00:00
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
doc: fix typos in hacking.html.in; mark HACKING as read-only * HACKING: Mark as read-only. Soon we'll generate it from... * docs/hacking.html.in: ... this file. More typo fixes.
2010-03-09 16:59:25 +00:00
<h2><a name="committers">Libvirt committer guidelines</a></h2>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<p>
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
The AUTHORS files indicates the list of people with commit access right
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
who can actually merge the patches.
</p>
<p>
doc: fix typos in hacking.html.in; mark HACKING as read-only * HACKING: Mark as read-only. Soon we'll generate it from... * docs/hacking.html.in: ... this file. More typo fixes.
2010-03-09 16:59:25 +00:00
The general rule for committing a patch is to make sure
it has been reviewed
properly in the mailing-list first, usually if a couple of people gave an
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
ACK or +1 to a patch and nobody raised an objection on the list it should
doc: fix typos in hacking.html.in; mark HACKING as read-only * HACKING: Mark as read-only. Soon we'll generate it from... * docs/hacking.html.in: ... this file. More typo fixes.
2010-03-09 16:59:25 +00:00
be good to go. If the patch touches a part of the code where you're not
the main maintainer, or where you do not have a very clear idea of
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
how things work, it's better
to wait for a more authoritative feedback though. Before committing, please
also rebuild locally, run 'make check syntax-check', and make sure you
don't raise errors. Try to look for warnings too; for example,
configure with
docs: <pre> cannot be nested in <p> xsltproc complained about this.
2010-03-13 14:04:34 +00:00
</p>
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
<pre>
docs: Prepare hacking.html.in to generate HACKING from it Tweak pre tags to achieve proper indentation of their plaintext representation. Also use more b/i/code tags.
2010-11-12 14:33:00 +00:00
--enable-compile-warnings=error
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
</pre>
docs: <pre> cannot be nested in <p> xsltproc complained about this.
2010-03-13 14:04:34 +00:00
<p>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
which adds -Werror to compile flags, so no warnings get missed
</p>
<p>
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
An exception to 'review and approval on the list first' is fixing failures
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
to build:
</p>
<ul>
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
<li>if a recently committed patch breaks compilation on a platform
or for a given driver, then it's fine to commit a minimal fix
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
directly without getting the review feedback first</li>
docs: Refer to virReportOOMError in the HACKING file Instead of refering to __virRaiseError(VIR_ERROR_NO_MEMORY).
2010-01-30 11:35:04 +00:00
<li>if make check or make syntax-check breaks, if there is
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
an obvious fix, it's fine to commit immediately.
The patch should still be sent to the list (or tell what the fix was if
hacking: fix typos * docs/hacking.html.in (committers): Fix spelling and grammar.
2010-03-09 00:02:44 +00:00
trivial), and 'make check syntax-check' should pass too, before committing
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
anything</li>
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
<li>
Cleanup whitespace in docs This patch is the result of running the following command in the docs directory: sed -i 's/\t/ /g; s/\s*$//' *.html.in * docs/*.html.in:convert tabs into 8 spaces and remove trailing whitespace
2009-11-06 15:04:19 +00:00
fixes for documentation and code comments can be managed
in the same way, but still make sure they get reviewed if non-trivial.
Add HACKING doc to the website
2009-06-29 11:09:17 +00:00
</li>
</ul>
</body>
</html>
Reference in New Issue Copy Permalink