qemu: only stop external devices after the domain

A failure in qemuProcessLaunch would lead to qemuExtDevicesStop
being called twice - once in the cleanup section and then again
in qemuProcessStop.

However, the first one is called while the QEMU process is
still running, which is too soon for the swtpm process, because
the swtmp_ioctl command can lock up:

https://bugzilla.redhat.com/show_bug.cgi?id=1822523

Remove the first call and only leave the one in qemuProcessStop,
which is called after the QEMU process is killed.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Ján Tomko 2020-05-12 12:59:07 +02:00
parent 9d190efc85
commit 006782a8bc

View File

@ -6992,8 +6992,6 @@ qemuProcessLaunch(virConnectPtr conn,
ret = 0;
cleanup:
if (ret < 0)
qemuExtDevicesStop(driver, vm);
qemuDomainSecretDestroy(vm);
return ret;
}