External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuxmlconftest: Don't use soon-to-be-removed machine types

Browse Source 
Latest qemu will be dropping some very old machine types (2.0 - 2.3) and
some of our tests use them. As in none of the cases the test actually
needs given machine type, switch them to 'pc' instead.

In one case 'numavcpus-topology-mismatch' this caused switch to a more
modern syntax for NUMA memory specification, but the test is testing a
different aspect, thus we can modernize this.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2024-08-08 17:11:04 +02:00
parent c122aa1021
commit 022457e748
25 changed files with 29 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/qemuxmlconfdata/controller-usb-order.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-rhel7/.config \
-name guest=rhel7,debug-threads=on \ -name guest=rhel7,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-rhel7/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-rhel7/master-key.aes"}' \
-machine pc-i440fx-2.3,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
-accel kvm \ -accel kvm \
-cpu qemu64 \ -cpu qemu64 \
-m size=2097152k \ -m size=2097152k \

2
tests/qemuxmlconfdata/controller-usb-order.x86_64-latest.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>2097152</currentMemory> <currentMemory unit='KiB'>2097152</currentMemory>
<vcpu placement='static'>2</vcpu> <vcpu placement='static'>2</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/controller-usb-order.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>2097152</currentMemory> <currentMemory unit='KiB'>2097152</currentMemory>
<vcpu placement='static'>2</vcpu> <vcpu placement='static'>2</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<on_poweroff>destroy</on_poweroff> <on_poweroff>destroy</on_poweroff>

2
tests/qemuxmlconfdata/disk-network-rbd-encryption-layering.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-encryptdisk/.config \
-name guest=encryptdisk,debug-threads=on \ -name guest=encryptdisk,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \
-machine pc-i440fx-2.1,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
-accel tcg \ -accel tcg \
-cpu qemu64 \ -cpu qemu64 \
-m size=1048576k \ -m size=1048576k \

2
tests/qemuxmlconfdata/disk-network-rbd-encryption-layering.x86_64-latest.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/disk-network-rbd-encryption-layering.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<clock offset='utc'/> <clock offset='utc'/>

2
tests/qemuxmlconfdata/disk-network-rbd-encryption-luks-any.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-encryptdisk/.config \
-name guest=encryptdisk,debug-threads=on \ -name guest=encryptdisk,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \
-machine pc-i440fx-2.1,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
-accel tcg \ -accel tcg \
-cpu qemu64 \ -cpu qemu64 \
-m size=1048576k \ -m size=1048576k \

2
tests/qemuxmlconfdata/disk-network-rbd-encryption-luks-any.x86_64-latest.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/disk-network-rbd-encryption-luks-any.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<clock offset='utc'/> <clock offset='utc'/>

2
tests/qemuxmlconfdata/disk-network-rbd-encryption.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-encryptdisk/.config \
-name guest=encryptdisk,debug-threads=on \ -name guest=encryptdisk,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \
-machine pc-i440fx-2.1,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
-accel tcg \ -accel tcg \
-cpu qemu64 \ -cpu qemu64 \
-m size=1048576k \ -m size=1048576k \

2
tests/qemuxmlconfdata/disk-network-rbd-encryption.x86_64-latest.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/disk-network-rbd-encryption.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<clock offset='utc'/> <clock offset='utc'/>

2
tests/qemuxmlconfdata/luks-disk-invalid.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<clock offset='utc'/> <clock offset='utc'/>

2
tests/qemuxmlconfdata/luks-disks-source.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-encryptdisk/.config \
-name guest=encryptdisk,debug-threads=on \ -name guest=encryptdisk,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \
-machine pc-i440fx-2.1,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
-accel tcg \ -accel tcg \
-cpu qemu64 \ -cpu qemu64 \
-m size=1048576k \ -m size=1048576k \

2
tests/qemuxmlconfdata/luks-disks-source.x86_64-latest.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/luks-disks-source.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<clock offset='utc'/> <clock offset='utc'/>

2
tests/qemuxmlconfdata/luks-disks.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-encryptdisk/.config \
-name guest=encryptdisk,debug-threads=on \ -name guest=encryptdisk,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-encryptdisk/master-key.aes"}' \
-machine pc-i440fx-2.1,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
-accel tcg \ -accel tcg \
-cpu qemu64 \ -cpu qemu64 \
-m size=1048576k \ -m size=1048576k \

2
tests/qemuxmlconfdata/luks-disks.xml
View File

@ -5,7 +5,7 @@
<currentMemory unit='KiB'>524288</currentMemory> <currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu> <vcpu placement='static'>1</vcpu>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.1'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/memfd-memory-default-hugepage.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-instance-00000092/.config \
-name guest=instance-00000092,debug-threads=on \ -name guest=instance-00000092,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-instance-00000092/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-instance-00000092/master-key.aes"}' \
-machine pc-i440fx-2.3,usb=off,dump-guest-core=off,acpi=off \ -machine pc,usb=off,dump-guest-core=off,acpi=off \
-accel kvm \ -accel kvm \
-cpu qemu64 \ -cpu qemu64 \
-m size=14680064k \ -m size=14680064k \

2
tests/qemuxmlconfdata/memfd-memory-default-hugepage.xml
View File

@ -14,7 +14,7 @@
<memnode cellid='0' mode='preferred' nodeset='3'/> <memnode cellid='0' mode='preferred' nodeset='3'/>
</numatune> </numatune>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/memfd-memory-numa.x86_64-latest.args
View File

@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-instance-00000092/.config \
-name guest=instance-00000092,debug-threads=on \ -name guest=instance-00000092,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-instance-00000092/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-instance-00000092/master-key.aes"}' \
-machine pc-i440fx-2.3,usb=off,dump-guest-core=off,nvdimm=on,acpi=off \ -machine pc,usb=off,dump-guest-core=off,nvdimm=on,acpi=off \
-accel kvm \ -accel kvm \
-cpu qemu64 \ -cpu qemu64 \
-m size=14680064k,slots=16,maxmem=1099511627776k \ -m size=14680064k,slots=16,maxmem=1099511627776k \

2
tests/qemuxmlconfdata/memfd-memory-numa.xml
View File

@ -17,7 +17,7 @@
<memnode cellid='0' mode='preferred' nodeset='3'/> <memnode cellid='0' mode='preferred' nodeset='3'/>
</numatune> </numatune>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

8
tests/qemuxmlconfdata/numavcpus-topology-mismatch.x86_64-latest.args
View File

@ -10,14 +10,16 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-dummy/.config \
-name guest=dummy,debug-threads=on \ -name guest=dummy,debug-threads=on \
-S \ -S \
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-dummy/master-key.aes"}' \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-dummy/master-key.aes"}' \
-machine pc-i440fx-2.3,usb=off,dump-guest-core=off,acpi=off \ -machine pc,usb=off,dump-guest-core=off,acpi=off \
-accel kvm \ -accel kvm \
-cpu qemu64 \ -cpu qemu64 \
-m size=7864320k,slots=16,maxmem=16777216k \ -m size=7864320k,slots=16,maxmem=16777216k \
-overcommit mem-lock=off \ -overcommit mem-lock=off \
-smp 12,sockets=12,cores=1,threads=1 \ -smp 12,sockets=12,cores=1,threads=1 \
-numa node,nodeid=0,cpus=0-1,cpus=5,cpus=7-11,mem=3840 \ -object '{"qom-type":"memory-backend-ram","id":"ram-node0","size":4026531840,"host-nodes":[0,1,2,3],"policy":"bind"}' \
-numa node,nodeid=1,cpus=2-4,cpus=6,mem=3840 \ -numa node,nodeid=0,cpus=0-1,cpus=5,cpus=7-11,memdev=ram-node0 \
-object '{"qom-type":"memory-backend-ram","id":"ram-node1","size":4026531840,"host-nodes":[0,1,2,3],"policy":"bind"}' \
-numa node,nodeid=1,cpus=2-4,cpus=6,memdev=ram-node1 \
-uuid 4d92ec27-9ebf-400b-ae91-20c71c647c19 \ -uuid 4d92ec27-9ebf-400b-ae91-20c71c647c19 \
-display none \ -display none \
-no-user-config \ -no-user-config \

2
tests/qemuxmlconfdata/numavcpus-topology-mismatch.x86_64-latest.xml
View File

@ -9,7 +9,7 @@
<memory mode='strict' placement='auto'/> <memory mode='strict' placement='auto'/>
</numatune> </numatune>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu mode='custom' match='exact' check='none'> <cpu mode='custom' match='exact' check='none'>

2
tests/qemuxmlconfdata/numavcpus-topology-mismatch.xml
View File

@ -9,7 +9,7 @@
<memory mode='strict' placement='auto'/> <memory mode='strict' placement='auto'/>
</numatune> </numatune>
<os> <os>
<type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type> <type arch='x86_64' machine='pc'>hvm</type>
<boot dev='hd'/> <boot dev='hd'/>
</os> </os>
<cpu> <cpu>