From 02e7466f76591c17d9f10b93d0137591f0cf7826 Mon Sep 17 00:00:00 2001 From: Matt Coleman Date: Thu, 5 Nov 2020 22:32:46 -0500 Subject: [PATCH] domain_conf: make virDomainDiskDefFormatIotune() void This function always returns zero, so it might as well be void. Signed-off-by: Matt Coleman Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9b3e2a5bcb..0cc385878b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -25605,7 +25605,7 @@ virDomainDiskBackingStoreFormat(virBufferPtr buf, disk->blkdeviotune.val); \ } -static int +static void virDomainDiskDefFormatIotune(virBufferPtr buf, virDomainDiskDefPtr disk) { @@ -25643,8 +25643,6 @@ virDomainDiskDefFormatIotune(virBufferPtr buf, FORMAT_IOTUNE(write_iops_sec_max_length); virXMLFormatElement(buf, "iotune", NULL, &childBuf); - - return 0; } #undef FORMAT_IOTUNE @@ -25880,8 +25878,7 @@ virDomainDiskDefFormat(virBufferPtr buf, } virBufferAddLit(buf, "/>\n"); - if (virDomainDiskDefFormatIotune(buf, def) < 0) - return -1; + virDomainDiskDefFormatIotune(buf, def); if (def->src->readonly) virBufferAddLit(buf, "\n");