External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virSecretLookupDefCopy: Remove return value

Browse Source 
The function always returns succes so there's no need for a return
value.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2020-03-19 15:27:40 +01:00
parent 1a86e3b24a
commit 02f909b8a6
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/util/virsecret.c
View File

@ -48,7 +48,7 @@ virSecretLookupDefClear(virSecretLookupTypeDefPtr def)
} }
int void
virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst, virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
const virSecretLookupTypeDef *src) const virSecretLookupTypeDef *src)
{ {
@ -58,7 +58,6 @@ virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
} else if (dst->type == VIR_SECRET_LOOKUP_TYPE_USAGE) { } else if (dst->type == VIR_SECRET_LOOKUP_TYPE_USAGE) {
dst->u.usage = g_strdup(src->u.usage); dst->u.usage = g_strdup(src->u.usage);
} }
return 0;
} }

4
src/util/virsecret.h
View File

@ -48,8 +48,8 @@ struct _virSecretLookupTypeDef {
}; };
void virSecretLookupDefClear(virSecretLookupTypeDefPtr def); void virSecretLookupDefClear(virSecretLookupTypeDefPtr def);
int virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst, void virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
const virSecretLookupTypeDef *src); const virSecretLookupTypeDef *src);
int virSecretLookupParseSecret(xmlNodePtr secretnode, int virSecretLookupParseSecret(xmlNodePtr secretnode,
virSecretLookupTypeDefPtr def); virSecretLookupTypeDefPtr def);
void virSecretLookupFormatSecret(virBufferPtr buf, void virSecretLookupFormatSecret(virBufferPtr buf,

3
src/util/virstoragefile.c
View File

@ -1792,8 +1792,7 @@ virStorageAuthDefCopy(const virStorageAuthDef *src)
authdef->secrettype = g_strdup(src->secrettype); authdef->secrettype = g_strdup(src->secrettype);
authdef->authType = src->authType; authdef->authType = src->authType;
if (virSecretLookupDefCopy(&authdef->seclookupdef, &src->seclookupdef) < 0) virSecretLookupDefCopy(&authdef->seclookupdef, &src->seclookupdef);
return NULL;
return g_steal_pointer(&authdef); return g_steal_pointer(&authdef);
} }