External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-23 04:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

bridge: don't crash on bandwidth unplug with no bandwidth

Browse Source 
If networkUnplugBandwidth is called on a network which has
no bandwidth defined, print a warning instead of crashing.

This can happen when destroying a domain with bandwidth if
bandwidth was removed from the network after the domain was
started.

https://bugzilla.redhat.com/show_bug.cgi?id=975359
(cherry picked from commit 658c932ab4aec2222b0ce3840a96748e73b39b3f)
This commit is contained in:
Ján Tomko 2013-06-21 19:20:31 +02:00
parent 1b4cd1e5f0
commit 0347e778ca
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/network/bridge_driver.c
View File

@ -4750,6 +4750,11 @@ networkUnplugBandwidth(virNetworkObjPtr net,
if (iface->data.network.actual && if (iface->data.network.actual &&
iface->data.network.actual->class_id) { iface->data.network.actual->class_id) {
if (!net->def->bandwidth || !net->def->bandwidth->in) {
VIR_WARN("Network %s has no bandwidth but unplug requested",
net->def->name);
goto cleanup;
}
/* we must remove class from bridge */ /* we must remove class from bridge */
new_rate = net->def->bandwidth->in->average; new_rate = net->def->bandwidth->in->average;