From 0361917619963d4bc6e9c8215368beaab9db2c5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Wed, 28 Nov 2012 14:34:51 +0100 Subject: [PATCH] conf: snapshot: check return value of virDomainSnapshotObjListNum If it's negative, this might result in a request to allocate lots of memory. --- src/conf/snapshot_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 72bdd30221..06be34d926 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -1026,7 +1026,7 @@ virDomainListSnapshots(virDomainSnapshotObjListPtr snapshots, int ret = -1; int i; - if (!snaps) + if (!snaps || count < 0) return count; if (VIR_ALLOC_N(names, count) < 0 || VIR_ALLOC_N(list, count + 1) < 0) {