External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-05 05:45:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

nss: Need to check error condition on virJSONValueArraySize

Browse Source 
If the 'nleases < 0' on return, then the subsequent call to
findLeaseInJSON will not produce the expected results (passed
in as a size_t, but nleases is a ssize_t).  So check if the
returned value < 0 and if so, goto cleanup.

Found by Coverity as a NEGATIVE_RETURNS event
This commit is contained in:
John Ferlan 2016-12-07 08:10:30 -05:00
parent 80acf4b867
commit 03876cf506
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/nss/libvirt_nss.c
View File

@ -309,7 +309,8 @@ findLease(const char *name,
}
VIR_DIR_CLOSE(dir);
nleases = virJSONValueArraySize(leases_array);
if ((nleases = virJSONValueArraySize(leases_array)) < 0)
goto cleanup;
DEBUG("Read %zd leases", nleases);
#if !defined(LIBVIRT_NSS_GUEST)