From 03da89d14188ce27a6c7ad3b9b946d6e39802b0f Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Tue, 18 Sep 2012 17:34:25 -0600 Subject: [PATCH] util: don't print free'd dmidecode path The path was freed before printing the error message, resulting in: error : virSysinfoRead:773 : internal error Failed to execute command (null) But virCommandRun already gives a better error message. * src/util/sysinfo.c (virSysinfoRead): Avoid overwriting error. --- src/util/sysinfo.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c index 92c35395fd..7f0a45b5ca 100644 --- a/src/util/sysinfo.c +++ b/src/util/sysinfo.c @@ -767,12 +767,8 @@ virSysinfoRead(void) { cmd = virCommandNewArgList(path, "-q", "-t", "0,1,4,17", NULL); VIR_FREE(path); virCommandSetOutputBuffer(cmd, &outbuf); - if (virCommandRun(cmd, NULL) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to execute command %s"), - path); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } if (VIR_ALLOC(ret) < 0) goto no_memory;