External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-25 15:15:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: Fix deadlock when cloning across pools.

Browse Source 
We need to unlock the first pool before looking up the second, since the
search locks every pool it checks.
This commit is contained in:
Cole Robinson 2009-07-10 12:56:12 -04:00
parent a500d73ac0
commit 045176bf35
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/storage_driver.c
View File

@ -1327,9 +1327,11 @@ storageVolumeCreateXMLFrom(virStoragePoolPtr obj,
storageDriverLock(driver); storageDriverLock(driver);
pool = virStoragePoolObjFindByUUID(&driver->pools, obj->uuid); pool = virStoragePoolObjFindByUUID(&driver->pools, obj->uuid);
if (diffpool) if (diffpool) {
virStoragePoolObjUnlock(pool);
origpool = virStoragePoolObjFindByName(&driver->pools, vobj->pool); origpool = virStoragePoolObjFindByName(&driver->pools, vobj->pool);
else virStoragePoolObjLock(pool);
} else
origpool = pool; origpool = pool;
storageDriverUnlock(driver); storageDriverUnlock(driver);