mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-03-07 17:28:15 +00:00
xen_common: Resolve Coverity USE_AFTER_FREE
There were two warnings in this module If the VIR_ALLOC_N(def->serials, 1) fails, then a virDomainChrDefFree(chr) is called and we jump to cleanup which makes the same call. Just remove the one after VIR_ALLOC_N() In the label "skipnic:" a virDomainNetDefFree(net) is made; however, if in going back to the top of the loop we jump back down to skipnic for any reason, the call will attempt to free an already freed structure since "net" was not passed by reference to virDomainNetDefFree(). Just set net = NULL in skipnic: to resolve the issue.
This commit is contained in:
parent
0da9a8a8bf
commit
0454f23c31
@ -776,10 +776,8 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def)
|
||||
!(chr = xenParseSxprChar(str, NULL)))
|
||||
goto cleanup;
|
||||
if (chr) {
|
||||
if (VIR_ALLOC_N(def->serials, 1) < 0) {
|
||||
virDomainChrDefFree(chr);
|
||||
if (VIR_ALLOC_N(def->serials, 1) < 0)
|
||||
goto cleanup;
|
||||
}
|
||||
chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL;
|
||||
chr->target.port = 0;
|
||||
def->serials[0] = chr;
|
||||
@ -953,6 +951,7 @@ xenParseVif(virConfPtr conf, virDomainDefPtr def)
|
||||
skipnic:
|
||||
list = list->next;
|
||||
virDomainNetDefFree(net);
|
||||
net = NULL;
|
||||
VIR_FREE(script);
|
||||
}
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user