External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-30 16:35:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

virfirewalltest: Don't duplicate string when adding it onto stringlist

Browse Source 
In our wrapper of g_dbus_connection_call_sync() in
virfirewalltest a string is duplicated and added onto a
virStringList. This leads to a memory leak because
virStringListAdd() duplicates the string itself.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Michal Privoznik 2020-10-02 10:37:26 +02:00
parent 2c4ebab4f5
commit 053beeb04d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/virfirewalltest.c
View File

@ -122,7 +122,7 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync,
doError = true;
}
virStringListAdd(&args, g_strdup(item));
virStringListAdd(&args, item);
}
if (fwBuf) {