External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 13:37:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

bhyve: fix NULL pointer check position

Browse Source 
src/bhyve/bhyve_parse_command.c:437:9: warning: Either the condition
'!config' is redundant or there is possible null pointer dereference:
config. [nullPointerRedundantCheck]

src/bhyve/bhyve_parse_command.c:280:23: warning: Either the condition
'!separator' is redundant or there is pointer arithmetic
with NULL pointer. [nullPointerArithmeticRedundantCheck]

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
This commit is contained in:
Ján Tomko 2020-08-02 22:50:37 +02:00
parent 7e574d1a07
commit 05c1b9e8e8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/bhyve/bhyve_parse_command.c
View File

@ -277,11 +277,11 @@ bhyveParseBhyveLPCArg(virDomainDefPtr def,
char *type = NULL;
separator = strchr(arg, ',');
param = separator + 1;
if (!separator)
goto error;
param = separator + 1;
type = g_strndup(arg, separator - arg);
/* Only support com%d */
@ -434,14 +434,14 @@ bhyveParsePCIDisk(virDomainDefPtr def,
disk->info.addr.pci.slot = pcislot;
disk->info.addr.pci.function = function;
if (!config)
goto error;
if (STRPREFIX(config, "/dev/"))
disk->src->type = VIR_STORAGE_TYPE_BLOCK;
else
disk->src->type = VIR_STORAGE_TYPE_FILE;
if (!config)
goto error;
separator = strchr(config, ',');
if (separator)
disk->src->path = g_strndup(config, separator - config);