External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-02 04:15:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Check return status for libxlxml2domconfigtest

Browse Source 
Commit id d8e8b63d introduced the test, but neglected to check for
error from virTestLoadFile in testCompareXMLToDomConfig.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Katerina Koukiou <kkoukiou@redhat.com>
This commit is contained in:
John Ferlan 2018-02-14 07:12:35 -05:00
parent 30b2ebb284
commit 05c41f4f1d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/libxlxml2domconfigtest.c
View File

@ -104,7 +104,9 @@ testCompareXMLToDomConfig(const char *xmlfile,
goto cleanup; goto cleanup;
} }
virTestLoadFile(jsonfile, &tempjson); if (virTestLoadFile(jsonfile, &tempjson) < 0)
goto cleanup;
if (libxl_domain_config_from_json(cfg->ctx, &expectconfig, tempjson) != 0) { if (libxl_domain_config_from_json(cfg->ctx, &expectconfig, tempjson) != 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s", virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
"Failed to create libxl_domain_config from JSON doc"); "Failed to create libxl_domain_config from JSON doc");