External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-03 12:55:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

vsh: Pass correct values for command line completion

Browse Source 
Commit id 'dcfdf341' passes 'opts_need_arg' and 'opts_seen' to
vshCmddefGetData, but that seems to be incorrect as those values
are not initialized properly (something at least one compiler found).
Instead the static 'const_opts_need_arg' and 'const_opts_seen' values
should be passed.

By passing unitialized values leads to not finding possible options
for simpler commands (domfsfreeze for example), where if you're in
a virsh shell using command line completion - you'll get a list of
files in your current directory instead of two options --domain and
--mountpoint (as would happen with this patch applied.
This commit is contained in:
John Ferlan 2016-10-28 16:59:58 -04:00
parent 011935457a
commit 06a7b1ff4d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/vsh.c
View File

@ -2788,7 +2788,8 @@ vshReadlineParse(const char *text, int state)
/* No -- option provided and some other token given /* No -- option provided and some other token given
* Try to find the default option. * Try to find the default option.
*/ */
if (!(opt = vshCmddefGetData(cmd, &opts_need_arg, &opts_seen)) if (!(opt = vshCmddefGetData(cmd, &const_opts_need_arg,
&const_opts_seen))
|| opt->type == VSH_OT_BOOL) || opt->type == VSH_OT_BOOL)
goto error; goto error;
opt_exists = true; opt_exists = true;