External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-31 00:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolve Coverity CHECKED_RETURN

Browse Source 
Coverity complained that checking the return of virDomainCreate()
was not consistent amongst the callers - so added the return check
to the objecteventtest.c and adjust the virt-login-shell to compare
< 0 rather than just non zero for the failure condition.
This commit is contained in:
John Ferlan 2014-09-12 08:16:07 -04:00
parent 0268a35db4
commit 07334ccbac
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/objecteventtest.c
View File

@ -359,7 +359,8 @@ testDomainStartStopEvent(const void *data)
/* Test domain is started */
virDomainDestroy(dom);
virDomainCreate(dom);
if (virDomainCreate(dom) < 0)
goto cleanup;
if (virEventRunDefaultImpl() < 0)
goto cleanup;

2
tools/virt-login-shell.c
View File

@ -275,7 +275,7 @@ main(int argc, char **argv)
if (!dom)
goto cleanup;
if (!virDomainIsActive(dom) && virDomainCreate(dom)) {
if (!virDomainIsActive(dom) && virDomainCreate(dom) < 0) {
virErrorPtr last_error;
last_error = virGetLastError();
if (last_error->code != VIR_ERR_OPERATION_INVALID) {