mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-02-22 11:22:23 +00:00
Rename virDomainHasBlockjob as qemuDomainHasBlockjob
And move it to qemu_domain.[ch] because this API is QEMU-only. Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
parent
890fa6a055
commit
078717e151
@ -12317,33 +12317,6 @@ virDomainDiskRemoveByName(virDomainDefPtr def, const char *name)
|
||||
return virDomainDiskRemove(def, idx);
|
||||
}
|
||||
|
||||
/**
|
||||
* virDomainHasBlockjob:
|
||||
* @vm: domain object
|
||||
* @copy_only: Reject only block copy job
|
||||
*
|
||||
* Return true if @vm has at least one disk involved in a current block
|
||||
* copy/commit/pull job. If @copy_only is true this returns true only if the
|
||||
* disk is involved in a block copy.
|
||||
* */
|
||||
bool
|
||||
virDomainHasBlockjob(virDomainObjPtr vm,
|
||||
bool copy_only)
|
||||
{
|
||||
size_t i;
|
||||
for (i = 0; i < vm->def->ndisks; i++) {
|
||||
if (!copy_only &&
|
||||
vm->def->disks[i]->blockjob)
|
||||
return true;
|
||||
|
||||
if (vm->def->disks[i]->mirror &&
|
||||
vm->def->disks[i]->mirrorJob == VIR_DOMAIN_BLOCK_JOB_TYPE_COPY)
|
||||
return true;
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
int virDomainNetInsert(virDomainDefPtr def, virDomainNetDefPtr net)
|
||||
{
|
||||
/* hostdev net devices must also exist in the hostdevs array */
|
||||
|
@ -2697,9 +2697,6 @@ int virDomainDiskSourceParse(xmlNodePtr node,
|
||||
xmlXPathContextPtr ctxt,
|
||||
virStorageSourcePtr src);
|
||||
|
||||
bool virDomainHasBlockjob(virDomainObjPtr vm,
|
||||
bool copy_only);
|
||||
|
||||
int virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net);
|
||||
virDomainNetDefPtr virDomainNetFind(virDomainDefPtr def, const char *device);
|
||||
bool virDomainHasNet(virDomainDefPtr def, virDomainNetDefPtr net);
|
||||
|
@ -308,7 +308,6 @@ virDomainGraphicsTypeFromString;
|
||||
virDomainGraphicsTypeToString;
|
||||
virDomainGraphicsVNCSharePolicyTypeFromString;
|
||||
virDomainGraphicsVNCSharePolicyTypeToString;
|
||||
virDomainHasBlockjob;
|
||||
virDomainHasNet;
|
||||
virDomainHostdevCapsTypeToString;
|
||||
virDomainHostdevDefAlloc;
|
||||
|
@ -2828,6 +2828,34 @@ qemuDomainDiskBlockJobIsActive(virDomainDiskDefPtr disk)
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* qemuDomainHasBlockjob:
|
||||
* @vm: domain object
|
||||
* @copy_only: Reject only block copy job
|
||||
*
|
||||
* Return true if @vm has at least one disk involved in a current block
|
||||
* copy/commit/pull job. If @copy_only is true this returns true only if the
|
||||
* disk is involved in a block copy.
|
||||
* */
|
||||
bool
|
||||
qemuDomainHasBlockjob(virDomainObjPtr vm,
|
||||
bool copy_only)
|
||||
{
|
||||
size_t i;
|
||||
for (i = 0; i < vm->def->ndisks; i++) {
|
||||
if (!copy_only &&
|
||||
vm->def->disks[i]->blockjob)
|
||||
return true;
|
||||
|
||||
if (vm->def->disks[i]->mirror &&
|
||||
vm->def->disks[i]->mirrorJob == VIR_DOMAIN_BLOCK_JOB_TYPE_COPY)
|
||||
return true;
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
qemuDomainUpdateDeviceList(virQEMUDriverPtr driver,
|
||||
virDomainObjPtr vm,
|
||||
|
@ -432,6 +432,8 @@ int qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobInfo,
|
||||
int qemuDomainSupportsBlockJobs(virDomainObjPtr vm, bool *modern)
|
||||
ATTRIBUTE_NONNULL(1);
|
||||
bool qemuDomainDiskBlockJobIsActive(virDomainDiskDefPtr disk);
|
||||
bool qemuDomainHasBlockjob(virDomainObjPtr vm, bool copy_only)
|
||||
ATTRIBUTE_NONNULL(1);
|
||||
|
||||
int qemuDomainAlignMemorySizes(virDomainDefPtr def);
|
||||
void qemuDomainMemoryDeviceAlignSize(virDomainMemoryDefPtr mem);
|
||||
|
@ -7736,7 +7736,7 @@ static virDomainPtr qemuDomainDefineXMLFlags(virConnectPtr conn, const char *xml
|
||||
|
||||
virObjectRef(vm);
|
||||
def = NULL;
|
||||
if (virDomainHasBlockjob(vm, true)) {
|
||||
if (qemuDomainHasBlockjob(vm, true)) {
|
||||
virReportError(VIR_ERR_BLOCK_COPY_ACTIVE, "%s",
|
||||
_("domain has active block job"));
|
||||
virDomainObjAssignDef(vm, NULL, false, NULL);
|
||||
@ -15624,7 +15624,7 @@ qemuDomainRevertToSnapshot(virDomainSnapshotPtr snapshot,
|
||||
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
||||
goto cleanup;
|
||||
|
||||
if (virDomainHasBlockjob(vm, false)) {
|
||||
if (qemuDomainHasBlockjob(vm, false)) {
|
||||
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
||||
_("domain has active block job"));
|
||||
goto cleanup;
|
||||
|
@ -2067,7 +2067,7 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver, virDomainObjPtr vm,
|
||||
|
||||
}
|
||||
|
||||
if (virDomainHasBlockjob(vm, false)) {
|
||||
if (qemuDomainHasBlockjob(vm, false)) {
|
||||
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
||||
_("domain has an active block job"));
|
||||
return false;
|
||||
|
Loading…
x
Reference in New Issue
Block a user