External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: comment on why we're not adopting certain flake8 rules

Browse Source 
Simplify the list of ignored warnings now that we only have two left,
and document why we're not honouring them.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2019-10-08 10:38:29 +01:00
parent 3df69e628f
commit 07943d35ea
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
build-aux/syntax-check.mk
View File

@ -882,13 +882,17 @@ sc_require_enum_last_marker:
{ echo '$(ME): enum impl needs _LAST marker on second line' 1>&2; \ { echo '$(ME): enum impl needs _LAST marker on second line' 1>&2; \
exit 1; } || : exit 1; } || :
# Validate many python style rules # We're intentionally ignoring a few warnings
FLAKE8_LINE_LENGTH = E501 #
FLAKE8_WARNINGS = W504 # E501: Force breaking lines at < 80 characters results in
# some really unnatural code formatting which harms
FLAKE8_IGNORE = $(FLAKE8_LINE_LENGTH),$\ # readability.
$(FLAKE8_WARNINGS) \ #
$(NULL) # W504: Knuth code style requires the operators "or" and "and" etc
# to be at the start of line in a multi-line conditional.
# This the opposite to what is normal libvirt practice.
#
FLAKE8_IGNORE = E501,W504
sc_flake8: sc_flake8:
@if [ -n "$(FLAKE8)" ]; then \ @if [ -n "$(FLAKE8)" ]; then \