External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-08 23:35:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unregister event callback if a fatal error occurs during dispatch

Browse Source 
If we get an I/O error in the async event callback for an RPC
client, we might not have consumed all pending data off the
wire. This could result in the callback being immediately
invoked again. At which point the same I/O might occur. And
we're invoked again. And again...And again...

Unregistering the async event callback if an error occurs is
a good safety net. The real error will be seen when the next
RPC method is invoked

* src/rpc/virnetclient.c: Unregister event callback on error
This commit is contained in:
Daniel P. Berrange 2011-07-15 11:19:40 +01:00
parent 8665f85523
commit 07b39a9418
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/rpc/virnetclient.c
View File

@ -1117,8 +1117,10 @@ void virNetClientIncomingEvent(virNetSocketPtr sock,
goto done; goto done;
} }
if (virNetClientIOHandleInput(client) < 0) if (virNetClientIOHandleInput(client) < 0) {
VIR_DEBUG("Something went wrong during async message processing"); VIR_WARN("Something went wrong during async message processing");
virNetSocketRemoveIOCallback(sock);
}
done: done:
virNetClientUnlock(client); virNetClientUnlock(client);